From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Rybchenko Subject: Re: [PATCH 2/2] bus/vdev: fix hotplug twice Date: Mon, 25 Feb 2019 10:50:28 +0300 Message-ID: <19f468b3-9c2b-af91-58a5-5a23b5744a88@solarflare.com> References: <20190221190125.24140-1-thomas@monjalon.net> <20190221190125.24140-3-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: Raslan Darawsheh , To: Thomas Monjalon , Return-path: In-Reply-To: <20190221190125.24140-3-thomas@monjalon.net> Content-Language: en-GB List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/21/19 10:01 PM, Thomas Monjalon wrote: > From: Raslan Darawsheh > > In case vdev was already probed, it shouldn't be probed again, > and it should return -EEXIST as error. > There are some checks in vdev_probe() and insert_vdev(), > but a check was missing in vdev_plug(). > The check is moved in vdev_probe_all_drivers() which is called > in all code paths. > > Fixes: e9d159c3d534 ("eal: allow probing a device again") > Cc: stable@dpdk.org > > Signed-off-by: Raslan Darawsheh > Signed-off-by: Thomas Monjalon > Reviewed-by: Andrew Rybchenko