From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915/pmu: Measure sampler intervals Date: Wed, 30 May 2018 11:57:39 +0100 Message-ID: <19f68715-2cf5-7d5f-f85a-5bfc0b931682@linux.intel.com> References: <20180525171111.6812-1-chris@chris-wilson.co.uk> <827eb4b5-34af-6b5c-a253-28a4498ad3e8@linux.intel.com> <152727032001.4081.11507120445895299604@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id C271473B6A for ; Wed, 30 May 2018 10:57:41 +0000 (UTC) In-Reply-To: <152727032001.4081.11507120445895299604@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI1LzA1LzIwMTggMTg6NDUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA1LTI1IDE4OjMxOjM1KQo+Pgo+PiBPbiAyNS8wNS8yMDE4IDE4OjEx LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBocnRpbWVyIGlzIG5vdCByZWxpYWJsZSBlbm91Z2gg dG8gYXNzdW1lIGZpeGVkIGludGVydmFscywgYW5kIHNvIGV2ZW4KPj4+IGNvYXJzZSBhY2N1cmFj eSAoaW4gdGhlIGZhY2Ugb2Yga2FzYW4gYW5kIHNpbWlsYXIgaGVhdnkgZGVidWdnaW5nKSB3ZQo+ Pj4gbmVlZCB0byBtZWFzdXJlIHRoZSBhY3R1YWwgaW50ZXJ2YWwgYmV0d2VlbiBzYW1wbGUuCj4+ Cj4+IEl0IGRvZXNuJ3QgZXZlbiBhdmVyYWdlIG91dCB0byBzb21ldGhpbmcgYWNjZXB0YWJsZSB1 bmRlciBzdWNoIEtjb25maWdzPwo+PiBIb3Jyb3IuLiBwcmVjaXNlIGJ1dCBpbmFjY3VyYXRlLiAv T1wKPj4KPj4+IFdoaWxlIHVzaW5nIGEgc2luZ2xlIHRpbWVzdGFtcCB0byBjb21wdXRlIHRoZSBp bnRlcnZhbCBkb2VzIG5vdCBhbGxvdwo+Pj4gdmVyeSBmaW5lIGFjY3VyYWN5IChjb25zaWRlciB0 aGUgaW1wYWN0IG9mIGEgc2xvdyBmb3JjZXdha2UgYmV0d2Vlbgo+Pj4gZGlmZmVyZW50IHNhbXBs ZXMgYWZ0ZXIgdGhlIHRpbWVzdGFtcCBpcyByZWFkKSBpcyBtdWNoIGJldHRlciB0aGFuCj4+PiBh c3N1bWluZyB0aGUgaW50ZXJ2YWwuCj4+Pgo+Pj4gVGVzdGNhc2U6IGlndC9wZXJmX3BtdSAjaXZi Cj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPj4+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4g LS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jIHwgMjAgKysrKysrKysr KysrKy0tLS0tLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmggfCAgNCAr KysrCj4+PiAgICAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25z KC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4+PiBpbmRleCBkYzg3Nzk3ZGI1MDAu LmY1MDg3NTE1ZWI0MyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cG11LmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMKPj4+IEBAIC0x MjcsNiArMTI3LDcgQEAgc3RhdGljIHZvaWQgX19pOTE1X3BtdV9tYXliZV9zdGFydF90aW1lcihz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPj4+ICAgIHsKPj4+ICAgICAgICBpZiAoIWk5 MTUtPnBtdS50aW1lcl9lbmFibGVkICYmIHBtdV9uZWVkc190aW1lcihpOTE1LCB0cnVlKSkgewo+ Pj4gICAgICAgICAgICAgICAgaTkxNS0+cG11LnRpbWVyX2VuYWJsZWQgPSB0cnVlOwo+Pj4gKyAg ICAgICAgICAgICBpOTE1LT5wbXUudGltZXN0YW1wID0ga3RpbWVfZ2V0KCk7Cj4+PiAgICAgICAg ICAgICAgICBocnRpbWVyX3N0YXJ0X3JhbmdlX25zKCZpOTE1LT5wbXUudGltZXIsCj4+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5zX3RvX2t0aW1lKFBFUklPRCksIDAs Cj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEhSVElNRVJfTU9ERV9S RUxfUElOTkVEKTsKPj4+IEBAIC0xNjAsNyArMTYxLDcgQEAgdXBkYXRlX3NhbXBsZShzdHJ1Y3Qg aTkxNV9wbXVfc2FtcGxlICpzYW1wbGUsIHUzMiB1bml0LCB1MzIgdmFsKQo+Pj4gICAgICAgIHNh bXBsZS0+Y3VyICs9IG11bF91MzJfdTMyKHZhbCwgdW5pdCk7Cj4+PiAgICB9Cj4+PiAgICAKPj4+ IC1zdGF0aWMgdm9pZCBlbmdpbmVzX3NhbXBsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4+PiArc3RhdGljIHZvaWQgZW5naW5lc19zYW1wbGUoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCB1NjQgcGVyaW9kKQo+Pj4gICAgewo+Pj4gICAgICAgIHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPj4+ICAgICAgICBlbnVtIGludGVsX2VuZ2luZV9pZCBp ZDsKPj4+IEBAIC0xODMsNyArMTg0LDcgQEAgc3RhdGljIHZvaWQgZW5naW5lc19zYW1wbGUoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Pj4gICAgICAgICAgICAgICAgdmFsID0g IWk5MTVfc2Vxbm9fcGFzc2VkKGN1cnJlbnRfc2Vxbm8sIGxhc3Rfc2Vxbm8pOwo+Pj4gICAgCj4+ PiAgICAgICAgICAgICAgICB1cGRhdGVfc2FtcGxlKCZlbmdpbmUtPnBtdS5zYW1wbGVbSTkxNV9T QU1QTEVfQlVTWV0sCj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgUEVSSU9ELCB2YWwp Owo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHBlcmlvZCwgdmFsKTsKPj4+ICAgIAo+ Pj4gICAgICAgICAgICAgICAgaWYgKHZhbCAmJiAoZW5naW5lLT5wbXUuZW5hYmxlICYKPj4+ICAg ICAgICAgICAgICAgICAgICAoQklUKEk5MTVfU0FNUExFX1dBSVQpIHwgQklUKEk5MTVfU0FNUExF X1NFTUEpKSkpIHsKPj4+IEBAIC0xOTUsMTAgKzE5NiwxMCBAQCBzdGF0aWMgdm9pZCBlbmdpbmVz X3NhbXBsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+PiAgICAgICAgICAg ICAgICB9Cj4+PiAgICAKPj4+ICAgICAgICAgICAgICAgIHVwZGF0ZV9zYW1wbGUoJmVuZ2luZS0+ cG11LnNhbXBsZVtJOTE1X1NBTVBMRV9XQUlUXSwKPj4+IC0gICAgICAgICAgICAgICAgICAgICAg ICAgICBQRVJJT0QsICEhKHZhbCAmIFJJTkdfV0FJVCkpOwo+Pj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgIHBlcmlvZCwgISEodmFsICYgUklOR19XQUlUKSk7Cj4+PiAgICAKPj4+ICAgICAg ICAgICAgICAgIHVwZGF0ZV9zYW1wbGUoJmVuZ2luZS0+cG11LnNhbXBsZVtJOTE1X1NBTVBMRV9T RU1BXSwKPj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICBQRVJJT0QsICEhKHZhbCAmIFJJ TkdfV0FJVF9TRU1BUEhPUkUpKTsKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBwZXJp b2QsICEhKHZhbCAmIFJJTkdfV0FJVF9TRU1BUEhPUkUpKTsKPj4+ICAgICAgICB9Cj4+PiAgICAK Pj4+ICAgICAgICBpZiAoZncpCj4+PiBAQCAtMjA3LDcgKzIwOCw3IEBAIHN0YXRpYyB2b2lkIGVu Z2luZXNfc2FtcGxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4+ICAgICAg ICBpbnRlbF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4+PiAgICB9Cj4+PiAgICAKPj4+IC1z dGF0aWMgdm9pZCBmcmVxdWVuY3lfc2FtcGxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPj4+ICtzdGF0aWMgdm9pZCBmcmVxdWVuY3lfc2FtcGxlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwgdTY0IHBlcmlvZCkKPj4KPj4gUGVyaW9kIGlzIHVudXNlZCBpbiB0 aGlzIGZ1bmN0aW9uLgo+Pgo+PiBCdXQgbW9yZSBpbXBvcnRhbnRseSB0aGF0IGxlYWRzIHRvIGEg cHJvYmxlbS4gV2hlbiByZWFkaW5nIHRoZSBjb3VudGVyCj4+IHRoZSBmcmVxdWVuY2llcyBhY2N1 bXVsYXRvciBpcyBkaXZpZGVkIGJ5IEZSRVFVRU5DWSBkZWZpbmUsIHdoaWNoIGlzCj4+IGludmVy c2Ugb2YgUEVSSU9ELiBJZiB0aGUgZXJyb3IgaXMgYmlnIGVub3VnaCB0byBtZXNzIHVwIHRoZSBl bmdpbmVzCj4+IHNhbXBsaW5nLCBpcyBpdCBiaWcgZW5vdWdoIHRvIGFmZmVjdCB0aGUgZnJlcXVl bmNpZXMgYXMgd2VsbD8KPiAKPiBZZXMsIGJ1dCBmaXhpbmcgdXAgZnJlcXVlbmNpZXMgSSBsZWZ0 IGZvciBhbm90aGVyIHBhdGNoLCBiZWNhdXNlIGl0J3MKPiBnb2luZyB0byBiZSBtb3JlIGludm9s dmVkIChoYXZpbmcgdG8gY2hvb3NlIHRoZSBkaXZpZGVyIG1vcmUgY2FyZWZ1bGx5KQo+IGFuZCB3 b3VsZCB5b3UgYmVsaWV2ZSBpdCwgYnV0IENJIG9ubHkgY29tcGxhaW5zIGFib3V0IGJ1c3kgc2Ft cGxpbmcgOykKPiAKPiBJIHBhc3NlZCBpbiB0aGUgcGVyaW9kIGFzIGEgcmVtaW5kZXIuCgpJdCBt aWdodCBvbmx5IHJlbWluZCBzb21lb25lIHRvIHJlbW92ZSB0aGUgdW51c2VkIHZhcmlhYmxlIHNv IEkgYW0gbm90IApzdXJlIGl0IGlzIHdvcnRoIGl0LgoKPj4gSW1wcm92aW5nIHRoYXQgd291bGQg bmVlZCBhdmVyYWdlIGZyZXF1ZW5jeSBiZXR3ZWVuIHR3byBjb3VudGVyIHJlYWRzLgo+PiBXaGlj aCBsb29rcyB0cmlja3kgdG8gc2hvZWhvcm4gaW50byB0aGUgcG11IGFwaS4gTWF5YmUgcHJpbWl0 aXZlIHJ1bm5pbmcKPj4gYXZlcmFnZSB3b3VsZCBkby4KPiAKPiBNeSBwbGFuIHdhcyB0byBleHBv c2UgY3ljbGVzIChGcmVxdWVuY3kgeCB0aW1lKSB0byB0aGUgdXNlciwgYW5kIHRoZW4KPiB0aGV5 IGNhbGN1bGF0ZSBmcmVxdWVuY3kgYnkgdGhlIGNvbXBhcmluZyB0aGVpciBvd24gc2FtcGxlcy4g KFNpbmNlIHdlCj4gZ2l2ZSB0aGVtICh0aW1lLCBzYW1wbGVzKSBmb3IgZWFjaCBwbXUgcmVhZCku CgpGcmVxdWVuY3kgdGltZXMgd2hpY2ggdGltZT8gT24gcmVhZD8gRG9uJ3QgZXhhY3RseSBmb2xs b3cuIDooCgo+IAo+Pj4gICAgewo+Pj4gICAgICAgIGlmIChkZXZfcHJpdi0+cG11LmVuYWJsZSAm Cj4+PiAgICAgICAgICAgIGNvbmZpZ19lbmFibGVkX21hc2soSTkxNV9QTVVfQUNUVUFMX0ZSRVFV RU5DWSkpIHsKPj4+IEBAIC0yMzcsMTIgKzIzOCwxNyBAQCBzdGF0aWMgZW51bSBocnRpbWVyX3Jl c3RhcnQgaTkxNV9zYW1wbGUoc3RydWN0IGhydGltZXIgKmhydGltZXIpCj4+PiAgICB7Cj4+PiAg ICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPQo+Pj4gICAgICAgICAgICAgICAg Y29udGFpbmVyX29mKGhydGltZXIsIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlLCBwbXUudGltZXIp Owo+Pj4gKyAgICAga3RpbWVfdCBub3csIHBlcmlvZDsKPj4+ICAgIAo+Pj4gICAgICAgIGlmICgh UkVBRF9PTkNFKGk5MTUtPnBtdS50aW1lcl9lbmFibGVkKSkKPj4+ICAgICAgICAgICAgICAgIHJl dHVybiBIUlRJTUVSX05PUkVTVEFSVDsKPj4+ICAgIAo+Pj4gLSAgICAgZW5naW5lc19zYW1wbGUo aTkxNSk7Cj4+PiAtICAgICBmcmVxdWVuY3lfc2FtcGxlKGk5MTUpOwo+Pj4gKyAgICAgbm93ID0g a3RpbWVfZ2V0KCk7Cj4+PiArICAgICBwZXJpb2QgPSBrdGltZV9zdWIobm93LCBpOTE1LT5wbXUu dGltZXN0YW1wKTsKPj4+ICsgICAgIGk5MTUtPnBtdS50aW1lc3RhbXAgPSBub3c7Cj4+PiArCj4+ PiArICAgICBlbmdpbmVzX3NhbXBsZShpOTE1LCBwZXJpb2QpOwo+Pj4gKyAgICAgZnJlcXVlbmN5 X3NhbXBsZShpOTE1LCBwZXJpb2QpOwo+Pj4gICAgCj4+PiAgICAgICAgaHJ0aW1lcl9mb3J3YXJk X25vdyhocnRpbWVyLCBuc190b19rdGltZShQRVJJT0QpKTsKPj4+ICAgICAgICByZXR1cm4gSFJU SU1FUl9SRVNUQVJUOwo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cG11LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5oCj4+PiBpbmRleCAyYmE3MzUy OTlmN2MuLjBmMWU0NjQyMDc3ZSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcG11LmgKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmgKPj4+ IEBAIC01Miw2ICs1MiwxMCBAQCBzdHJ1Y3QgaTkxNV9wbXUgewo+Pj4gICAgICAgICAqIEB0aW1l cjogVGltZXIgZm9yIGludGVybmFsIGk5MTUgUE1VIHNhbXBsaW5nLgo+Pj4gICAgICAgICAqLwo+ Pj4gICAgICAgIHN0cnVjdCBocnRpbWVyIHRpbWVyOwo+Pj4gKyAgICAgLyoqCj4+PiArICAgICAg KiBAdGltZXN0YW1wOiBUaW1lc3RhbXAgb2YgbGFzdCBpbnRlcm5hbCBpOTE1IFBNVSBzYW1wbGlu Zy4KPj4+ICsgICAgICAqLwo+Pj4gKyAgICAga3RpbWVfdCB0aW1lc3RhbXA7Cj4+PiAgICAgICAg LyoqCj4+PiAgICAgICAgICogQGVuYWJsZTogQml0bWFzayBvZiBhbGwgY3VycmVudGx5IGVuYWJs ZWQgZXZlbnRzLgo+Pj4gICAgICAgICAqCj4+Pgo+Pgo+PiBQYXRjaCBsb29rcyBva2F5LCBqdXN0 IGxvc2VzIHRoZSBzb21lIG9mIHRoZSBvcHRpbWlzYXRpb24gcG90ZW50aWFsIHNvIEkKPj4gYW0g Z3Vlc3Npbmcgd2Ugd29uJ3QgYmUgdGhpbmtpbmcgYWJvdXQgcmVwbGFjaW5nIG11bHRpcGxpZXMg YW5kIGRpdmlkZXMKPj4gd2l0aCBzaGlmdCBhbnkgbW9yZS4gOikKPj4KPj4gQnV0IHRoZSBxdWVz dGlvbiBvZiBmcmVxdWVuY3kgY291bnRlcnMgaXMgbm93IGJvdGhlcmluZyBtZS4KPj4KPj4gQW5k IGlmIHRoaXMgcHJvYmxlbSBpcyBsaW1pdGVkIHRvIEthc2FuIHRoZW4gaG93IG11Y2ggd2Ugd2Fu dCB0bwo+PiBjb21wbGljYXRlIHRoaW5ncyB0byBtYWtlIHRoYXQgd29yaz8KPiAKPiBOb3QganVz dCBrYXNhbiwgYnV0IGl2YiByZWFsbHkuIFRoYXQncyB0aGUgb25seSB0byBoYXZlIG5ldmVyIHdv cmtlZAo+IHdoYXRldmVyIHRoZSBjb25maWcuIGthc2FuIGFmZmVjdHMgbW9yZSBDSSBtYWNoaW5l cy4KCkkgYW0gYWxzbyB0aGlua2luZyB0aGF0IHdpdGggdGhpcyBhcHByb2FjaCB3ZSBjb3VsZCBz dGFydCBhbGxvd2luZyB0aW1lciAKc2xhY2ssIHNpbmNlIHdlIGFyZSBtZWFzdXJpbmcgaXQgYW55 d2F5LiBJdCB3b3VsZCByZWxlYXNlIGJhY2sgc29tZSBvZiAKdGhlIGFkZGVkIGNvc3Qgb2YgdGlt ZSBxdWVyaWVzLiBXZWxsLCBub3QgdGhhdCB0aGV5IGFyZSBzaWduaWZpY2FudC4gCkRpZ3Jlc3Np b24gYW55d2F5LgoKSSB3YW50IHRvIHVuZGVyc3RhbmQgd2h5IHRoaXMgaXMgYSBwcm9ibGVtIG9u IElWQiBhbmQgd2hhdCBpcyB0aGUgCnNvbHV0aW9uIGZvciBmcmVxdWVuY3kgY291bnRlcnMuCgpS ZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=