From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n9NHxhpU225193 for ; Fri, 23 Oct 2009 12:59:43 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Subject: RE: [PATCH 8/8] fs/xfs/xfs_log_recover.c: Use %pU to print UUIDs Date: Fri, 23 Oct 2009 13:01:15 -0500 Message-ID: <1AB9A794DBDDF54A8A81BE2296F7BDFE83AE07@cf--amer001e--3.americas.sgi.com> In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE83AD41@cf--amer001e--3.americas.sgi.com> From: "Alex Elder" List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Joe Perches Cc: xfs@oss.sgi.com Alex Elder wrote: > Joe Perches wrote: >> Signed-off-by: Joe Perches >> --- >> fs/xfs/xfs_log_recover.c | 14 ++++---------- >> 1 files changed, 4 insertions(+), 10 deletions(-) > > I think this looks OK, but I'm going to hold of until > I see the core support in lib/vsprintf.c committed > before I pull it into the XFS repository. > > -Alex I just wanted to follow up on this. Andrew Morton has agreed to integrate this patch along with the vsprintf.c one, so it will show up eventually. -Alex >> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index 1099395..3b8e3df 100644 >> --- a/fs/xfs/xfs_log_recover.c >> +++ b/fs/xfs/xfs_log_recover.c >> @@ -225,16 +225,10 @@ xlog_header_check_dump( >> xfs_mount_t *mp, >> xlog_rec_header_t *head) >> { >> - int b; >> - >> - cmn_err(CE_DEBUG, "%s: SB : uuid = ", __func__); >> - for (b = 0; b < 16; b++) >> - cmn_err(CE_DEBUG, "%02x", ((__uint8_t *)&mp->m_sb.sb_uuid)[b]); >> - cmn_err(CE_DEBUG, ", fmt = %d\n", XLOG_FMT); >> - cmn_err(CE_DEBUG, " log : uuid = "); >> - for (b = 0; b < 16; b++) >> - cmn_err(CE_DEBUG, "%02x", ((__uint8_t *)&head->h_fs_uuid)[b]); >> - cmn_err(CE_DEBUG, ", fmt = %d\n", be32_to_cpu(head->h_fmt)); >> + cmn_err(CE_DEBUG, "%s: SB : uuid = %pU, fmt = %d\n", >> + __func__, &mp->m_sb.sb_uuid, XLOG_FMT); >> + cmn_err(CE_DEBUG, " log : uuid = %pU, fmt = %d\n", >> + &head->h_fs_uuid, be32_to_cpu(head->h_fmt)); >> } >> #else >> #define xlog_header_check_dump(mp, head) > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs