From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zheng, Lv" Subject: RE: [PATCH 1/6] ACPI/EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag. Date: Wed, 19 Nov 2014 08:55:25 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E88026A36FB@SHSMSX101.ccr.corp.intel.com> References: <1AE640813FDE7649BE1B193DEA596E8802689778@SHSMSX101.ccr.corp.intel.com> <20141118132328.GA27428@node.dhcp.inet.fi> <4486101.LWS7CexbAj@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4486101.LWS7CexbAj@vostro.rjw.lan> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" , "Kirill A. Shutemov" Cc: "Wysocki, Rafael J" , "Brown, Len" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" List-Id: linux-acpi@vger.kernel.org SGksIFJhZmFlbA0KDQpJIHRoaW5rIHlvdSBrbm93IHRoaXMgaXNzdWUuDQoNCiBbUEFUQ0ggMV0g Y2FuIHRyaWdnZXIgdGhpcyBkZWFkIGxvY2sgYmVjYXVzZSBpdCBpcyBhY3R1YWxseSBiYXNlZCBv biBhbm90aGVyIEdQRSBkZWFkIGxvY2sgZml4aW5nIHNlcmllcy4NCkkgaGF2ZSBmaXhlZCB0aGUg ZGVhZCBsb2NrIGluIGFjcGlfZXZfZ3BlX2RldGVjdCgpIG9yIGFjcGlfZXZfZ3BlX2Rpc3BhdGNo KCkuDQpUaGUgcHJvYmxlbSBpcyB0aGV5IGhhdmVuJ3QgYmVlbiB1cHN0cmVhbWVkIHRvIEFDUElD QSwgc28gSSBjb3VsZG4ndCBwb3N0IHRoZW0gaGVyZS4NCg0KSSB3YXMgdGhpbmtpbmcgd2UgY2Fu IHdvcmsgdGhpcyBhcm91bmQgYnkgYXBwbHlpbmcgdGhlIGFjcGlfb3Nfd2FpdF9ldmVudHNfY29t cGxldGUoKSBlbmhhbmNlbWVudCBzdXBwb3J0IHByaW9yIHRoYW4gYXBwbHlpbmcgdGhpcyAgYmVj YXVzZSBpdCBjYW4gb25seSBoYXBwZW4gaW4gc3VzcGVuZC4NCkJ1dCBpdCBzZWVtcyB0aGlzIGNh biBhbHNvIGJlIHRyaWdnZXJlZCBkdXJpbmcgYm9vdC4NCg0KU28gd2UgY2FuIGhhdmUgMyBjaG9p Y2VzIGhlcmUgaW4gb3JkZXIgdG8gbWVyZ2UgdGhpcyBzZXJpZXM6DQoxLiBNZXJnaW5nIHRoZSBH UEUgZGVhZCBsb2NrIGZpeCBiZWZvcmUgaXQgaXMgbWVyZ2VkIGluIHRoZSBBQ1BJQ0EgdXBzdHJl YW0uDQoyLiBDaGFuZ2luZyBbUEFUQ0ggMV0gYW5kIGRvIG5vdCBob2xkIEVDIGxvY2sgY3VycmVu dGx5ICh0aG91Z2ggaXQgaXMgcmFjeSwgaXQgaXMgY3VycmVudGx5IHJhY3kpLg0KMy4gUmV2ZXJ0 aW5nIFtQQVRDSCAxLTRdIGFuZCB3YWl0IHVudGlsIEdQRSBkZWFkIGxvY2sgZml4ZWQgaW4gQUNQ SUNBIHVwc3RyZWFtLg0KV2hpY2ggb25lIGRvIHlvdSBwcmVmZXI/DQoNCklNTywgd2UgaGF2ZSBz ZXZlcmFsIGlzc3VlcywgdGhlaXIgZml4ZXMgZm9ybSBhIGRlcGVuZGVuY3kgY2lyY2xlOg0KMS4g R1BFIGRlYWQgbG9jazogaXQgbWF5IGRlcGVuZHMgb24gRElTUEFUQ0hfTUVUSE9EIGZsdXNoaW5n ICh3ZSBzaG91bGRuJ3QgYnVtcCBlbmFibGluZyBzdGF0dXMgdXAgaW4gYWNwaV9ldl9hc3luY2hf ZW5hYmxlX2dwZSgpKQ0KMi4gRUMgdHJhbnNhY3Rpb24gZmx1c2hpbmc6IGl0IGRlcGVuZHMgb24g dGhlIEdQRSBkZWFkIGxvY2sNCjMuIEVDIGV2ZW50IHBvbGxpbmc6IGl0IGRlcGVuZHMgb24gdGhl IEVDIHRyYW5zYWN0aW9uIGZsdXNoaW5nLCB0aGlzIGlzIHJlcXVpcmVkIHRvIHN1cHBvcnQgRUMg ZXZlbnQgZHJhaW5pbmcgYXMgbWVudGlvbmVkIGluIGJ1Z3ppbGxhIDQ0MTYxDQo0LiBESVNQQVRD SF9NRVRIT0QgZmx1c2hpbmc6IGl0IGRlcGVuZHMgb24gRUMgZXZlbnQgcG9sbGluZywgaWYgd2Ug ZG9uJ3QgbW92ZSBFQyBxdWVyeSBmcm9tIHRoZSBfTHh4L19FeHggd29yayBxdWV1ZSwgdGhlbiBp dCBtYXkgYmxvY2sgRElTUEFUQ0hfTUVUSE9EIGZsdXNoaW5nLg0KU28gaXQgc2VlbXMgd2UgbmVl ZCB0byBkZXRlcm1pbmUgd2hpY2ggb25lIHNob3VsZCBiZSBtZXJnZWQgZmlyc3QuDQpJTU8sIHRo ZSBHUEUgZGVhZCBsb2NrIGZpeCBpcyB0aGUgbW9zdCBiYXNpYyBvbmUuDQoNClRoYW5rcyBhbmQg YmVzdCByZWdhcmRzDQotTHYNCg0KDQo+IEZyb206IFJhZmFlbCBKLiBXeXNvY2tpIFttYWlsdG86 cmp3QHJqd3lzb2NraS5uZXRdDQo+IFNlbnQ6IFdlZG5lc2RheSwgTm92ZW1iZXIgMTksIDIwMTQg NToyMCBBTQ0KPiBUbzogS2lyaWxsIEEuIFNodXRlbW92DQo+IENjOiBaaGVuZywgTHY7IFd5c29j a2ksIFJhZmFlbCBKOyBCcm93biwgTGVuOyBMdiBaaGVuZzsgbGludXgta2VybmVsQHZnZXIua2Vy bmVsLm9yZzsgbGludXgtYWNwaUB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD SCAxLzZdIEFDUEkvRUM6IEludHJvZHVjZSBTVEFSVEVEL1NUT1BQRUQgZmxhZ3MgdG8gcmVwbGFj ZSBCTE9DS0VEIGZsYWcuDQo+IA0KPiBPbiBUdWVzZGF5LCBOb3ZlbWJlciAxOCwgMjAxNCAwMzoy MzoyOCBQTSBLaXJpbGwgQS4gU2h1dGVtb3Ygd3JvdGU6DQo+ID4gT24gV2VkLCBOb3YgMDUsIDIw MTQgYXQgMDI6NTI6MzZBTSArMDAwMCwgWmhlbmcsIEx2IHdyb3RlOg0KPiANCj4gW2N1dF0NCj4g DQo+ID4NCj4gPiBIZXJlJ3MgbG9ja2RlcCB3YXJuaW5nIEkgc2VlIG9uIC1uZXh0Og0KPiANCj4g SXMgcGF0Y2ggWzEvNl0gc3VmZmljaWVudCB0byB0cmlnZ2VyIHRoaXMgb3IgZG8geW91IG5lZWQg YWxsIFsxLTQvNl0/DQo+IA0KPiANCj4gPiBbICAgIDAuNTEwMTU5XSA9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4gPiBbICAgIDAuNTEwMTcx XSBbIElORk86IHBvc3NpYmxlIGNpcmN1bGFyIGxvY2tpbmcgZGVwZW5kZW5jeSBkZXRlY3RlZCBd DQo+ID4gWyAgICAwLjUxMDE4NV0gMy4xOC4wLXJjNC1uZXh0LTIwMTQxMTE3LTA3NDA0LWc5ZGFk MmFiNmRmOGIgIzY2IE5vdCB0YWludGVkDQo+ID4gWyAgICAwLjUxMDE5N10gLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+IFsgICAgMC41 MTAyMDldIHN3YXBwZXIvMy8wIGlzIHRyeWluZyB0byBhY3F1aXJlIGxvY2s6DQo+ID4gWyAgICAw LjUxMDIxOV0gICgmKCZlYy0+bG9jayktPnJsb2NrKXstLi4uLi59LCBhdDogWzxmZmZmZmZmZjgx NGQ1MzNlPl0gYWNwaV9lY19ncGVfaGFuZGxlcisweDIxLzB4ZmMNCj4gPiBbICAgIDAuNTEwMjU0 XQ0KPiA+IFsgICAgMC41MTAyNTRdIGJ1dCB0YXNrIGlzIGFscmVhZHkgaG9sZGluZyBsb2NrOg0K PiA+IFsgICAgMC41MTAyNjZdICAoJigqKCZhY3BpX2dibF9ncGVfbG9jaykpLT5ybG9jayl7LS4u Li4ufSwgYXQ6IFs8ZmZmZmZmZmY4MTRjZDY3ZT5dIGFjcGlfb3NfYWNxdWlyZV9sb2NrKzB4ZS8w eDEwDQo+ID4gWyAgICAwLjUxMDI5Nl0NCj4gPiBbICAgIDAuNTEwMjk2XSB3aGljaCBsb2NrIGFs cmVhZHkgZGVwZW5kcyBvbiB0aGUgbmV3IGxvY2suDQo+ID4gWyAgICAwLjUxMDI5Nl0NCj4gPiBb ICAgIDAuNTEwMzEyXQ0KPiA+IFsgICAgMC41MTAzMTJdIHRoZSBleGlzdGluZyBkZXBlbmRlbmN5 IGNoYWluIChpbiByZXZlcnNlIG9yZGVyKSBpczoNCj4gPiBbICAgIDAuNTEwMzI3XQ0KPiA+IFsg ICAgMC41MTAzMjddIC0+ICMxICgmKCooJmFjcGlfZ2JsX2dwZV9sb2NrKSktPnJsb2NrKXstLi4u Li59Og0KPiA+IFsgICAgMC41MTAzNDRdICAgICAgICBbPGZmZmZmZmZmODExNThmNGY+XSBsb2Nr X2FjcXVpcmUrMHhkZi8weDJkMA0KPiA+IFsgICAgMC41MTAzNjRdICAgICAgICBbPGZmZmZmZmZm ODFiMDgwMTA+XSBfcmF3X3NwaW5fbG9ja19pcnFzYXZlKzB4NTAvMHg3MA0KPiA+IFsgICAgMC41 MTAzODFdICAgICAgICBbPGZmZmZmZmZmODE0Y2Q2N2U+XSBhY3BpX29zX2FjcXVpcmVfbG9jaysw eGUvMHgxMA0KPiA+IFsgICAgMC41MTAzOThdICAgICAgICBbPGZmZmZmZmZmODE0ZTMxZTg+XSBh Y3BpX2VuYWJsZV9ncGUrMHgyMi8weDY4DQo+ID4gWyAgICAwLjUxMDQxNl0gICAgICAgIFs8ZmZm ZmZmZmY4MTRkNWIyND5dIGFjcGlfZWNfc3RhcnQrMHg2Ni8weDg3DQo+ID4gWyAgICAwLjUxMDQz Ml0gICAgICAgIFs8ZmZmZmZmZmY4MWFmYzc3MT5dIGVjX2luc3RhbGxfaGFuZGxlcnMrMHg0MS8w eGE0DQo+ID4gWyAgICAwLjUxMDQ0OV0gICAgICAgIFs8ZmZmZmZmZmY4MjNlNzJiOT5dIGFjcGlf ZWNfZWNkdF9wcm9iZSsweDFhOS8weDFlYQ0KPiA+IFsgICAgMC41MTA0NjZdICAgICAgICBbPGZm ZmZmZmZmODIzZTZhZTM+XSBhY3BpX2luaXQrMHg4Yi8weDI2ZQ0KPiA+IFsgICAgMC41MTA0ODBd ICAgICAgICBbPGZmZmZmZmZmODEwMDIxNDg+XSBkb19vbmVfaW5pdGNhbGwrMHhkOC8weDIxMA0K PiA+IFsgICAgMC41MTA0OTZdICAgICAgICBbPGZmZmZmZmZmODIzOWYxZGM+XSBrZXJuZWxfaW5p dF9mcmVlYWJsZSsweDFmNS8weDI4Mg0KPiA+IFsgICAgMC41MTA1MTNdICAgICAgICBbPGZmZmZm ZmZmODFhZjFhMWU+XSBrZXJuZWxfaW5pdCsweGUvMHhmMA0KPiA+IFsgICAgMC41MTA1MjddICAg ICAgICBbPGZmZmZmZmZmODFiMDhjZmM+XSByZXRfZnJvbV9mb3JrKzB4N2MvMHhiMA0KPiA+IFsg ICAgMC41MTA1NDJdDQo+ID4gWyAgICAwLjUxMDU0Ml0gLT4gIzAgKCYoJmVjLT5sb2NrKS0+cmxv Y2spey0uLi4uLn06DQo+ID4gWyAgICAwLjUxMDU1OF0gICAgICAgIFs8ZmZmZmZmZmY4MTE1ODVl Zj5dIF9fbG9ja19hY3F1aXJlKzB4MjEwZi8weDIyMjANCj4gPiBbICAgIDAuNTEwNTc0XSAgICAg ICAgWzxmZmZmZmZmZjgxMTU4ZjRmPl0gbG9ja19hY3F1aXJlKzB4ZGYvMHgyZDANCj4gPiBbICAg IDAuNTEwNTg5XSAgICAgICAgWzxmZmZmZmZmZjgxYjA4MDEwPl0gX3Jhd19zcGluX2xvY2tfaXJx c2F2ZSsweDUwLzB4NzANCj4gPiBbICAgIDAuNTEwNjA0XSAgICAgICAgWzxmZmZmZmZmZjgxNGQ1 MzNlPl0gYWNwaV9lY19ncGVfaGFuZGxlcisweDIxLzB4ZmMNCj4gPiBbICAgIDAuNTEwNjIwXSAg ICAgICAgWzxmZmZmZmZmZjgxNGUwMmMyPl0gYWNwaV9ldl9ncGVfZGlzcGF0Y2grMHhkMi8weDE0 Mw0KPiA+IFsgICAgMC41MTA2MzZdICAgICAgICBbPGZmZmZmZmZmODE0ZTAzZmI+XSBhY3BpX2V2 X2dwZV9kZXRlY3QrMHhjOC8weDEwZg0KPiA+IFsgICAgMC41MTA2NTJdICAgICAgICBbPGZmZmZm ZmZmODE0ZTIzYjY+XSBhY3BpX2V2X3NjaV94cnVwdF9oYW5kbGVyKzB4MjIvMHgzOA0KPiA+IFsg ICAgMC41MTA2NjldICAgICAgICBbPGZmZmZmZmZmODE0Y2M4ZWU+XSBhY3BpX2lycSsweDE2LzB4 MzENCj4gPiBbICAgIDAuNTEwNjg0XSAgICAgICAgWzxmZmZmZmZmZjgxMTZlY2NmPl0gaGFuZGxl X2lycV9ldmVudF9wZXJjcHUrMHg2Zi8weDU0MA0KPiA+IFsgICAgMC41MTA3MDJdICAgICAgICBb PGZmZmZmZmZmODExNmYxZTE+XSBoYW5kbGVfaXJxX2V2ZW50KzB4NDEvMHg3MA0KPiA+IFsgICAg MC41MTA3MThdICAgICAgICBbPGZmZmZmZmZmODExNzFlZjY+XSBoYW5kbGVfZmFzdGVvaV9pcnEr MHg4Ni8weDE0MA0KPiA+IFsgICAgMC41MTA3MzNdICAgICAgICBbPGZmZmZmZmZmODEwNzVhMjI+ XSBoYW5kbGVfaXJxKzB4MjIvMHg0MA0KPiA+IFsgICAgMC41MTA3NDhdICAgICAgICBbPGZmZmZm ZmZmODFiMGJlYWY+XSBkb19JUlErMHg0Zi8weGYwDQo+ID4gWyAgICAwLjUxMDc2Ml0gICAgICAg IFs8ZmZmZmZmZmY4MWIwOWJiMj5dIHJldF9mcm9tX2ludHIrMHgwLzB4MWENCj4gPiBbICAgIDAu NTEwNzc3XSAgICAgICAgWzxmZmZmZmZmZjgxMDdlNzgzPl0gZGVmYXVsdF9pZGxlKzB4MjMvMHgy NjANCj4gPiBbICAgIDAuNTEwNzkyXSAgICAgICAgWzxmZmZmZmZmZjgxMDdmMzVmPl0gYXJjaF9j cHVfaWRsZSsweGYvMHgyMA0KPiA+IFsgICAgMC41MTA4MDZdICAgICAgICBbPGZmZmZmZmZmODEx NGE5OWI+XSBjcHVfc3RhcnR1cF9lbnRyeSsweDM2Yi8weDViMA0KPiA+IFsgICAgMC41MTA4MjFd ICAgICAgICBbPGZmZmZmZmZmODEwYThkMDQ+XSBzdGFydF9zZWNvbmRhcnkrMHgxYTQvMHgxZDAN Cj4gPiBbICAgIDAuNTEwODQwXQ0KPiA+IFsgICAgMC41MTA4NDBdIG90aGVyIGluZm8gdGhhdCBt aWdodCBoZWxwIHVzIGRlYnVnIHRoaXM6DQo+ID4gWyAgICAwLjUxMDg0MF0NCj4gPiBbICAgIDAu NTEwODU2XSAgUG9zc2libGUgdW5zYWZlIGxvY2tpbmcgc2NlbmFyaW86DQo+ID4gWyAgICAwLjUx MDg1Nl0NCj4gPiBbICAgIDAuNTEwODY4XSAgICAgICAgQ1BVMCAgICAgICAgICAgICAgICAgICAg Q1BVMQ0KPiA+IFsgICAgMC41MTA4NzddICAgICAgICAtLS0tICAgICAgICAgICAgICAgICAgICAt LS0tDQo+ID4gWyAgICAwLjUxMDg4Nl0gICBsb2NrKCYoKigmYWNwaV9nYmxfZ3BlX2xvY2spKS0+ cmxvY2spOw0KPiA+IFsgICAgMC41MTA4OThdICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBsb2NrKCYoJmVjLT5sb2NrKS0+cmxvY2spOw0KPiA+IFsgICAgMC41MTA5MTJdICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBsb2NrKCYoKigmYWNwaV9nYmxfZ3BlX2xvY2spKS0+cmxv Y2spOw0KPiA+IFsgICAgMC41MTA5MjddICAgbG9jaygmKCZlYy0+bG9jayktPnJsb2NrKTsNCj4g PiBbICAgIDAuNTEwOTM4XQ0KPiA+IFsgICAgMC41MTA5MzhdICAqKiogREVBRExPQ0sgKioqDQo+ ID4gWyAgICAwLjUxMDkzOF0NCj4gPiBbICAgIDAuNTEwOTUzXSAxIGxvY2sgaGVsZCBieSBzd2Fw cGVyLzMvMDoNCj4gPiBbICAgIDAuNTEwOTYxXSAgIzA6ICAoJigqKCZhY3BpX2dibF9ncGVfbG9j aykpLT5ybG9jayl7LS4uLi4ufSwgYXQ6IFs8ZmZmZmZmZmY4MTRjZDY3ZT5dIGFjcGlfb3NfYWNx dWlyZV9sb2NrKzB4ZS8weDEwDQo+ID4gWyAgICAwLjUxMDk5MF0NCj4gPiBbICAgIDAuNTEwOTkw XSBzdGFjayBiYWNrdHJhY2U6DQo+ID4gWyAgICAwLjUxMTAwNF0gQ1BVOiAzIFBJRDogMCBDb21t OiBzd2FwcGVyLzMgTm90IHRhaW50ZWQgMy4xOC4wLXJjNC1uZXh0LTIwMTQxMTE3LTA3NDA0LWc5 ZGFkMmFiNmRmOGIgIzY2DQo+ID4gWyAgICAwLjUxMTAyMV0gSGFyZHdhcmUgbmFtZTogTEVOT1ZP IDM0NjBDQzYvMzQ2MENDNiwgQklPUyBHNkVUOTNXVyAoMi41MyApIDAyLzA0LzIwMTMNCj4gPiBb ICAgIDAuNTExMDM1XSAgZmZmZmZmZmY4MmNiMmY3MCBmZmZmODgwMTFlMmMzYmI4IGZmZmZmZmZm ODFhZmMzMTYgMDAwMDAwMDAwMDAwMDAxMQ0KPiA+IFsgICAgMC41MTEwNTVdICBmZmZmZmZmZjgy Y2IyZjcwIGZmZmY4ODAxMWUyYzNjMDggZmZmZmZmZmY4MWFmYWUxMSAwMDAwMDAwMDAwMDAwMDAx DQo+ID4gWyAgICAwLjUxMTA3NF0gIGZmZmY4ODAxMWUyYzNjNjggZmZmZjg4MDExZTJjM2MwOCBm ZmZmODgwMTE5M2Y5MmQwIGZmZmY4ODAxMTkzZjliMjANCj4gPiBbICAgIDAuNTExMDk0XSBDYWxs IFRyYWNlOg0KPiA+IFsgICAgMC41MTExMDFdICA8SVJRPiAgWzxmZmZmZmZmZjgxYWZjMzE2Pl0g ZHVtcF9zdGFjaysweDRjLzB4NmUNCj4gPiBbICAgIDAuNTExMTI1XSAgWzxmZmZmZmZmZjgxYWZh ZTExPl0gcHJpbnRfY2lyY3VsYXJfYnVnKzB4MmIyLzB4MmMzDQo+ID4gWyAgICAwLjUxMTE0Ml0g IFs8ZmZmZmZmZmY4MTE1ODVlZj5dIF9fbG9ja19hY3F1aXJlKzB4MjEwZi8weDIyMjANCj4gPiBb ICAgIDAuNTExMTU5XSAgWzxmZmZmZmZmZjgxMTU4ZjRmPl0gbG9ja19hY3F1aXJlKzB4ZGYvMHgy ZDANCj4gPiBbICAgIDAuNTExMTc2XSAgWzxmZmZmZmZmZjgxNGQ1MzNlPl0gPyBhY3BpX2VjX2dw ZV9oYW5kbGVyKzB4MjEvMHhmYw0KPiA+IFsgICAgMC41MTExOTJdICBbPGZmZmZmZmZmODFiMDgw MTA+XSBfcmF3X3NwaW5fbG9ja19pcnFzYXZlKzB4NTAvMHg3MA0KPiA+IFsgICAgMC41MTEyMDld ICBbPGZmZmZmZmZmODE0ZDUzM2U+XSA/IGFjcGlfZWNfZ3BlX2hhbmRsZXIrMHgyMS8weGZjDQo+ ID4gWyAgICAwLjUxMTIyNV0gIFs8ZmZmZmZmZmY4MTRlYTE5Mj5dID8gYWNwaV9od193cml0ZSsw eDRiLzB4NTINCj4gPiBbICAgIDAuNTExMjQxXSAgWzxmZmZmZmZmZjgxNGQ1MzNlPl0gYWNwaV9l Y19ncGVfaGFuZGxlcisweDIxLzB4ZmMNCj4gPiBbICAgIDAuNTExMjU4XSAgWzxmZmZmZmZmZjgx NGUwMmMyPl0gYWNwaV9ldl9ncGVfZGlzcGF0Y2grMHhkMi8weDE0Mw0KPiA+IFsgICAgMC41MTEy NzRdICBbPGZmZmZmZmZmODE0ZTAzZmI+XSBhY3BpX2V2X2dwZV9kZXRlY3QrMHhjOC8weDEwZg0K PiA+IFsgICAgMC41MTEyOTJdICBbPGZmZmZmZmZmODE0ZTIzYjY+XSBhY3BpX2V2X3NjaV94cnVw dF9oYW5kbGVyKzB4MjIvMHgzOA0KPiA+IFsgICAgMC41MTEzMDldICBbPGZmZmZmZmZmODE0Y2M4 ZWU+XSBhY3BpX2lycSsweDE2LzB4MzENCj4gPiBbICAgIDAuNTExMzI1XSAgWzxmZmZmZmZmZjgx MTZlY2NmPl0gaGFuZGxlX2lycV9ldmVudF9wZXJjcHUrMHg2Zi8weDU0MA0KPiA+IFsgICAgMC41 MTEzNDJdICBbPGZmZmZmZmZmODExNmYxZTE+XSBoYW5kbGVfaXJxX2V2ZW50KzB4NDEvMHg3MA0K PiA+IFsgICAgMC41MTEzNTddICBbPGZmZmZmZmZmODExNzFlOTg+XSA/IGhhbmRsZV9mYXN0ZW9p X2lycSsweDI4LzB4MTQwDQo+ID4gWyAgICAwLjUxMTM3Ml0gIFs8ZmZmZmZmZmY4MTE3MWVmNj5d IGhhbmRsZV9mYXN0ZW9pX2lycSsweDg2LzB4MTQwDQo+ID4gWyAgICAwLjUxMTM4OF0gIFs8ZmZm ZmZmZmY4MTA3NWEyMj5dIGhhbmRsZV9pcnErMHgyMi8weDQwDQo+ID4gWyAgICAwLjUxMTQwMl0g IFs8ZmZmZmZmZmY4MWIwYmVhZj5dIGRvX0lSUSsweDRmLzB4ZjANCj4gPiBbICAgIDAuNTExNDE3 XSAgWzxmZmZmZmZmZjgxYjA5YmIyPl0gY29tbW9uX2ludGVycnVwdCsweDcyLzB4NzINCj4gPiBb ICAgIDAuNTExNDI4XSAgPEVPST4gIFs8ZmZmZmZmZmY4MTBiODk4Nj5dID8gbmF0aXZlX3NhZmVf aGFsdCsweDYvMHgxMA0KPiA+IFsgICAgMC41MTE0NTRdICBbPGZmZmZmZmZmODExNTRmM2Q+XSA/ IHRyYWNlX2hhcmRpcnFzX29uKzB4ZC8weDEwDQo+ID4gWyAgICAwLjUxMTQ2OF0gIFs8ZmZmZmZm ZmY4MTA3ZTc4Mz5dIGRlZmF1bHRfaWRsZSsweDIzLzB4MjYwDQo+ID4gWyAgICAwLjUxMTQ4Ml0g IFs8ZmZmZmZmZmY4MTA3ZjM1Zj5dIGFyY2hfY3B1X2lkbGUrMHhmLzB4MjANCj4gPiBbICAgIDAu NTExNDk2XSAgWzxmZmZmZmZmZjgxMTRhOTliPl0gY3B1X3N0YXJ0dXBfZW50cnkrMHgzNmIvMHg1 YjANCj4gPiBbICAgIDAuNTExNTEyXSAgWzxmZmZmZmZmZjgxMGE4ZDA0Pl0gc3RhcnRfc2Vjb25k YXJ5KzB4MWE0LzB4MWQwDQo+ID4NCj4gPg0KPiA+DQo+IA0KPiAtLQ0KPiBJIHNwZWFrIG9ubHkg Zm9yIG15c2VsZi4NCj4gUmFmYWVsIEouIFd5c29ja2ksIEludGVsIE9wZW4gU291cmNlIFRlY2hu b2xvZ3kgQ2VudGVyLg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755569AbaKSJtp (ORCPT ); Wed, 19 Nov 2014 04:49:45 -0500 Received: from mga14.intel.com ([192.55.52.115]:28919 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753776AbaKSJti (ORCPT ); Wed, 19 Nov 2014 04:49:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="418557713" From: "Zheng, Lv" To: "Rafael J. Wysocki" , "Kirill A. Shutemov" CC: "Wysocki, Rafael J" , "Brown, Len" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: RE: [PATCH 1/6] ACPI/EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag. Thread-Topic: [PATCH 1/6] ACPI/EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag. Thread-Index: AQHP9yVTyINIm6IIIUqyDtdpynBt3JxRS4XwgBSlwQCAAIUygIABQsNA Date: Wed, 19 Nov 2014 08:55:25 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E88026A36FB@SHSMSX101.ccr.corp.intel.com> References: <1AE640813FDE7649BE1B193DEA596E8802689778@SHSMSX101.ccr.corp.intel.com> <20141118132328.GA27428@node.dhcp.inet.fi> <4486101.LWS7CexbAj@vostro.rjw.lan> In-Reply-To: <4486101.LWS7CexbAj@vostro.rjw.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id sAJ9nqM3030854 Hi, Rafael I think you know this issue. [PATCH 1] can trigger this dead lock because it is actually based on another GPE dead lock fixing series. I have fixed the dead lock in acpi_ev_gpe_detect() or acpi_ev_gpe_dispatch(). The problem is they haven't been upstreamed to ACPICA, so I couldn't post them here. I was thinking we can work this around by applying the acpi_os_wait_events_complete() enhancement support prior than applying this because it can only happen in suspend. But it seems this can also be triggered during boot. So we can have 3 choices here in order to merge this series: 1. Merging the GPE dead lock fix before it is merged in the ACPICA upstream. 2. Changing [PATCH 1] and do not hold EC lock currently (though it is racy, it is currently racy). 3. Reverting [PATCH 1-4] and wait until GPE dead lock fixed in ACPICA upstream. Which one do you prefer? IMO, we have several issues, their fixes form a dependency circle: 1. GPE dead lock: it may depends on DISPATCH_METHOD flushing (we shouldn't bump enabling status up in acpi_ev_asynch_enable_gpe()) 2. EC transaction flushing: it depends on the GPE dead lock 3. EC event polling: it depends on the EC transaction flushing, this is required to support EC event draining as mentioned in bugzilla 44161 4. DISPATCH_METHOD flushing: it depends on EC event polling, if we don't move EC query from the _Lxx/_Exx work queue, then it may block DISPATCH_METHOD flushing. So it seems we need to determine which one should be merged first. IMO, the GPE dead lock fix is the most basic one. Thanks and best regards -Lv > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Wednesday, November 19, 2014 5:20 AM > To: Kirill A. Shutemov > Cc: Zheng, Lv; Wysocki, Rafael J; Brown, Len; Lv Zheng; linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org > Subject: Re: [PATCH 1/6] ACPI/EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag. > > On Tuesday, November 18, 2014 03:23:28 PM Kirill A. Shutemov wrote: > > On Wed, Nov 05, 2014 at 02:52:36AM +0000, Zheng, Lv wrote: > > [cut] > > > > > Here's lockdep warning I see on -next: > > Is patch [1/6] sufficient to trigger this or do you need all [1-4/6]? > > > > [ 0.510159] ====================================================== > > [ 0.510171] [ INFO: possible circular locking dependency detected ] > > [ 0.510185] 3.18.0-rc4-next-20141117-07404-g9dad2ab6df8b #66 Not tainted > > [ 0.510197] ------------------------------------------------------- > > [ 0.510209] swapper/3/0 is trying to acquire lock: > > [ 0.510219] (&(&ec->lock)->rlock){-.....}, at: [] acpi_ec_gpe_handler+0x21/0xfc > > [ 0.510254] > > [ 0.510254] but task is already holding lock: > > [ 0.510266] (&(*(&acpi_gbl_gpe_lock))->rlock){-.....}, at: [] acpi_os_acquire_lock+0xe/0x10 > > [ 0.510296] > > [ 0.510296] which lock already depends on the new lock. > > [ 0.510296] > > [ 0.510312] > > [ 0.510312] the existing dependency chain (in reverse order) is: > > [ 0.510327] > > [ 0.510327] -> #1 (&(*(&acpi_gbl_gpe_lock))->rlock){-.....}: > > [ 0.510344] [] lock_acquire+0xdf/0x2d0 > > [ 0.510364] [] _raw_spin_lock_irqsave+0x50/0x70 > > [ 0.510381] [] acpi_os_acquire_lock+0xe/0x10 > > [ 0.510398] [] acpi_enable_gpe+0x22/0x68 > > [ 0.510416] [] acpi_ec_start+0x66/0x87 > > [ 0.510432] [] ec_install_handlers+0x41/0xa4 > > [ 0.510449] [] acpi_ec_ecdt_probe+0x1a9/0x1ea > > [ 0.510466] [] acpi_init+0x8b/0x26e > > [ 0.510480] [] do_one_initcall+0xd8/0x210 > > [ 0.510496] [] kernel_init_freeable+0x1f5/0x282 > > [ 0.510513] [] kernel_init+0xe/0xf0 > > [ 0.510527] [] ret_from_fork+0x7c/0xb0 > > [ 0.510542] > > [ 0.510542] -> #0 (&(&ec->lock)->rlock){-.....}: > > [ 0.510558] [] __lock_acquire+0x210f/0x2220 > > [ 0.510574] [] lock_acquire+0xdf/0x2d0 > > [ 0.510589] [] _raw_spin_lock_irqsave+0x50/0x70 > > [ 0.510604] [] acpi_ec_gpe_handler+0x21/0xfc > > [ 0.510620] [] acpi_ev_gpe_dispatch+0xd2/0x143 > > [ 0.510636] [] acpi_ev_gpe_detect+0xc8/0x10f > > [ 0.510652] [] acpi_ev_sci_xrupt_handler+0x22/0x38 > > [ 0.510669] [] acpi_irq+0x16/0x31 > > [ 0.510684] [] handle_irq_event_percpu+0x6f/0x540 > > [ 0.510702] [] handle_irq_event+0x41/0x70 > > [ 0.510718] [] handle_fasteoi_irq+0x86/0x140 > > [ 0.510733] [] handle_irq+0x22/0x40 > > [ 0.510748] [] do_IRQ+0x4f/0xf0 > > [ 0.510762] [] ret_from_intr+0x0/0x1a > > [ 0.510777] [] default_idle+0x23/0x260 > > [ 0.510792] [] arch_cpu_idle+0xf/0x20 > > [ 0.510806] [] cpu_startup_entry+0x36b/0x5b0 > > [ 0.510821] [] start_secondary+0x1a4/0x1d0 > > [ 0.510840] > > [ 0.510840] other info that might help us debug this: > > [ 0.510840] > > [ 0.510856] Possible unsafe locking scenario: > > [ 0.510856] > > [ 0.510868] CPU0 CPU1 > > [ 0.510877] ---- ---- > > [ 0.510886] lock(&(*(&acpi_gbl_gpe_lock))->rlock); > > [ 0.510898] lock(&(&ec->lock)->rlock); > > [ 0.510912] lock(&(*(&acpi_gbl_gpe_lock))->rlock); > > [ 0.510927] lock(&(&ec->lock)->rlock); > > [ 0.510938] > > [ 0.510938] *** DEADLOCK *** > > [ 0.510938] > > [ 0.510953] 1 lock held by swapper/3/0: > > [ 0.510961] #0: (&(*(&acpi_gbl_gpe_lock))->rlock){-.....}, at: [] acpi_os_acquire_lock+0xe/0x10 > > [ 0.510990] > > [ 0.510990] stack backtrace: > > [ 0.511004] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 3.18.0-rc4-next-20141117-07404-g9dad2ab6df8b #66 > > [ 0.511021] Hardware name: LENOVO 3460CC6/3460CC6, BIOS G6ET93WW (2.53 ) 02/04/2013 > > [ 0.511035] ffffffff82cb2f70 ffff88011e2c3bb8 ffffffff81afc316 0000000000000011 > > [ 0.511055] ffffffff82cb2f70 ffff88011e2c3c08 ffffffff81afae11 0000000000000001 > > [ 0.511074] ffff88011e2c3c68 ffff88011e2c3c08 ffff8801193f92d0 ffff8801193f9b20 > > [ 0.511094] Call Trace: > > [ 0.511101] [] dump_stack+0x4c/0x6e > > [ 0.511125] [] print_circular_bug+0x2b2/0x2c3 > > [ 0.511142] [] __lock_acquire+0x210f/0x2220 > > [ 0.511159] [] lock_acquire+0xdf/0x2d0 > > [ 0.511176] [] ? acpi_ec_gpe_handler+0x21/0xfc > > [ 0.511192] [] _raw_spin_lock_irqsave+0x50/0x70 > > [ 0.511209] [] ? acpi_ec_gpe_handler+0x21/0xfc > > [ 0.511225] [] ? acpi_hw_write+0x4b/0x52 > > [ 0.511241] [] acpi_ec_gpe_handler+0x21/0xfc > > [ 0.511258] [] acpi_ev_gpe_dispatch+0xd2/0x143 > > [ 0.511274] [] acpi_ev_gpe_detect+0xc8/0x10f > > [ 0.511292] [] acpi_ev_sci_xrupt_handler+0x22/0x38 > > [ 0.511309] [] acpi_irq+0x16/0x31 > > [ 0.511325] [] handle_irq_event_percpu+0x6f/0x540 > > [ 0.511342] [] handle_irq_event+0x41/0x70 > > [ 0.511357] [] ? handle_fasteoi_irq+0x28/0x140 > > [ 0.511372] [] handle_fasteoi_irq+0x86/0x140 > > [ 0.511388] [] handle_irq+0x22/0x40 > > [ 0.511402] [] do_IRQ+0x4f/0xf0 > > [ 0.511417] [] common_interrupt+0x72/0x72 > > [ 0.511428] [] ? native_safe_halt+0x6/0x10 > > [ 0.511454] [] ? trace_hardirqs_on+0xd/0x10 > > [ 0.511468] [] default_idle+0x23/0x260 > > [ 0.511482] [] arch_cpu_idle+0xf/0x20 > > [ 0.511496] [] cpu_startup_entry+0x36b/0x5b0 > > [ 0.511512] [] start_secondary+0x1a4/0x1d0 > > > > > > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I