All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Sandström" <Stefan.Sandstrom@axis.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2] Correct CRIS TCG register lifetime management
Date: Thu, 18 Feb 2021 20:10:48 +0000	[thread overview]
Message-ID: <1BD4E981-C339-495D-ABC1-74B0112CBC3E@axis.com> (raw)
In-Reply-To: <2fe233c0-dfa8-763d-b122-fdef8145ea06@amsat.org>



> On 18 Feb 2021, at 20:59, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> Hi Stefan,
> 
>> On 2/18/21 7:43 PM, Stefan Sandström wrote:
>> From: Stefan Sandstrom <stefans@axis.com>
>> 
>> Add and fix deallocation of temporary TCG registers in CRIS code
>> generation.
> 
> What did you run to figure this out?

Hi Philippe,

We were looking at the code in search for an issue that showed up when switching to a new version of GCC. 
It looked like QEMU executed the CRIS code wrong, so we took a look at the code. The problem turned out to be outside QEMU. These potential issues were spotted in the process.

> 
>> Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc
>> Signed-off-by: Stefan Sandstrom <stefans@axis.com>
>> ---
>> target/cris/translate.c         | 132 ++++++++++++++++++++++++++++------------
>> target/cris/translate_v10.c.inc |  70 ++++++++++++++-------
>> 2 files changed, 141 insertions(+), 61 deletions(-)

  reply	other threads:[~2021-02-18 20:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 18:43 [PATCH v2] Correct CRIS TCG register lifetime management Stefan Sandström
2021-02-18 18:47 ` Stefan Sandström
2021-02-18 19:59 ` Philippe Mathieu-Daudé
2021-02-18 20:10   ` Stefan Sandström [this message]
2021-02-18 20:26     ` Philippe Mathieu-Daudé
2021-02-19 10:29       ` Stefan Sandström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1BD4E981-C339-495D-ABC1-74B0112CBC3E@axis.com \
    --to=stefan.sandstrom@axis.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.