From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH] net/mlx: update C compliance standard
Date: Fri, 30 Jun 2017 18:14:56 +0000
Message-ID: <1C0F2AC4-AF9D-4A02-A35A-F70577FE67B5@mellanox.com>
References: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com>
 <c3e5f96d-bc1f-6cf6-b8b3-b5d0a13e3d20@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?iso-8859-1?Q?N=E9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0085.outbound.protection.outlook.com [104.47.0.85])
 by dpdk.org (Postfix) with ESMTP id 5CFE32BE1
 for <dev@dpdk.org>; Fri, 30 Jun 2017 20:14:58 +0200 (CEST)
In-Reply-To: <c3e5f96d-bc1f-6cf6-b8b3-b5d0a13e3d20@intel.com>
Content-Language: en-US
Content-ID: <19D62EE4AB761440B2FE2D6F054A6B7E@eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote=
:
>=20
> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote:
>> This commit addresses a compilation issue against Glibc >=3D 2.25, which
>> implements assert() through a nonstandard ({ }) construct. Such construc=
ts
>> can normally not be used without __extension__ keyword when -pedantic is
>> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode.
>>=20
>> While assert.h checks for the compiler ability to support GNU extensions=
,
>> Clang, unlike GCC, does not allow the above syntax when combining
>> -std=3Dgnu99 with -pedantic.
>>=20
>> Work around missing keyword by moving these PMDs to a stricter complianc=
e
>> standard without GNU extensions but properly checked by Glibc. Doing so =
is
>> supported on the DPDK side since includes have been cleaned up.
>>=20
>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>=20
> Applied to dpdk-next-net/master, thanks.
This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet!

Thanks,
Yongseok