From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4965C77B76 for ; Mon, 17 Apr 2023 15:26:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9ABC285F74; Mon, 17 Apr 2023 17:26:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="skpvzReu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7A43085FA0; Mon, 17 Apr 2023 17:26:24 +0200 (CEST) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 49C1885F38 for ; Mon, 17 Apr 2023 17:26:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clamor95@gmail.com Received: by mail-ej1-x635.google.com with SMTP id dx24so21155859ejb.11 for ; Mon, 17 Apr 2023 08:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681745181; x=1684337181; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=nnAdsT28b6c6OoBV/uEZ1IFCbxyy066cGal/jnPxRNk=; b=skpvzReuhWk6SHP7jeDtI0inQK5NyHqDDZAd2cwv2s5oyTqcvlAFqIwchby91/UHFk 6ARwD1ksg4JMZ+T4+oK2XWhaX1XuuJsG4Kb09ajO9TTZ8Y6p7dGiZWoFRjFT0AqxSI9s T7SHYJ41ksmonIq+IKReY+GJo5g9U0qxJIogD6OY37QtCwBA96uTI0394mLUCQyL+L0z +cKLCFrLnU3B7Gv+mflfVmI4Rv8eeEPcCYHXZ4P3zfmT7lpmbSpociQmngcHs8B9SSl9 AuCSX3cQBZVHNVuHifkmAB8CS+2vZagy1Zkr8YilN+TwsesK6bWAu5fd5KGCibdNwQMA WBwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681745181; x=1684337181; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nnAdsT28b6c6OoBV/uEZ1IFCbxyy066cGal/jnPxRNk=; b=XWZVGEC9GnaBk5zJqneedpX3xE18gtaAV/4q+rYu/m+QtX0+m4ZzRwsJ4RXCGwNLea 8IWeQ6fIN4ynCe6dmk0EOgUGVeBi+K1wNEc2E+KekpZYZvU+okXT0NS0l18Hw1NEH7KK rQ7KOtSXkqdRLMbLWT8pfcrf19GmvVdrQGQpn1bV+1b+u3xEe3zqlknzNDUNe+uaNhOW 06UXFoIDOu9MD8oKf4NzgcIRpGXSQDrRjmxZRdCzXsxHdr8ymP1gITsnCqL6FMZqGtTR +52c8JA0exRM7WiUgQwpkSyP62Asy87QgmMGO6+ARxzC9zgV8HfWHRi+kj5RJtpQtIl/ aYmw== X-Gm-Message-State: AAQBX9e6MEK5TkMD9DmJBDCpwN9FG7JG8mxltI3kStmixD44nqj7hwbp v6fUnt22P7si8GH4rBE7FAs= X-Google-Smtp-Source: AKy350aLdvBrRlzehcnqsnqGQkaLs3gjY7QasIQUZPyo/xQRik7FWd0lGq46+xcKM9azUXYqndvvOw== X-Received: by 2002:a17:906:70d1:b0:94e:e859:8721 with SMTP id g17-20020a17090670d100b0094ee8598721mr9311277ejk.22.1681745180677; Mon, 17 Apr 2023 08:26:20 -0700 (PDT) Received: from [127.0.0.1] ([91.204.85.69]) by smtp.gmail.com with ESMTPSA id y14-20020a1709064b0e00b0094e60ac9678sm6664805eju.122.2023.04.17.08.26.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 08:26:20 -0700 (PDT) Date: Mon, 17 Apr 2023 18:26:18 +0300 From: Svyatoslav Ryhel To: Tom Warren CC: =?ISO-8859-1?Q?Jonas_Schw=F6bel?= , "u-boot@lists.denx.de" Subject: RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support User-Agent: K-9 Mail for Android In-Reply-To: References: <20230412194947.11578-1-clamor95@gmail.com> Message-ID: <1CA3C36C-FB3E-4F7D-8154-D6FA819BA798@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Only last commit (actual Nexus 7 bring up) is=20 specific to Nexus 7, 3 commits before it are common for all devices in interest=2E I assume they all can be set in one patchset=2E Though, I have some concerns about if I am able to get perfect timing of merge=2E You see, HTC One X and LG P895/P880 require some additional drivers for their panels=2E I was thinking about getting all these devices into state ready to merge in this sequence and then hold it till I will merge panel and bridge drivers=2E U-Boot maintainers are a bit worried if there are drivers merged and none of supported devices uses it=2E Having merge-ready devices should help with passing those drivers=2E Another solution may be to merge devices as they are and just pray that there will be no defconfig re-sync which will remove all yet non existing configs (like configs for panel drivers)=2E Maybe you can advice something? About buildman=2E I am building on top of U-Boot master=2E I will look into this deeper and let you know=2E Sorry for disturbance and thank you for your help and patience=2E Best regards, Svyatoslav R=2E 17 =D0=BA=D0=B2=D1=96=D1=82=D0=BD=D1=8F 2023 =D1=80=2E 18:08:02 GMT+03:00,= Tom Warren =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0= =B2(-=D0=BB=D0=B0): >This patchset is specific to the Nexus 7, IIUC=2E If the new devices als= o fall under that umbrella, then I see no problem with adding them here=2E = But if they don't, maybe an ancillary patchset on top of this one would be = better=2E=20 > >Note that I still can't build with your latest (v3) patchset - grouper fa= ils buildman and make=2E And I don't know where you are getting the '-Pr' a= rgument w/buildman, my version doesn't support a -r option AFAICT=2E > >tom@tom-ThinkPad-T580:~/denx/uboot-tegra$ buildman tegra30 >Building current source for 6 boards (6 threads, 2 jobs per thread) > arm: + grouper_common =20 >+drivers/video/tegra=2Ec:24:30: fatal error: asm/arch/display=2Eh: No suc= h file or directory >+ #include >+ ^ >+compilation terminated=2E >+make[3]: *** [drivers/video/tegra=2Eo] Error 1 >+make[2]: *** [drivers/video] Error 2 >+make[1]: *** [drivers] Error 2 >+make: *** [sub-make] Error 2 > 5 0 1 /6 0:00:14 : beaver =20 >Completed: 6 total built, 6 newly), duration 0:01:26, rate 0=2E07 > >Tom > >-----Original Message----- >From: Svyatoslav Ryhel =20 >Sent: Sunday, April 16, 2023 4:56 AM >To: Tom Warren >Cc: Jonas Schw=C3=B6bel ; u-boot@lists=2Edenx= =2Ede >Subject: RE: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support > >External email: Use caution opening links or attachments > > >Mailing list reduction=2E > >Tom, > >May I extend this patchset with adding commits for other t20/t30 devices = bringup=2E They are all typical and look like grouper bringup=2E This shoul= d decrease quantity of separate patches sent involving your assist=2E Devic= es in interest are Asus Transformers, LG P880/P895 and Htc One X=2E > >Best regards, >Svyatoslav R=2E > >13 =D0=BA=D0=B2=D1=96=D1=82=D0=BD=D1=8F 2023 =D1=80=2E 20:13:25 GMT+03:00= , Tom Warren =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0= =B2(-=D0=BB=D0=B0): >>Svyatoslav, >> >>I tried to build w/V2 of your Nexus patches applied to TOT u-boot-tegra/= master, and I get these errors from 'buildman tegra': >> >> aarch64: + p2771-0000-000 >>+In file included from arch/arm/mach-tegra/fuse=2Ec:16:0: >>+arch/arm/include/asm/arch-tegra/clock=2Eh:42:10: fatal error:=20 >>+asm/arch/clock-tables=2Eh: No such file or directory #include >>+ ^~~~~~~~~~~~~~~~~~~~~~~~~ >>+compilation terminated=2E >>+make[2]: *** [arch/arm/mach-tegra/fuse=2Eo] Error 1 >>+make[1]: *** [arch/arm/mach-tegra] Error 2 >>+make: *** [sub-make] Error 2 >> aarch64: + p2771-0000-500 >>+In file included from arch/arm/mach-tegra/fuse=2Ec:16:0: >>+arch/arm/include/asm/arch-tegra/clock=2Eh:42:10: fatal error:=20 >>+asm/arch/clock-tables=2Eh: No such file or directory #include >>+ ^~~~~~~~~~~~~~~~~~~~~~~~~ >>+compilation terminated=2E >>+make[2]: *** [arch/arm/mach-tegra/fuse=2Eo] Error 1 >>+make[1]: *** [arch/arm/mach-tegra] Error 2 >>+make: *** [sub-make] Error 2 >> >>These are the two T186 builds, they don't have or use a clock-tables=2Eh= =2E >> >>Please test building your patchset on TOT u-boot-tegra/master _before_ p= osting=2E Use buildman (preferred) or 'make xxx_defconfig && make' for each= Tegra board (cumbersome)=2E >> >>I won't take any future patches from you unless they're marked w/'passes= buildman' or 'each Tegra board builds OK w/make', etc=2E I certainly can'= t push a PR to TomR if it fails to build=2E >> >>Tom >> >>-----Original Message----- >>From: Svyatoslav Ryhel >>Sent: Wednesday, April 12, 2023 11:05 PM >>To: Tom Warren >>Cc: Marek Vasut ; Philippe Reynes=20 >>; Marcel Ziswiler=20 >>; Fabio Estevam ; S= imon=20 >>Glass ; Jonas Schw=C3=B6bel ;=20 >>u-boot@lists=2Edenx=2Ede >>Subject: Re: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012)=20 >>support >> >>External email: Use caution opening links or attachments >> >> >>=D1=87=D1=82, 13 =D0=BA=D0=B2=D1=96=D1=82=2E 2023=E2=80=AF=D1=80=2E =D0= =BE 02:07 Tom Warren =D0=BF=D0=B8=D1=88=D0=B5: >>> >>> Svyatoslav, >>> >>> This series (patches 3 & 4, in particular) fails when applied to u-boo= t-tegra/master TOT=2E Error snippet is below (from make p2771-0000-500_defc= onfig && make): >>> >>> CC arch/arm/mach-tegra/fuse=2Eo >>> arch/arm/mach-tegra/fuse=2Ec:14:10: fatal error: asm/arch/clock=2Eh: N= o=20 >>> such file or directory #include >>> ^~~~~~~~~~~~~~~~~~ >>> compilation terminated=2E >>> scripts/Makefile=2Ebuild:256: recipe for target=20 >>> 'arch/arm/mach-tegra/fuse=2Eo' failed >>> make[1]: *** [arch/arm/mach-tegra/fuse=2Eo] Error 1 >>> Makefile:1845: recipe for target 'arch/arm/mach-tegra' failed >>> make: *** [arch/arm/mach-tegra] Error 2 >> >>Hello Tom=2E >> >>Thanks for your check=2E Issue was caused by non exposed headers for T18= 6=2E >>I have fixed that in v2, I hope buildman will pass=2E Additionally I hav= e modified grouper defconfig in such a way that it should pass even without= device fragment=2E >> >>Best regards, >>Svyatoslav R=2E >> >>> >>> buildman/tegra also fails for that board, and 2 others=2E Removing th= ose two patches (3 & 4 in your Nexus7 patchset) gets make & buildman workin= g again=2E >>> Buildman/tegra worked fine on the base u-boot-tegra/master repo (befor= e I applied your patchset w/git am)=2E >>> >>> PTAL, >>> >>> Tom >>> >>> -----Original Message----- >>> From: Svyatoslav Ryhel >>> Sent: Wednesday, April 12, 2023 12:50 PM >>> To: Tom Warren ; Svyatoslav Ryhel=20 >>> ; Marek Vasut ; Philippe Reynes= =20 >>> ; Marcel Ziswiler=20 >>> ; Fabio Estevam ;= =20 >>> Simon Glass ; Jonas Schw=C3=B6bel=20 >>> >>> Cc: u-boot@lists=2Edenx=2Ede >>> Subject: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support >>> >>> External email: Use caution opening links or attachments >>> >>> >>> This patchset adds support for native use of U-Boot on ASUS/Google Nex= us 7 (2012), aka grouper/tilapia as a replacement of vendor bootloader=2E A= longside device bringup tegra requires few small patches: >>> - add gpio keyboard as stdin device >>> - make networking boot options optional >>> - add a small tool to generate SoC UID >>> >>> Jonas Schw=C3=B6bel (1): >>> configs: tegra-common-post: make PXE and DHCP boot targets optional >>> >>> Svyatoslav Ryhel (3): >>> configs: tegra-common-post: add GPIO keyboard as STDIN device >>> ARM: tegra: add SoC UID calculation function >>> board: asus: grouper: add Google Nexus 7 (2012) support >>> >>> arch/arm/dts/Makefile | 3 + >>> arch/arm/dts/tegra30-asus-grouper-common=2Edtsi | 125 ++++++ =2E=2E= =2E/dts/tegra30-asus-nexus7-grouper-E1565=2Edts | 40 ++ =2E=2E=2E/dts/teg= ra30-asus-nexus7-grouper-PM269=2Edts | 65 ++++ =2E=2E=2E/dts/tegra30-asus= -nexus7-tilapia-E1565=2Edts | 40 ++ >>> arch/arm/include/asm/arch-tegra/fuse=2Eh | 7 + >>> arch/arm/mach-tegra/Makefile | 2 +- >>> arch/arm/mach-tegra/fuse=2Ec | 151 ++++++++ >>> arch/arm/mach-tegra/tegra30/Kconfig | 5 + >>> board/asus/grouper/Kconfig | 20 + >>> board/asus/grouper/MAINTAINERS | 6 + >>> board/asus/grouper/Makefile | 14 + >>> board/asus/grouper/grouper-spl-max=2Ec | 46 +++ >>> board/asus/grouper/grouper-spl-ti=2Ec | 42 ++ >>> board/asus/grouper/grouper=2Ec | 209 ++++++++++ >>> board/asus/grouper/pinmux-config-grouper=2Eh | 362 +++++++++++++++= +++ >>> configs/grouper_E1565=2Econfig | 2 + >>> configs/grouper_PM269=2Econfig | 2 + >>> configs/grouper_common_defconfig | 85 ++++ >>> configs/tilapia=2Econfig | 3 + >>> include/configs/grouper=2Eh | 68 ++++ >>> include/configs/tegra-common-post=2Eh | 28 +- >>> 22 files changed, 1319 insertions(+), 6 deletions(-) create mode >>> 100644 arch/arm/dts/tegra30-asus-grouper-common=2Edtsi >>> create mode 100644=20 >>> arch/arm/dts/tegra30-asus-nexus7-grouper-E1565=2Edts >>> create mode 100644=20 >>> arch/arm/dts/tegra30-asus-nexus7-grouper-PM269=2Edts >>> create mode 100644=20 >>> arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565=2Edts >>> create mode 100644 arch/arm/mach-tegra/fuse=2Ec create mode 100644= =20 >>> board/asus/grouper/Kconfig create mode 100644=20 >>> board/asus/grouper/MAINTAINERS create mode 100644=20 >>> board/asus/grouper/Makefile create mode 100644=20 >>> board/asus/grouper/grouper-spl-max=2Ec >>> create mode 100644 board/asus/grouper/grouper-spl-ti=2Ec >>> create mode 100644 board/asus/grouper/grouper=2Ec create mode 100644= =20 >>> board/asus/grouper/pinmux-config-grouper=2Eh >>> create mode 100644 configs/grouper_E1565=2Econfig create mode 100644= =20 >>> configs/grouper_PM269=2Econfig create mode 100644=20 >>> configs/grouper_common_defconfig create mode 100644=20 >>> configs/tilapia=2Econfig create mode 100644 include/configs/grouper= =2Eh >>> >>> -- >>> 2=2E37=2E2 >>>