From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from hermes.aosc.io ([199.195.250.187]:40243 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbeFYHwe (ORCPT ); Mon, 25 Jun 2018 03:52:34 -0400 Date: Mon, 25 Jun 2018 15:47:18 +0800 In-Reply-To: <5B309D37.80207@broadcom.com> References: <20180315162510.11669-1-harald@ccbib.org> <20180315162510.11669-6-harald@ccbib.org> <5B309D37.80207@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop To: Arend van Spriel , Harald Geyer CC: Maxime Ripard , Chen-Yu Tsai , Kalle Valo , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Przywara , info@olimex.com, linux-wireless@vger.kernel.org From: Icenowy Zheng Message-ID: <1CF519CD-D44E-4959-8951-27CE710E0984@aosc.io> (sfid-20180625_095337_033572_E516851F) Sender: linux-wireless-owner@vger.kernel.org List-ID: 于 2018年6月25日 GMT+08:00 下午3:43:51, Arend van Spriel 写到: >On 6/24/2018 6:34 PM, Harald Geyer wrote: >> Icenowy Zheng writes: >>> >在 2018-03-15四的 16:25 +0000，Harald Geyer写道： >>>> > >+&mmc1 { >>>> > >+ pinctrl-names = "default"; >>>> > >+ pinctrl-0 = <&mmc1_pins>; >>>> > >+ vmmc-supply = <®_aldo2>; >>>> > >+ vqmmc-supply = <®_dldo4>; >>>> > >+ mmc-pwrseq = <&wifi_pwrseq>; >>>> > >+ bus-width = <4>; >>>> > >+ non-removable; >>>> > >+ status = "okay"; >>>> > >+ >>>> > >+ rtl8723bs: wifi@1 { >>>> > >+ reg = <1>; >>>> > >+ interrupt-parent = <&r_pio>; >>>> > >+ interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */ >>>> > >+ interrupt-names = "host-wake"; >>>> > >+ }; > >[...] > >>> >- This device node has no binding. The "host-wake" interrupt is >part of >>> > Broadcom SDIO Wi-Fi binding, rather than a generic one. >> I think the general mmc and interrupts bindings apply. And the mmc >binding >> clearly states that for sub-nodes a compatible string is optional. >> >> However I just realized that the 'interrupt-names' property is not >part >> of the general interrupts binding, so I guess at least this property >should >> be removed. > >Indeed. If the device just used the SDIO interrupt this is not needed. >The Broadcom device can use either SDIO interrupt or a so-called >out-of-band host-wake interrupt, which is what the above represents. RTL8....S is also capable of use OOB interrupt. > >Regards, >Arend From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.io (Icenowy Zheng) Date: Mon, 25 Jun 2018 15:47:18 +0800 Subject: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop In-Reply-To: <5B309D37.80207@broadcom.com> References: <20180315162510.11669-1-harald@ccbib.org> <20180315162510.11669-6-harald@ccbib.org> <5B309D37.80207@broadcom.com> Message-ID: <1CF519CD-D44E-4959-8951-27CE710E0984@aosc.io> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2018?6?25? GMT+08:00 ??3:43:51, Arend van Spriel ??: >On 6/24/2018 6:34 PM, Harald Geyer wrote: >> Icenowy Zheng writes: >>> >? 2018-03-15?? 16:25 +0000?Harald Geyer??? >>>> > >+&mmc1 { >>>> > >+ pinctrl-names = "default"; >>>> > >+ pinctrl-0 = <&mmc1_pins>; >>>> > >+ vmmc-supply = <®_aldo2>; >>>> > >+ vqmmc-supply = <®_dldo4>; >>>> > >+ mmc-pwrseq = <&wifi_pwrseq>; >>>> > >+ bus-width = <4>; >>>> > >+ non-removable; >>>> > >+ status = "okay"; >>>> > >+ >>>> > >+ rtl8723bs: wifi at 1 { >>>> > >+ reg = <1>; >>>> > >+ interrupt-parent = <&r_pio>; >>>> > >+ interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */ >>>> > >+ interrupt-names = "host-wake"; >>>> > >+ }; > >[...] > >>> >- This device node has no binding. The "host-wake" interrupt is >part of >>> > Broadcom SDIO Wi-Fi binding, rather than a generic one. >> I think the general mmc and interrupts bindings apply. And the mmc >binding >> clearly states that for sub-nodes a compatible string is optional. >> >> However I just realized that the 'interrupt-names' property is not >part >> of the general interrupts binding, so I guess at least this property >should >> be removed. > >Indeed. If the device just used the SDIO interrupt this is not needed. >The Broadcom device can use either SDIO interrupt or a so-called >out-of-band host-wake interrupt, which is what the above represents. RTL8....S is also capable of use OOB interrupt. > >Regards, >Arend