From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: Christoph Hellwig , Jens Axboe CC: Linus Torvalds , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mike Snitzer Subject: RE: [GIT PULL] Block pull request for- 4.11-rc1 Date: Mon, 20 Feb 2017 16:16:57 +0000 Message-ID: <1D08B61A9CF0974AA09887BE32D889DA0A8CBD@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> References: <1D08B61A9CF0974AA09887BE32D889DA0A74F3@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> <633d226d-cec3-a01f-a069-ffff307e9715@kernel.dk>,<20170220073539.GA17687@lst.de> In-Reply-To: <20170220073539.GA17687@lst.de> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Return-Path: Bart.VanAssche@sandisk.com List-ID: On 02/19/2017 11:35 PM, Christoph Hellwig wrote:=0A= > On Sun, Feb 19, 2017 at 06:15:41PM -0700, Jens Axboe wrote:=0A= >> That said, we will look into this again, of course. Christoph, any idea?= =0A= > =0A= > No idea really - this seems so far away from the code touched, and there= =0A= > are no obvious signs for a memory scamble from another object touched=0A= > that I think if it really bisects down to that issue it must be a timing= =0A= > issue.=0A= > =0A= > But reading Bart's message again: Did you actually bisect it down=0A= > to the is commit? Or just test the whole tree? Between the 4.10-rc5=0A= > merge and all the block tree there might a few more likely suspects=0A= > like the scsi bdi lifetime fixes that James mentioned.=0A= =0A= Hello Christoph,=0A= =0A= As far as I know Jens does not rebase his trees so we can use the commit=0A= date to check which patch went in when. From the first of Jan's bdi patches= :=0A= =0A= CommitDate: Thu Feb 2 08:18:41 2017 -0700=0A= =0A= So the bdi patches went in several days after I reported the general protec= tion=0A= fault issue.=0A= =0A= In an e-mail of January 30th I wrote the following: "Running the srp-test= =0A= software against kernel 4.9.6 and kernel 4.10-rc5 went fine. With your=0A= for-4.11/block branch (commit 400f73b23f457a) however I just ran into=0A= the following warning: [ ... ]" That means that I did not hit the crash wit= h=0A= Jens' for-4.11/block branch but only with the for-next branch. The patches= =0A= on Jens' for-next branch after that commit that were applied before I ran= =0A= my test are:=0A= =0A= $ PAGER=3D git log --format=3Doneline 400f73b23f457a..fb045ca25cc7 block dr= ivers/md/dm{,-mpath,-table}.[ch]=0A= fb045ca25cc7b6d46368ab8221774489c2a81648 block: don't assign cmd_flags in _= _blk_rq_prep_clone=0A= 82ed4db499b8598f16f8871261bff088d6b0597f block: split scsi_request out of s= truct request=0A= 8ae94eb65be9425af4d57a4f4cfebfdf03081e93 block/bsg: move queue creation int= o bsg_setup_queue=0A= eb8db831be80692bf4bda3dfc55001daf64ec299 dm: always defer request allocatio= n to the owner of the request_queue=0A= 6d247d7f71d1fa4b66a5f4da7b1daa21510d529b block: allow specifying size for e= xtra command data=0A= 5ea708d15a928f7a479987704203616d3274c03b block: simplify blk_init_allocated= _queue=0A= e6f7f93d58de74700f83dd0547dd4306248a093d block: fix elevator init check=0A= f924ba70c1b12706c6679d793202e8f4c125f7ae Merge branch 'for-4.11/block' into= for-4.11/rq-refactor=0A= 88a7503376f4f3bf303c809d1a389739e1205614 blk-mq: Remove unused variable=0A= bef13315e990fd3d3fb4c39013aefd53f06c3657 block: don't try to discard from _= _blkdev_issue_zeroout=0A= f99e86485cc32cd16e5cc97f9bb0474f28608d84 block: Rename blk_queue_zone_size = and bdev_zone_size=0A= =0A= Do you see any patch in the above list that does not belong to the "split= =0A= scsi passthrough fields out of struct request" series and that could have= =0A= caused the reported behavior change?=0A= =0A= Thanks,=0A= =0A= Bart.= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754095AbdBTQRO (ORCPT ); Mon, 20 Feb 2017 11:17:14 -0500 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:63641 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753473AbdBTQRK (ORCPT ); Mon, 20 Feb 2017 11:17:10 -0500 X-IronPort-AV: E=Sophos;i="5.35,187,1483977600"; d="scan'208";a="86590843" Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-99bff7000000c960-99-58ab167b47d2 From: Bart Van Assche To: Christoph Hellwig , Jens Axboe CC: Linus Torvalds , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mike Snitzer Subject: RE: [GIT PULL] Block pull request for- 4.11-rc1 Thread-Topic: [GIT PULL] Block pull request for- 4.11-rc1 Thread-Index: AQHSi0v1hcPv+gzWWEGADDvx4aYRXKFyC0ej Date: Mon, 20 Feb 2017 16:16:57 +0000 Message-ID: <1D08B61A9CF0974AA09887BE32D889DA0A8CBD@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> References: <1D08B61A9CF0974AA09887BE32D889DA0A74F3@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> <633d226d-cec3-a01f-a069-ffff307e9715@kernel.dk>,<20170220073539.GA17687@lst.de> In-Reply-To: <20170220073539.GA17687@lst.de> Accept-Language: nl-NL, en-US Content-Language: nl-NL X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsWyRobxn26d2OoIg451Mhar7/azWaxcfZTJ Yu8tbYvLu+awWbRt/Mpo8ajvLbsDm8fls6UeJ2b8ZvHYfbOBzeP9vqtsHp83yQWwRnHZpKTm ZJalFunbJXBlzNhxh62gXaLi99InbA2M00W6GDk5JARMJLY+7WTrYuTiEBJYwiSx4dpVRgjn EqPEpJnH2UGq2ASMJGZP2MMCYosIOEjM3rAUrINZ4DqjxJGND8GKhAUsJPp3gyRAiiwlNs29 xwhhG0nsO9PBCmKzCKhKTLlzhrmLkYODVyBWYukRc5CwkMBjRomT3TwgNqeAjsTD94fBShgF ZCVaXnODhJkFxCU+9KxigzhaQGLJnvPMELaoxMvH/1ghbAWJzyv+sUHU60gs2P0JytaWWLbw NVg9r4CgxMmZT1gmMIrOQjJ2FpKWWUhaZiFpWcDIsopRrDgxuTg3PbXA0ESvODEvJbM4Wy85 P3cTIzjSFI13MP7b4H6IUYCDUYmHN+Hbqggh1sSy4srcQ4wSHMxKIryCfKsjhHhTEiurUovy 44tKc1KLDzFKc7AoifPGzJ4aISSQnliSmp2aWpBaBJNl4uCUamDMk1X9km5RNvPwKpFGnWK5 uB82wUK3NvDpNV1htq45vWxZ1oeXokfzZ8y7+aWzew/LrqRbmxvMlWtFvrHz6UgpOeR8Xyp1 8NMkhclHjJZen3mm52FT3Oonc3d/OzFpb+xVEdnjrvI3fL7I7T/Ovjes0uaJ+GfG6aJzDF+o draqF02K/TaZ4cgWJZbijERDLeai4kQA1YdkTrACAAA= X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(7916002)(39860400002)(39840400002)(39850400002)(39450400003)(39410400002)(2980300002)(438002)(24454002)(199003)(377454003)(189002)(86362001)(4326007)(2906002)(33656002)(53546006)(92566002)(8746002)(53936002)(50466002)(68736007)(81166006)(81156014)(8676002)(93886004)(189998001)(7736002)(356003)(54906002)(305945005)(55016002)(229853002)(5660300001)(50986999)(55846006)(7696004)(3846002)(54356999)(76176999)(2950100002)(102836003)(6116002)(97736004)(47776003)(97756001)(23726003)(2920100001)(2270400002)(2900100001)(106466001)(38730400002)(626004)(46406003)(8936002)(6246003)(106116001)(69596002)(7099028);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR0401MB0978;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3NAM04FT018;1:Z6DdwDZjxI7gh9gY5sCcHoza/epjzt/3PmsDUC9yLSNwqL7x6/kleBzcVksKapGWKEuD0iVlkQWCJav9iXax2snl+YzYSrpX9NAcgqYef/cSujeVTlvURBktrcjJ5T9EQgEh6UeKn1lr0rBMtm4U631YWGqaEDenCBTNonSUc20lCsT+zLMFfucXGXTKPcy8KczIYjum7uqJtfwcpb2ZKFK48CB4b/XxvFRRZh/Vw6jxWYDbLxMpvIK+Z07Zg6ax33sb6PodyKdnhTeL7ELgNCAWpblO8Bd1PZrRUzqmNSBcbSBr/dgP8flFQTzvK4Jcioo739EZEkkOjiGFq4CDY5Dai5Zvkxxu9fXf20ppZXG2AQM63JjvUxCUOu8kjpxDk1+9v2XeFveJOhmWlz7RbQmbAFYwCvKLY2E3BTGTF5VB7zrFzGdsuaACg0yxIuzzcMswLjLi0EERyftufjTHgVTtOVC5GBvDei/tzbsZuZz6n5liSn1c65+2LCfQI2D86so0oRPhZwNsUaG5ickH/SPwCRyWRoHxHP+2BdSo3fEkl9q1WOj3lE+H5amy/Qvo X-MS-Office365-Filtering-Correlation-Id: 372e9c5c-2bee-485c-a048-08d459abe8ab X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BN1PR0401MB0978; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0401MB0978;3:zT8VadcOdKjOWcOgtvCm7a+j+sqyYMlL6Y4INTC41I8PeIh+ab9OSEv/D/HuCVDj9F35sJAgoA5gmr70/pAyU+52HyeqcW/EdxI6Bn15jKo2jfw8rbfrMBQf5xa0gfYHHsHvbM8Ljf4cm2wGROWt/AQr22z7T8FPKsfMucCInWq0d/uRNBqm7DNBK5uD3PJqvzkpAbe/l2Lr+CWogFd7OeajUpTvzEOZ7cdvqI//9ZWZpC6JO0FI2zcW+aMiBwFNsoME+gsaDKKxeDoEzVQBrw7H6y8aLNVf/y8EnmOCHqobGZRF4D9foneoQTwzTji52WMYtzVmxdx4SUt86EktbjKZPflkLLBdPRDSanmUUNCaV7EYD1AuaHE9AyjGyiZg1o4BXubBdSpvlDy7lQSM7w==;25:toCNN4SWodS0WtwpQoDw5zTwwYUxF3YM6wCMlV50d0DlLlKD5TzvDE6Z8rULEFZUZ8XSUtO8undAEeffXeLjVrHk0/OXeBLsEdgGBOyR8nFDs/490h3MKlh5EJB6CjMCGHdPD0GZYCFQFR3FS8kzgR1dzrJIodxw/CN1W75JIkU5Fnfqu+cUw+0Eh0PqPJwxX4vU/vWb8XP1Onx9D2mIW5eBmwLoaZDPxeMgsrhKQZrFSQiyOPCUOaT8BTxLi9wWuERw7xY39WmZ9rGLF1Vq9tBosD4GOczB1kQDS9N63QJGWXee1LT/Ie6CyuJRdB8JrToQE7wnCKqtTBBkpFFKO/osuQFNydbrZmAL7uPT3Qid1CpS0V2s09fBAWZgV5EwPx08HT050/Y6dn3HpDeQS+/xsTfUopoKq14EWPUOFYtN9ipOoMmlGfVNwXAVRHMEquCCkfpkYqgg31vlaOT32Q== X-Microsoft-Exchange-Diagnostics: 1;BN1PR0401MB0978;31:T7RWR5YETjCw/P0ZLJalZ4iIQ+6TWSqfTg7rw5dszezscqd8ycyiM4IIuHuFAJq/A+eDZ2nFPQnjcetrmHOjn9rN2cfmvlC4uxLRyEv7kSAhWAfRkwdTAH3YKOEw2c9Y77U2CbeVH5KtePeOOvnRrLfmc68G6UNUfyxHQ5D3HHBfxfP0AFDuBnjyooIcyE7Az6QKRD5jRHDh8QxP8BAmFoxJXvuxPEm4H3TClrplPFNnl0w9c+40e/gIdqnQ4kR7SFgUy7uSR4TWyhbr3SALuw==;20:q+cZuKSfZ7KOLBq01XlMzS4iAzZqXbBnkTdLn2WDhGYWMW0UKNCXgNUIAZvzvXBuV23YqAM1RASKDt3eED2kD7IO+l7QYgVONhPqAIeW3DVkzvJ8QQzEzTY6HSWhhqE9DHivLR1cWIIr+eM9Y6MJANwNI2nb+2sd+UF3EDggx9Jqd3swgmxs9S5RE0Wm4pTK7Q8TIIkvMAask3UfPzfg1jT6dEYjoOM0fAIc2z1gA8iXKzxPUTUtPKsX26P8uHU9RdrxnRpAeWXF47B94ef1px/wdY4TyQdT/Wbj5O19fSXbBVk3Bc93EQLcLmdUp9BJYccmIhTSjfexERpMJQxDliZaxLr6KhsLgcf5qVo6M+qUYr/lQMs56PZtd4xWlCa3D+4oBUgJYV/bEZC+qLSoukdGMN4eN8tRXcG2kR3mPGHy4KQ4dPLlPX6z7KCgM/56bvas0DO3SJicaZowr+A0pT76/JiG2qFiY+pLT6FgwGewqwqIQeIAZp0SqCA79o+1 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13017025)(13023025)(13024025)(13018025)(13015025)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(20161123558025)(6072148);SRVR:BN1PR0401MB0978;BCL:0;PCL:0;RULEID:;SRVR:BN1PR0401MB0978; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0401MB0978;4:S3OZbpSb83guoHz/lnQ36E77ZTu/CM/Atx+Ym27Gf5bQYn8RhPjsP50gZnUSKZk2jSaDuQKXs1fRTK2AAQu8mZWQL3eqhDBjU0LrOb3/WhXEwinuJmEYdmcYJFR1OLGHimdo6hUSPPef9LGoiUWgopPrmb3MZkJaPbqK/eHyEIbyVpDctzw7KmtDM81f3X3hF/sLUNZT6LedbQB/EKeacqVCc0I1oJgxLqKMVzeFn+Ee0Wwv6V1J4bHBBFLXPCCdHUSDtlJ0BYhVNcnJ8vQ0yatNFxcl40TmmiFtQ+l2RK4gUCVxLA0NQU66aXWK2Rrq6lf3O7ymJt54SJuu4PSQRb/T3g1wFZn7co/KVZ8K/iylUaJXUd77ea0S3osg9TycWuGxibUdQYDkbkUXKv0QC5PGpyY72xXK4+ugJJ73sVGaKQgMxi9FAWJ3Zg4SeEja/TPYnNKbpSqUQOSB2Ec766S/pf7iYOFFTb6r1wyagu85I8xDDCrD/UqG/niTZLpPTqlwM2j8F9EqVmpjwS71IETphZZrRHNfKk1RQA/wXUFhK4d2RTQrtt7ZO8Zndi67S3WHS2tMQZ2UX7hkJ94zogZwjYlQcsp7QkYGhTzlZTf7DMG8gBOQGBP7lZfOKRSfpueXm+wdUJFL3QY9xdB7c/diZPpHkpzpvV4OE2Bxd/SQYktnHbQnQrpACBW9yitkWsLMWKteTu9/+H7II4eh7A== X-Forefront-PRVS: 02243C58C6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR0401MB0978;23:ISIqNf71OAUqj3eW9XLt00dUdXqMpZkzkAgDByp?= =?us-ascii?Q?/r7MqXciv7ANN3YXheWLyAEbCu86YsTFsjz8AklPPXD1mmSsu5xDHPY6UriB?= =?us-ascii?Q?mV0E7msd5TJofwKLEHBwTVKQicvL5Gy+P7/fg+nBqFzv9f3J0RzlDKJkzlAB?= =?us-ascii?Q?sGpDX6PAkzaSt8vypcQWgGGW7Fvh4I/yiI8c/mS1YtEJmMaGCHqa5PcLukMw?= =?us-ascii?Q?L1kezKCSyrev9h8tUdozT2Yi04wCMwsWz/cIhG39wFb8p8LEGkyBOo8nUJLj?= =?us-ascii?Q?2o38jwFIDzcVtF4tWHXTjHQjvqG6FDzqXzuca3rXOMtnphtBgo+4CVvq70Ax?= =?us-ascii?Q?2YO3C5KEUrPiPdH2FvTTDrkuKLyuVrIcAw/k8M9PaMbkD3hpVnudUT4SZHHO?= =?us-ascii?Q?ieGv+OR28p3lroRmebQszjK5m017Gh/G7kck1hkWDFUGC+bVEeqqP1iQExnF?= =?us-ascii?Q?nxG0UXIZNXcFqQq4SCkbsA5Rg/iyZiUWZa7UeSp3OmBk/WqI9OxR5iyu800x?= =?us-ascii?Q?w/aJRMF/B3+ef+2oq21OCuPWn6RC/DGbOa+KwCDg1hQGc6YtA/bwdQhWXB07?= =?us-ascii?Q?4c/Q/Gd9n8aFiN2vNqHEQdeMIV/PP0dRMqvk3DU7KSBWqGiDElS5wHH3u3dq?= =?us-ascii?Q?L2MCRfoXt1P9EU0D+inOWLv2HHXtp4ys5XYsEHfHfg25KhU4OQPboKp6zhgA?= =?us-ascii?Q?Pe07cWxB/LxUI1i67oVGjJMZ9n82YHzlNdN06RMhNpkdAJ9fB+0ZtdmGr+e0?= =?us-ascii?Q?MSmjFZOEbEHpb3v/TuGd7OT5mToPltoKtjZFXrcB5/uwLj2lcvwgIFIWbY1l?= =?us-ascii?Q?yK86s9CJnRNE3tZo9zPk0fvD/PaZ/h1eQIylf6g036u/ZoCQ7fjwvHf9441i?= =?us-ascii?Q?g6s1pzUC/zttXb+Nb105an3p+LUDfey7g2mFWnJrmdbOCPZld4s9A3iuwuh+?= =?us-ascii?Q?ILmIHr5OF966jnD8zHep4PP2P4czlyLmImQrffjzj6ygGjrS2dkL9ug4VO2H?= =?us-ascii?Q?CD8zwRzdS+07sPz9DLl1Rk1nMzOxAXCx2sNiFjCVwVllKXnUwsqosVWAUMmB?= =?us-ascii?Q?xY2YMOAxm7/kbFjb3BPfOsJOREgBe6LzglZ0Pyle7OcnUQ/l0I5LAYv49ssF?= =?us-ascii?Q?XImnX6KbyOKhM9FW0ZOwac2QRrCRcfOE/rdHtRKO4oBXCVert7Avmr8THWgB?= =?us-ascii?Q?MKQWs8lAPwbARXzKyS8dFZTnXhmUP26IVDwAcctFqtkjb+GHlML8LRYncVUl?= =?us-ascii?Q?v/sM0IZ8jQ2nkfY513B5cUKaOQV54Ga82UKCs8ODaK6E8a/vtWVLgmqcvZff?= =?us-ascii?Q?JYlrbMUjKxXWr+vTDB9QUYFFOyXqAAPMOlTw+u//E+UR0Jhg0tZptusv/4rh?= =?us-ascii?Q?qXK2FFywLfh0cI8HL2Ly8YbPaQCgieLdBZMbwPItmS0zNzG6UOHsZTCU/XOL?= =?us-ascii?Q?g7YvpyD8ztA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR0401MB0978;6:LIsbn/6r/RX0IRZt9a49w0+GGVi0xuTi40gUSM+6Nt7pbQN1YRs6Udip+/EaRh0VKUEVF1Yg3UCs2laM6MhFCovGRMfrD5F+PuQM7NwDEWGjK/0sSAHDAn0W4bv6JhNDpI6QZ7g3ZIk9mr+i4egE4UJGkPRr7rVOppZQfrETMBCHYmywWidvA468CT4datLJm9ud8l1prJWLBV0EtlQH/wJ85wbyllqXaWSX37lwD37ailDf7LGV0Ezabpy/m9FzsfcV2j1HVAwru6rDwQvuB3QLUXfw/vLhbuk9tYm1Qi5a/xEUkyjT0lZI60wcbcNS5F+VsRqC944zcjANbSsyxIkkhR0Bl6xvXVvu7YxnXkts2Dqaht+YM2YaLmLEcd4Q+csKHgj2KqOsgKzeeceA9ySN8VQN/9Y9BtPAllx//bY=;5:zA29cHsrhsyImgfIgLZkw07YUXuqdOvnQWgcvi+EoQ35lBS0VGMp3Naf/rObWXeO1KJGZxrCRlA5z4msVllk8HsYcB4afHvKzAdRKMpdjmwc0XKsnNrvApFJ0JJfkdceZ2OXZr+e1a71o7Keo2q2Eg==;24:f7IxAdc6GjqAeBROyQBQCjlffv5L6MtjwwYmpDgVSVBbwcD+Eef8/z2TORnbDT0BM4TO8TVNlGG1eiXJvU8XhamWpyA7W81aIXXfy9u02KI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN1PR0401MB0978;7:4VTHp4GaWK8XjjaCsBSgYiMhLyi1+dS5Y/yEQAdEIY7f+TBsqwgzILm21XKY8qMb3a8jVUiD6VDlC2wyhsj9DD2vG5lPRkw4F0x1s3ZWpPMokY5ipzWODYiUIWqXB91bDJ2krwJVm0Xl08MucMQO4IQSKXD0kLPBSTqf51act7UlQYw9luUIbWfiI4fKOYyivDGmAcvdEQ6//W0es5hsQVw2JVIW1QvRy252yEBleK5jGXlcRiundlCwvcMErnY7/PDApjzCaXfa+WHDw/9ET/AHVRes3ytTTj2YjROEhie/T1BQpEHGedaSciNSJZHlH4QLpD+ZOhLtvSjLE0SQLQ==;20:eYWUaxGzrJm5UqrNz/X6/+AjqJU/pNX3IAE4tYZ8RDHZfYmGidDpNRFiX74fwedzHDqEBz3m92+paoikdTgFc0XQi9EhWB6Uu4jic/dwdZovtz/f1eJIVHzsWAIxIWOgW5kRC9Im1Ljt/yu0+wwNOAO3e/JM4PML/ZeJxvgHOvjpZF2+xh0t/dvHD8+V2Gkm8IIztw0fRAJA/U1Avk+KuQk9F6GPMAxcN20aQrJqH85FRk/Sj/wv07fUk2FuBLgz X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2017 16:17:03.7830 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0401MB0978 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1KGHJMM005827 On 02/19/2017 11:35 PM, Christoph Hellwig wrote: > On Sun, Feb 19, 2017 at 06:15:41PM -0700, Jens Axboe wrote: >> That said, we will look into this again, of course. Christoph, any idea? > > No idea really - this seems so far away from the code touched, and there > are no obvious signs for a memory scamble from another object touched > that I think if it really bisects down to that issue it must be a timing > issue. > > But reading Bart's message again: Did you actually bisect it down > to the is commit? Or just test the whole tree? Between the 4.10-rc5 > merge and all the block tree there might a few more likely suspects > like the scsi bdi lifetime fixes that James mentioned. Hello Christoph, As far as I know Jens does not rebase his trees so we can use the commit date to check which patch went in when. From the first of Jan's bdi patches: CommitDate: Thu Feb 2 08:18:41 2017 -0700 So the bdi patches went in several days after I reported the general protection fault issue. In an e-mail of January 30th I wrote the following: "Running the srp-test software against kernel 4.9.6 and kernel 4.10-rc5 went fine. With your for-4.11/block branch (commit 400f73b23f457a) however I just ran into the following warning: [ ... ]" That means that I did not hit the crash with Jens' for-4.11/block branch but only with the for-next branch. The patches on Jens' for-next branch after that commit that were applied before I ran my test are: $ PAGER= git log --format=oneline 400f73b23f457a..fb045ca25cc7 block drivers/md/dm{,-mpath,-table}.[ch] fb045ca25cc7b6d46368ab8221774489c2a81648 block: don't assign cmd_flags in __blk_rq_prep_clone 82ed4db499b8598f16f8871261bff088d6b0597f block: split scsi_request out of struct request 8ae94eb65be9425af4d57a4f4cfebfdf03081e93 block/bsg: move queue creation into bsg_setup_queue eb8db831be80692bf4bda3dfc55001daf64ec299 dm: always defer request allocation to the owner of the request_queue 6d247d7f71d1fa4b66a5f4da7b1daa21510d529b block: allow specifying size for extra command data 5ea708d15a928f7a479987704203616d3274c03b block: simplify blk_init_allocated_queue e6f7f93d58de74700f83dd0547dd4306248a093d block: fix elevator init check f924ba70c1b12706c6679d793202e8f4c125f7ae Merge branch 'for-4.11/block' into for-4.11/rq-refactor 88a7503376f4f3bf303c809d1a389739e1205614 blk-mq: Remove unused variable bef13315e990fd3d3fb4c39013aefd53f06c3657 block: don't try to discard from __blkdev_issue_zeroout f99e86485cc32cd16e5cc97f9bb0474f28608d84 block: Rename blk_queue_zone_size and bdev_zone_size Do you see any patch in the above list that does not belong to the "split scsi passthrough fields out of struct request" series and that could have caused the reported behavior change? Thanks, Bart.