From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.hgst.iphmx.com ([68.232.143.124]:59286 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218AbdBUTq7 (ORCPT ); Tue, 21 Feb 2017 14:46:59 -0500 From: Bart Van Assche To: "Nicholas A. Bellinger" CC: "target-devel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH v6 14/33] target: Avoid that target drivers hang if a command is aborted Date: Tue, 21 Feb 2017 18:58:44 +0000 Message-ID: <1D08B61A9CF0974AA09887BE32D889DA0AC669@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> References: <20170215002612.14566-1-bart.vanassche@sandisk.com> <20170215002612.14566-15-bart.vanassche@sandisk.com> <1487626736.19491.37.camel@haakon3.risingtidesystems.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On 02/20/2017 01:38 PM, Nicholas A. Bellinger wrote:=0A= > However, looking at transport_generic_free_cmd() in the context of=0A= > ib_srpt and ib_isert, I don't see how this scenario can ever happen in=0A= > as-is in upstream code.=0A= > =0A= > Namely, all of the transport_generic_free_cmd() callers in ib_srpt and=0A= > ib_isert pass wait_for_tasks =3D false. And the only time=0A= > transport_generic_free_cmd() will block is when wait_for_tasks =3D true,= =0A= > or when wait_for_tasks =3D true && abort =3D true.=0A= > =0A= > So as-is in upstream, how can transport_generic_free_cmd() ever block=0A= > when wait_for_tasks =3D false..?=0A= =0A= I will check the other patches in this series for changes that trigger a=0A= call to wait_for_completion() if wait_for_tasks =3D=3D false.=0A= =0A= Bart.=0A=