From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0Wtp-0007rC-Ql for qemu-devel@nongnu.org; Sat, 10 Apr 2010 05:22:45 -0400 Received: from [140.186.70.92] (port=46783 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0Wto-0007qW-9p for qemu-devel@nongnu.org; Sat, 10 Apr 2010 05:22:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0Wtm-0000hW-58 for qemu-devel@nongnu.org; Sat, 10 Apr 2010 05:22:44 -0400 Received: from cantor.suse.de ([195.135.220.2]:42655 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0Wtl-0000h7-N5 for qemu-devel@nongnu.org; Sat, 10 Apr 2010 05:22:42 -0400 Subject: Re: [Qemu-devel] [PATCH 6/6] [S390] Add firmware code Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: multipart/alternative; boundary=Apple-Mail-2-526381386 From: Alexander Graf In-Reply-To: <20100410000006.GG17204@hall.aurel32.net> Date: Sat, 10 Apr 2010 11:22:37 +0200 Message-Id: <1D45AD54-36AC-4514-8D41-8A67198975F6@suse.de> References: <1270140161-17216-1-git-send-email-agraf@suse.de> <1270140161-17216-7-git-send-email-agraf@suse.de> <20100409201718.GM21042@volta.aurel32.net> <20100410000006.GG17204@hall.aurel32.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: waldi@debian.org, Carsten Otte , qemu-devel@nongnu.org --Apple-Mail-2-526381386 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 10.04.2010, at 02:00, Aurelien Jarno wrote: > On Sat, Apr 10, 2010 at 01:29:55AM +0200, Alexander Graf wrote: >>=20 >> On 09.04.2010, at 22:17, Aurelien Jarno wrote: >>=20 >>> On Thu, Apr 01, 2010 at 06:42:41PM +0200, Alexander Graf wrote: >>>> This patch adds a firmware blob to the S390 target. The blob is a = simple >>>> implementation of a virtio client that tries to read the second = stage >>>> bootloader from sectors described as of offset 0x20 in the MBR. >>>>=20 >>>> In combination with an updated zipl this allows for booting from = virtio >>>> block devices. This firmware is built from the same sources as the = second >>>> stage bootloader. You can find the zipl patch to build both here: >>>>=20 >>>> http://alex.csgraf.de/qemu/0001-Zipl-VirtIO-bootloader-code.patch >>>=20 >>> I am not fully comfortable introducing a binary firmware based on a >>> patch posted on a website. I see two options: >>> - Get your patch merged into ZIPL, so that we can build the firmware >>> directly from the ZIPL sources >>=20 >> IBM wants to keep the copyright on the zipl sources, so this one's = out. >=20 > You can't transfer the copyright, as it is done for example for GNU > projects? I don't think so. Apart from it being illegal in Germany (you can't = transfer full copyrights) I'm not sure that'd really help. Another idea: How about I set up a git tree on repo.or.cz and put it there? That git = tree would contain all my changes, be a single public source and I'd try = to pull all 'upstream' changes back in? >>>=20 >>> Also do you really want to make the firmware mandatory? What about a >>> warning and falling back to the direct kernel boot instead (if = provided),=20 >>> as it is already now. Some other machines are doing that. >>=20 >> Yes, I do. It doesn't hurt to have it loaded and on -kernel we can = just set the PSW differently, thus making the guest jump directly into = the kernel. So the firmware is loaded and completely ignored. That's btw = what happens with this patch already. -kernel overrides the firmware. >>=20 >=20 > That means people needs to have the firmware installed even if they > don't need it. I don't see a problem there. It's less than 4k. Plus it's mandatory for = x86 and ppc too, so why make it different? Alex --Apple-Mail-2-526381386 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On = Sat, Apr 10, 2010 at 01:29:55AM +0200, Alexander Graf = wrote:

On 09.04.2010, at 22:17, Aurelien Jarno = wrote:

On Thu, Apr 01, 2010 at 06:42:41PM +0200, Alexander Graf = wrote:
This patch adds a firmware blob = to the S390 target. The blob is a = simple
implementation of a virtio client that tries to read the = second stage
bootloader from sectors described as of offset 0x20 in the = MBR.

In = combination with an updated zipl this allows for booting from = virtio
block = devices. This firmware is built from the same sources as the = second
stage = bootloader. You can find the zipl patch to build both = here:

http://alex.csgraf.de/qemu/0001-Zipl-VirtIO-bootloader-code.patch
=

I am not fully comfortable = introducing a binary firmware based on = a
patch posted on a website. I see two = options:
- Get your patch merged into = ZIPL, so that we can build the = firmware
directly from the ZIPL = sources

IBM wants to = keep the copyright on the zipl sources, so this one's = out.

You can't transfer the copyright, as it is done = for example for = GNU
projects?

I don't think = so. Apart from it being illegal in Germany (you can't transfer full = copyrights) I'm not sure that'd really = help.

Another = idea:

How about I set up a git tree on = repo.or.cz and put it there? That git tree would contain all my changes, = be a single public source and I'd try to pull all 'upstream' changes = back in?


Also do you really want to make = the firmware mandatory? What about = a
warning and falling back to the direct kernel boot instead = (if provided),
as it is already now. Some other = machines are doing that.

Yes, I do. It = doesn't hurt to have it loaded and on -kernel we can just set the PSW = differently, thus making the guest jump directly into the kernel. So the = firmware is loaded and completely ignored. That's btw what happens with = this patch already. -kernel overrides the = firmware.


That means people needs to have the = firmware installed even if they
don't need = it.

I don't see a problem = there. It's less than 4k. Plus it's mandatory for x86 and ppc too, so = why make it = different?


Alex

= --Apple-Mail-2-526381386--