From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760351AbcCEC4C (ORCPT ); Fri, 4 Mar 2016 21:56:02 -0500 Received: from mga04.intel.com ([192.55.52.120]:54657 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759765AbcCEC4A convert rfc822-to-8bit (ORCPT ); Fri, 4 Mar 2016 21:56:00 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,538,1449561600"; d="scan'208";a="758445152" From: "Drokin, Oleg" To: James Simmons CC: Greg Kroah-Hartman , "" , "Dilger, Andreas" , Linux Kernel Mailing List , Lustre Development List , Frank Zago Subject: Re: [PATCH 07/10] staging: lustre: add last missing sparse annotation __user Thread-Topic: [PATCH 07/10] staging: lustre: add last missing sparse annotation __user Thread-Index: AQHRdoQiJx1OLk4jyE230+BMMx+Ajp9KriUA Date: Sat, 5 Mar 2016 02:55:55 +0000 Message-ID: <1D5C2B0A-E454-44BD-BC8B-2D1CC6058C9D@intel.com> References: <1457143790-19422-1-git-send-email-jsimmons@infradead.org> <1457143790-19422-8-git-send-email-jsimmons@infradead.org> In-Reply-To: <1457143790-19422-8-git-send-email-jsimmons@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.31.122] Content-Type: text/plain; charset="us-ascii" Content-ID: <2A9B1651F340074D83B9F18D04DE9A1F@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 4, 2016, at 9:09 PM, James Simmons wrote: > From: Frank Zago > > One of the __user was missed in being applied to upstream > client. This is broken out of patch 11819. It was not, the bug was fixed in another way. > Signed-off-by: Frank Zago > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5396 > Reviewed-on: http://review.whamcloud.com/11819 > Reviewed-by: James Simmons > Reviewed-by: Dmitry Eremin > Reviewed-by: Oleg Drokin > --- > drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c > index a666d49..7395985 100644 > --- a/drivers/staging/lustre/lnet/lnet/api-ni.c > +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c > @@ -2041,7 +2041,7 @@ LNetCtl(unsigned int cmd, void *arg) > id.nid = data->ioc_nid; > id.pid = data->ioc_u32[0]; > rc = lnet_ping(id, data->ioc_u32[1], /* timeout */ > - data->ioc_pbuf1, > + (lnet_process_id_t __user *)data->ioc_pbuf1, We do not need this one anymore, since ioc_pbuf1 is defned as user now: drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h: void __user *ioc_pbuf1; > data->ioc_plen1 / sizeof(lnet_process_id_t)); > if (rc < 0) > return rc; > -- > 1.7.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Drokin, Oleg Date: Sat, 5 Mar 2016 02:55:55 +0000 Subject: [lustre-devel] [PATCH 07/10] staging: lustre: add last missing sparse annotation __user In-Reply-To: <1457143790-19422-8-git-send-email-jsimmons@infradead.org> References: <1457143790-19422-1-git-send-email-jsimmons@infradead.org> <1457143790-19422-8-git-send-email-jsimmons@infradead.org> Message-ID: <1D5C2B0A-E454-44BD-BC8B-2D1CC6058C9D@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: James Simmons Cc: Greg Kroah-Hartman , "" , "Dilger, Andreas" , Linux Kernel Mailing List , Lustre Development List , Frank Zago On Mar 4, 2016, at 9:09 PM, James Simmons wrote: > From: Frank Zago > > One of the __user was missed in being applied to upstream > client. This is broken out of patch 11819. It was not, the bug was fixed in another way. > Signed-off-by: Frank Zago > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5396 > Reviewed-on: http://review.whamcloud.com/11819 > Reviewed-by: James Simmons > Reviewed-by: Dmitry Eremin > Reviewed-by: Oleg Drokin > --- > drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c > index a666d49..7395985 100644 > --- a/drivers/staging/lustre/lnet/lnet/api-ni.c > +++ b/drivers/staging/lustre/lnet/lnet/api-ni.c > @@ -2041,7 +2041,7 @@ LNetCtl(unsigned int cmd, void *arg) > id.nid = data->ioc_nid; > id.pid = data->ioc_u32[0]; > rc = lnet_ping(id, data->ioc_u32[1], /* timeout */ > - data->ioc_pbuf1, > + (lnet_process_id_t __user *)data->ioc_pbuf1, We do not need this one anymore, since ioc_pbuf1 is defned as user now: drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h: void __user *ioc_pbuf1; > data->ioc_plen1 / sizeof(lnet_process_id_t)); > if (rc < 0) > return rc; > -- > 1.7.1 >