From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49753 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvGfy-0000jI-FQ
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 17:34:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <andreas.faerber@web.de>) id 1OvGfw-0001Jw-KC
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 17:34:58 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:45943)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <andreas.faerber@web.de>) id 1OvGfw-0001Jb-9n
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 17:34:56 -0400
Message-Id: <1DEB69D3-C330-4CBE-B011-5EF4B110E805@web.de>
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
In-Reply-To: <4C8DE5AE.7040402@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Apple Message framework v936)
Subject: Re: [Qemu-devel] [Bug 636315] [NEW] configure and build errors on
	Solaris 10 due to /bin/sh usage
Date: Mon, 13 Sep 2010 23:34:33 +0200
References: <20100912112636.2648.27149.malonedeb@potassium.ubuntu.com>	<AANLkTikXUO1Km9efavk5r_yX4h=uBu-o1Yy=Y5ubzFzF@mail.gmail.com>	<1C12421B-DC91-471B-A285-7501CA61CE3E@web.de>	<AANLkTimyhrj9NG0vPTJv9oJyUN+UBdyos6wBDR9Mcss_@mail.gmail.com>	<577C53A8-9AA7-4D71-98EF-A75F93A4F74B@web.de>
	<AANLkTi=yRVCDiyGuYYZgVL5L6P-GO=S1-zvSyiqLnynm@mail.gmail.com>
	<4C8DE5AE.7040402@msgid.tls.msk.ru>
Sender: andreas.faerber@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Blue Swirl <blauwirbel@gmail.com>, Bug 636315 <636315@bugs.launchpad.net>, qemu-devel@nongnu.org

Am 13.09.2010 um 10:49 schrieb Michael Tokarev:

> 13.09.2010 01:05, Blue Swirl wrote:
>> On Sun, Sep 12, 2010 at 5:58 PM, Andreas F=E4rber =
<andreas.faerber@web.de=20
>> > wrote:
>>> Am 12.09.2010 um 19:47 schrieb Blue Swirl:
>>>
>>>> diff --git a/tracetool b/tracetool
>>>> index 534cc70..c7582bf 100755
>>>> --- a/tracetool
>>>> +++ b/tracetool
>>>> @@ -48,7 +48,8 @@ get_argnames()
>>>> {
>>>>   local nfields field name
>>>>   nfields=3D0
>>>> -    for field in $(get_args "$1"); do
>>>> +    args=3Dget_args "$1"
>>>> +    for field in "$args"; do
>>>
>>> This part yes. (I took the liberty of adding args to the local =20
>>> line above)
>
> Um.  Are you sure it works as expected?

No, I'm not sure. It's Dark Magic to me and happened to unbreak =20
configure; I'll try out your suggestions the next days.

Thanks,
Andreas

>  I'm not at all shure.
> There are 2 errors in the above patch:
>
> +    args=3Dget_args "$1"
>
> After this line, variable $args will contain one word: "get_args".
> Shell will try to execute a command or call a shell function which
> name is stored in $1, if it is assigned.  If it is not, at least
> bash will complain that it can't execute command "".
>
> The proper way is to add backticks:
>
> +    args=3D`get_args "$1"`
>
> In the second line:
>
> +    for field in "$args"; do
>
> the double quotes ensure that all words in $args are
> processed as single word, all at once.  So the for loop
> will be executed exactly one time, no matter how many
> arguments are given (even if there's none).
>
> So the right solution is to drop double quotes.
>
> JFYI.
>
> /mjt
>