From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liu, Jijiang" Subject: Re: [PATCH] doc: announce ABI change for struct rte_eth_tunnel_flow Date: Tue, 15 Dec 2015 01:17:55 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF0335@SHSMSX101.ccr.corp.intel.com> References: <1449639461-9718-1-git-send-email-jijiang.liu@intel.com> <2136605.pcfb1tFB10@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 30FF62716 for ; Tue, 15 Dec 2015 02:18:00 +0100 (CET) In-Reply-To: <2136605.pcfb1tFB10@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, December 14, 2015 11:04 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > rte_eth_tunnel_flow >=20 > 2015-12-09 13:37, Jijiang Liu: > > The struct 'rte_eth_tunnel_flow' is only used by struct > > 'rte_eth_fdir_flow' now, but its name is generic, and I plan to extend = new > fileds like below to support generic configuration for tunneling packet. >=20 > You have not explained what the changes are for. > So it's really difficult to have an opinion. > Please describe an use case. For i40e flow director, it can use more fields such as inner destination IP= , inner MAC outer destination MAC and outer destination IP to do classifica= tion for tunneling packet. Otherwise, we also can use this structure to store tunnel flow configuratio= n, not just for classification. > PS: "filed" -> "field"