From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Liu, Jijiang" <jijiang.liu@intel.com>
Subject: Re: [PATCH] doc: announce ABI change for struct
 rte_eth_tunnel_flow
Date: Tue, 15 Dec 2015 02:05:31 +0000
Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF0387@SHSMSX101.ccr.corp.intel.com>
References: <1449639461-9718-1-git-send-email-jijiang.liu@intel.com>
 <2136605.pcfb1tFB10@xps13>
 <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF0335@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 7137111F5
 for <dev@dpdk.org>; Tue, 15 Dec 2015 03:05:36 +0100 (CET)
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF0335@SHSMSX101.ccr.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

>=20
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Monday, December 14, 2015 11:04 PM
> > To: Liu, Jijiang
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct
> > rte_eth_tunnel_flow
> >
> > 2015-12-09 13:37, Jijiang Liu:
> > > The struct 'rte_eth_tunnel_flow' is only used by struct
> > > 'rte_eth_fdir_flow' now, but its name is generic, and I plan to
> > > extend new
> > fileds like below to support generic configuration for tunneling packet=
.
> >
> > You have not explained what the changes are for.
> > So it's really difficult to have an opinion.
> > Please describe an use case.
> For i40e flow director, it can use more fields such as inner destination =
IP,
> inner MAC outer destination MAC and outer destination IP to do
> classification for tunneling packet.
> Otherwise, we also can use this structure to store tunnel flow configurat=
ion,
> not just for classification.
>=20
> > PS: "filed" -> "field"

After aligning with Jingjing, she have already sent ABI change announcement=
 for struct 'rte_eth_fdir_flow'to extend input set of FD, refer to[1].
And change of struct 'rte_eth_tunnel_flow' I want to announce can be includ=
ed in hers, so I don't need to announce it again. Thanks.=20

[1]http://dpdk.org/ml/archives/dev/2015-November/027915.html