From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751992Ab3LLU2X (ORCPT ); Thu, 12 Dec 2013 15:28:23 -0500 Received: from li42-95.members.linode.com ([209.123.162.95]:40087 "EHLO li42-95.members.linode.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841Ab3LLU2W convert rfc822-to-8bit (ORCPT ); Thu, 12 Dec 2013 15:28:22 -0500 Subject: Re: [PATCH 2/3] OF: Add a allnodes pointer back to the tree Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Pantelis Antoniou In-Reply-To: <20131212112047.87B5BC40637@trevor.secretlab.ca> Date: Thu, 12 Dec 2013 22:28:14 +0200 Cc: Rob Herring , Stephen Warren , Matt Porter , Koen Kooi , Alison Chaiken , Dinh Nguyen , Jan Lubbe , Alexander Sverdlin , Michael Stickel , Guenter Roeck , Dirk Behme , Alan Tull , Sascha Hauer , Michael Bohan , Ionut Nicu , Michal Simek , Matt Ranostay , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <1F297430-16C1-406A-B93A-C39776FE16F6@antoniou-consulting.com> References: <1386684833-24112-1-git-send-email-panto@antoniou-consulting.com > <1386684833-24112-3-git-send-email-panto@antoniou-consulting.com> <20131212112047.87B5BC40637@trevor.secretlab.ca> To: Grant Likely X-Mailer: Apple Mail (2.1085) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Grant, On Dec 12, 2013, at 1:20 PM, Grant Likely wrote: > On Tue, 10 Dec 2013 16:13:52 +0200, Pantelis Antoniou wrote: >> As it stands right now there's no way for a node to point back >> to allnodes that the top level tree tracker for now. >> >> This is problematic when using unflatten_dt_node more than once >> because is leads to the nodes to be linked incorrectly. >> >> Keep track of the root allnodes on each device_node and modify >> unflaten_dt_node to match. > > After our conversation on IRC and the decision to split unflattening the > tree from attaching it to be visible to the entire kernel, I'm going to > hold off on this patch. I suspect it will change in the process. > OK, I'm taking a look right now; should have something done on the weekend. The whole idea is splitting unflattening from attaching to the live tree. Should be straight forward enough. > . > Regards -- Pantelis From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pantelis Antoniou Subject: Re: [PATCH 2/3] OF: Add a allnodes pointer back to the tree Date: Thu, 12 Dec 2013 22:28:14 +0200 Message-ID: <1F297430-16C1-406A-B93A-C39776FE16F6@antoniou-consulting.com> References: <1386684833-24112-1-git-send-email-panto@antoniou-consulting.com > <1386684833-24112-3-git-send-email-panto@antoniou-consulting.com> <20131212112047.87B5BC40637@trevor.secretlab.ca> Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20131212112047.87B5BC40637-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Cc: Rob Herring , Stephen Warren , Matt Porter , Koen Kooi , Alison Chaiken , Dinh Nguyen , Jan Lubbe , Alexander Sverdlin , Michael Stickel , Guenter Roeck , Dirk Behme , Alan Tull , Sascha Hauer , Michael Bohan , Ionut Nicu , Michal Simek , Matt Ranostay , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Grant, On Dec 12, 2013, at 1:20 PM, Grant Likely wrote: > On Tue, 10 Dec 2013 16:13:52 +0200, Pantelis Antoniou wrote: >> As it stands right now there's no way for a node to point back >> to allnodes that the top level tree tracker for now. >> >> This is problematic when using unflatten_dt_node more than once >> because is leads to the nodes to be linked incorrectly. >> >> Keep track of the root allnodes on each device_node and modify >> unflaten_dt_node to match. > > After our conversation on IRC and the decision to split unflattening the > tree from attaching it to be visible to the entire kernel, I'm going to > hold off on this patch. I suspect it will change in the process. > OK, I'm taking a look right now; should have something done on the weekend. The whole idea is splitting unflattening from attaching to the live tree. Should be straight forward enough. > . > Regards -- Pantelis -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html