From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759706AbbKTNNL (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Nov 2015 08:13:11 -0500
Received: from mga14.intel.com ([192.55.52.115]:25677 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759590AbbKTNNJ convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Nov 2015 08:13:09 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,322,1444719600"; 
   d="scan'208";a="843366668"
From: "Tirdea, Irina" <irina.tirdea@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Bastien Nocera <hadess@hadess.net>, Aleksei Mamlin <mamlinav@gmail.com>,
        Karsten Merker <merker@debian.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Purdila, Octavian" <octavian.purdila@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v11 3/8] Input: goodix - write configuration data to
 device
Thread-Topic: [PATCH v11 3/8] Input: goodix - write configuration data to
 device
Thread-Index: AQHRIvcEsqkVVtLxj0+3hsw1udUxI56k42oQ
Date: Fri, 20 Nov 2015 13:13:03 +0000
Deferred-Delivery: Fri, 20 Nov 2015 13:12:00 +0000
Message-ID: <1F3AC3675D538145B1661F571FE1805F2F12029F@irsmsx105.ger.corp.intel.com>
References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com>
 <1447936001-21420-4-git-send-email-irina.tirdea@intel.com>
 <20151119182038.GA24773@dtor-ws>
In-Reply-To: <20151119182038.GA24773@dtor-ws>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: 19 November, 2015 20:21
> To: Tirdea, Irina
> Cc: Bastien Nocera; Aleksei Mamlin; Karsten Merker; linux-input@vger.kernel.org; Mark Rutland; Rob Herring; Purdila, Octavian; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v11 3/8] Input: goodix - write configuration data to device
> 
> On Thu, Nov 19, 2015 at 02:26:36PM +0200, Irina Tirdea wrote:
> > +	if (ts->gpiod_int && ts->gpiod_rst) {
> > +		/* update device config */
> > +		ts->cfg_name = kasprintf(GFP_KERNEL, "goodix_%d_cfg.bin",
> > +					 ts->id);
> 
> devm_kasprintf maybe (don't resubmit)?
> 

Yes, using devm_kasprintf would be better.

Thanks,
Irina

> Thanks.
> 
> --
> Dmitry