From: Christian Lindig <christian.lindig@citrix.com>
To: Edwin Torok <edvin.torok@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Pau Ruiz Safont <pau.safont@citrix.com>,
David Scott <dave@recoil.org>, Wei Liu <wl@xen.org>,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist
Date: Wed, 2 Nov 2022 09:11:16 +0000 [thread overview]
Message-ID: <1FD039A8-AE3A-4D6E-A2E9-F446FD6653DD@citrix.com> (raw)
In-Reply-To: <cover.1667324874.git.edvin.torok@citrix.com>
> On 1 Nov 2022, at 17:59, Edwin Török <edvin.torok@citrix.com> wrote:
>
>
> Edwin Török (2):
> xenctrl.ml: make domain_getinfolist tail recursive
> xenctrl: use larger chunksize in domain_getinfolist
>
> tools/ocaml/libs/xc/xenctrl.ml | 25 ++++++++++++++++++-------
> 1 file changed, 18 insertions(+), 7 deletions(-)
Acked-by: Christian Lindig <christian.lindig@citrix.com>
> It was calling the Xen domainfolist hypercall N/2 times.
> Optimize this such that it is called at most 2 times during normal use.
>
> Implement a tail recursive `rev_concat` equivalent to `concat |> rev`,
> and use it instead of calling `@` multiple times.
Are there any assurances about the order in elements returned by domain_getinfolist? I understand that the change maintains the current behaviour but are we even required to maintain that order? Because otherwise we could return the reverse list and save more work.
— C
next prev parent reply other threads:[~2022-11-02 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 17:59 [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Edwin Török
2022-11-01 17:59 ` [PATCH for-4.17 v1 1/2] xenctrl.ml: make domain_getinfolist tail recursive Edwin Török
2022-11-01 17:59 ` [PATCH for-4.17 v1 2/2] xenctrl: use larger chunksize in domain_getinfolist Edwin Török
2022-11-02 9:11 ` Christian Lindig [this message]
2022-11-02 9:31 ` [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist Edwin Torok
2022-11-02 9:37 ` Edwin Torok
2022-11-02 17:26 ` Further issues " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1FD039A8-AE3A-4D6E-A2E9-F446FD6653DD@citrix.com \
--to=christian.lindig@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=dave@recoil.org \
--cc=edvin.torok@citrix.com \
--cc=pau.safont@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.