All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: borntraeger@de.ibm.com, david@redhat.com,
	Janosch Frank <frankja@linux.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2] s390x: Properly fetch the short psw on diag308 subc 0/1
Date: Tue, 12 Nov 2019 18:05:33 +0100	[thread overview]
Message-ID: <1FDC3957-B9E3-41E0-B766-B4ACD0753EC0@redhat.com> (raw)
In-Reply-To: <20191112175827.2d7bdb15.cohuck@redhat.com>



> Am 12.11.2019 um 17:58 schrieb Cornelia Huck <cohuck@redhat.com>:
> 
> On Mon, 11 Nov 2019 10:28:08 -0500
> Janosch Frank <frankja@linux.ibm.com> wrote:
> 
>> We need to actually fetch the cpu mask and set it. As we invert the
>> short psw indication in the mask, SIE will report a specification
>> exception, if it wasn't present in the reset psw.
>> 
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> target/s390x/cpu.c | 12 ++++++++++--
>> target/s390x/cpu.h |  1 +
>> 2 files changed, 11 insertions(+), 2 deletions(-)
> 
> So, is this change -rc material, or should it go in during the next
> release? I'm a bit confused here.

IMHO, this is not urgent and can wait.
> 
> [Also, does this need a change in the tcg code, or is that something
> that should just be done eventually? Sorry, drowning a bit in mails
> here...]

We‘re missing many checks when loading/running a new PSW for TCG, not just this scenario. So this should be done at one point but is not urgent at all.



      reply	other threads:[~2019-11-12 17:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 15:28 [PATCH v2] s390x: Properly fetch the short psw on diag308 subc 0/1 Janosch Frank
2019-11-11 17:05 ` David Hildenbrand
2019-11-12  7:48 ` no-reply
2019-11-12 16:58 ` Cornelia Huck
2019-11-12 17:05   ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1FDC3957-B9E3-41E0-B766-B4ACD0753EC0@redhat.com \
    --to=david@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.