Re: [dpdk-dev] [PATCH v13 4/7] net/iavf: add iAVF IPsec inline crypto support

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/28/2021 5:04 PM, Radu Nicolau wrote:
> Add support for inline crypto for IPsec, for ESP transport and
> tunnel over IPv4 and IPv6, as well as supporting the offload for
> ESP over UDP, and inconjunction with TSO for UDP and TCP flows.
> Implement support for rte_security packet metadata
> 
> Add definition for IPsec descriptors, extend support for offload
> in data and context descriptor to support
> 
> Add support to virtual channel mailbox for IPsec Crypto request
> operations. IPsec Crypto requests receive an initial acknowledgment
> from phsyical function driver of receipt of request and then an
> asynchronous response with success/failure of request including any
> response data.
> 
> Add enhanced descriptor debugging
> 
> Refactor of scalar tx burst function to support integration of offload
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> Reviewed-by: Jingjing Wu <jingjing.wu@intel.com>

<...>

> @@ -973,6 +984,11 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>   	if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_CRC)
>   		dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_KEEP_CRC;
>   
> +	if (iavf_ipsec_crypto_supported(adapter)) {
> +		dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_SECURITY;
> +		dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_SECURITY;

Should use new macors with RTE_ prefix

<...>

> @@ -36,10 +37,10 @@
>   		RTE_ETH_TX_OFFLOAD_TCP_CKSUM)
>   
>   #define IAVF_RX_VECTOR_OFFLOAD (				 \
> -		RTE_ETH_RX_OFFLOAD_CHECKSUM |		 \
> -		RTE_ETH_RX_OFFLOAD_SCTP_CKSUM |		 \
> -		RTE_ETH_RX_OFFLOAD_VLAN |		 \
> -		RTE_ETH_RX_OFFLOAD_RSS_HASH)
> +		DEV_RX_OFFLOAD_CHECKSUM |		 \
> +		DEV_RX_OFFLOAD_SCTP_CKSUM |		 \
> +		DEV_RX_OFFLOAD_VLAN |		 \
> +		DEV_RX_OFFLOAD_RSS_HASH)

And should keep the RTE_ prefix version of the macros.

Updating both above two in next-net.