All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>, linux-block@vger.kernel.org
Cc: mgorman@suse.de, hare@suse.de
Subject: Re: elevator= kernel argument for recent kernels
Date: Wed, 6 Nov 2019 07:15:35 -0700	[thread overview]
Message-ID: <1a0539a7-75c2-1ad6-aa5c-bf07a92e1eb3@kernel.dk> (raw)
In-Reply-To: <20191106105340.GE16085@quack2.suse.cz>

On 11/6/19 3:53 AM, Jan Kara wrote:
> Hello,
> 
> with transition to blk-mq, the elevator= kernel argument was removed. I
> understand the reasons for its removal but still I think this may come as a
> surprise to some users since that argument has been there for ages and
> although distributions generally transition to setting appropriate elevator
> by udev rules, there are still people that use that argument with older
> kernels and there are quite a few advices on the Internet to use it. So
> shouldn't we at least warn loudly if someone uses elevator= argument on
> kernels that don't support it and redirect people to sysfs? Something like
> the attached patch? What do people think?

I'm fine with that, my objects have always been centered around trying
to make the parameter work. A warning makes sense to point people in
the right direction. I'll add this for 5.5.

-- 
Jens Axboe


  parent reply	other threads:[~2019-11-06 14:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 10:53 elevator= kernel argument for recent kernels Jan Kara
2019-11-06 12:55 ` Jeff Moyer
2019-11-06 14:15 ` Jens Axboe [this message]
2019-11-06 15:01   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a0539a7-75c2-1ad6-aa5c-bf07a92e1eb3@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=mgorman@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.