On 28/04/2019 04.36, Eric Blake wrote: > On 4/26/19 5:53 AM, Kevin Wolf wrote: > >>> creating large image >>> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file >>> format 'IMGFMT' >>> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000 >>> [...] >>> >>> Could this be fixed somehow, or should the test rather be skipped for >>> IMGFMT=raw? >> >> The test passes for me on XFS. Looks like the raw driver can handle >> large image files, but your host filesystem can't. >> >> We would have to check whether the host filesystem can support large >> files and skip the test if it can't. I'm not sure how to do that. But >> actually, this isn't testing anything interesting for raw, so just >> unconditionally disabling the test for raw could be reasonable enough. > > iotest 220 in commit 3b94c343 can serve as such an example (it skips the > test on at least ext4, while passing on tmpfs which allows larger sparse > files). That should do the trick, thanks. I'll send a patch. Thomas