All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Peter Delevoryas <pdel@fb.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
	"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PULL 00/14] aspeed queue
Date: Sun, 5 Sep 2021 16:43:56 +0200	[thread overview]
Message-ID: <1a14daac-2964-3b08-3346-95e4799605b3@kaod.org> (raw)
In-Reply-To: <A1FBA6CB-6D97-4EC3-A4AD-90CE687A08D7@fb.com>

On 9/5/21 4:34 PM, Peter Delevoryas wrote:
> 
> 
>> On Sep 5, 2021, at 1:51 AM, Cédric Le Goater <clg@kaod.org> wrote:
>>
>> On 9/5/21 1:03 AM, Philippe Mathieu-Daudé wrote:
>>>> On 9/4/21 7:33 AM, Cédric Le Goater wrote:
>>>> On 9/3/21 10:41 PM, Philippe Mathieu-Daudé wrote:
>>>>> Hi Peter,
>>>>>
>>>>> On 9/3/21 9:40 PM, Cédric Le Goater wrote:
>>>>>> The following changes since commit 8880cc4362fde4ecdac0b2092318893118206fcf:
>>>>>>
>>>>>>  Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 08:27:38 +0100)
>>>>>>
>>>>>> are available in the Git repository at:
>>>>>>
>>>>>>  https://github.com/legoater/qemu/ tags/pull-aspeed-20210903
>>>>>>
>>>>>> for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae:
>>>>>>
>>>>>>  hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200)
>>>>>>
>>>>>> ----------------------------------------------------------------
>>>>>> Aspeed patches :
>>>>>>
>>>>>> * MAC enablement fixes (Guenter)
>>>>>> * Watchdog  and pca9552 fixes (Andrew)
>>>>>> * GPIO fixes (Joel)
>>>>>> * AST2600A3 SoC and DPS310 models (Joel)
>>>>>> * New Fuji BMC machine (Peter)
>>>>>>
>>>>>> ----------------------------------------------------------------
>>>>>
>>>>>> Peter Delevoryas (3):
>>>>>>      hw/arm/aspeed: Initialize AST2600 UART clock selection registers
>>>>>>      hw/arm/aspeed: Allow machine to set UART default
>>>>>>      hw/arm/aspeed: Add Fuji machine type
>>>>>
>>>>> I have a pending question with the last patch, do you mind holding
>>>>> this PR until it is resolved with Cédric and the patch author please?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Phil.
>>>>>
>>>>
>>>> I guess we can drop the following from the commit log : 
>>>>
>>>>    git clone https://github.com/facebook/openbmc
>>>>    cd openbmc
>>>>    ./sync_yocto.sh
>>>>    source openbmc-init-build-env fuji build-fuji
>>>>    bitbake fuji-image
>>>>    dd if=/dev/zero of=/tmp/fuji.mtd bs=1M count=128
>>>>    dd if=./tmp/deploy/images/fuji/flash-fuji of=/tmp/fuji.mtd \
>>>>        bs=1k conv=notrunc
>>>>    
>>>>    git clone --branch aspeed-next https://github.com/peterdelevoryas/qemu
>>>>    cd qemu
>>>>    ./configure --target-list=arm-softmmu --disable-vnc
>>>>    make -j $(nproc)
>>>>    ./build/arm-softmmu/qemu-system-arm \
>>>>        -machine fuji-bmc \
>>>>        -drive file=/tmp/fuji.mtd,format=raw,if=mtd \
>>>>        -serial stdio \
>>>>        -nic user,hostfwd=::2222-:22
>>>>    sshpass -p 0penBmc ssh root@localhost -p 2222
>>>
>>> Sounds good. Eventually document that in docs/system/arm/aspeed.rst
>>> in a follow up patch?
>>>
>>> Regards,
>>>
>>> Phil.
>>>
>>
>>
>> Peter D, 
>>
>> Could you please resend the "hw/arm/aspeed: Add Fuji machine type"
>> patch addressing Phil's comment. I will resend a PR with the 
>> update.
>>
>> Thanks,
>>
>> C. 
>>
>>
> 
> Oh! Yes, I can do that, sorry, I wasn’t sure if it was necessary to resend or if it could be fixed inline or something. I’ll send that within the next 24 hrs, removing the selected text from the commit description.

I didn't either. 

Thanks, 

C.


  reply	other threads:[~2021-09-05 14:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 19:40 Cédric Le Goater
2021-09-03 19:40 ` [PULL 01/14] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb Cédric Le Goater
2021-09-03 19:40 ` [PULL 02/14] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a Cédric Le Goater
2021-09-03 19:40 ` [PULL 03/14] watchdog: aspeed: Sanitize control register values Cédric Le Goater
2021-09-03 19:40 ` [PULL 04/14] watchdog: aspeed: Fix sequential control writes Cédric Le Goater
2021-09-03 19:40 ` [PULL 05/14] hw: aspeed_gpio: Simplify 1.8V defines Cédric Le Goater
2021-09-03 19:41 ` [PULL 06/14] hw: aspeed_gpio: Clarify GPIO controller name Cédric Le Goater
2021-09-03 19:41 ` [PULL 07/14] misc/pca9552: Fix LED status register indexing in pca955x_get_led() Cédric Le Goater
2021-09-03 19:41 ` [PULL 08/14] arm/aspeed: rainier: Add i2c eeproms and muxes Cédric Le Goater
2021-09-03 19:41 ` [PULL 09/14] aspeed: Emulate the AST2600A3 Cédric Le Goater
2021-09-03 19:41 ` [PULL 10/14] hw/misc: Add Infineon DPS310 sensor model Cédric Le Goater
2021-09-03 19:41 ` [PULL 11/14] arm/aspeed: Add DPS310 to Witherspoon and Rainier Cédric Le Goater
2021-09-03 19:41 ` [PULL 12/14] hw/arm/aspeed: Initialize AST2600 UART clock selection registers Cédric Le Goater
2021-09-03 19:41 ` [PULL 13/14] hw/arm/aspeed: Allow machine to set UART default Cédric Le Goater
2021-09-03 19:41 ` [PULL 14/14] hw/arm/aspeed: Add Fuji machine type Cédric Le Goater
2021-09-03 20:39   ` Philippe Mathieu-Daudé
2021-09-03 20:41 ` [PULL 00/14] aspeed queue Philippe Mathieu-Daudé
2021-09-04  5:33   ` Cédric Le Goater
2021-09-04 23:03     ` Philippe Mathieu-Daudé
2021-09-05  8:51       ` Cédric Le Goater
2021-09-05 14:34         ` Peter Delevoryas
2021-09-05 14:43           ` Cédric Le Goater [this message]
2021-09-13 16:12 Cédric Le Goater
2021-09-14 10:51 ` Peter Maydell
2021-09-14 10:58   ` Cédric Le Goater
2021-09-14 11:38     ` Philippe Mathieu-Daudé
2021-09-20  8:09 Cédric Le Goater
2021-09-21 14:07 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a14daac-2964-3b08-3346-95e4799605b3@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=f4bug@amsat.org \
    --cc=joel@jms.id.au \
    --cc=pdel@fb.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [PULL 00/14] aspeed queue' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.