From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AEB0C432BE for ; Wed, 18 Aug 2021 20:41:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5E3F610F7 for ; Wed, 18 Aug 2021 20:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233729AbhHRUmV (ORCPT ); Wed, 18 Aug 2021 16:42:21 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:52068 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbhHRUmT (ORCPT ); Wed, 18 Aug 2021 16:42:19 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 52E6E3F044 for ; Wed, 18 Aug 2021 20:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629319303; bh=UOE20OlnZGDBI1w8hzaIpuPN6xfmK8WguChjFrKnZuU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=AMPMxxlzH93EbqKkvvLs1/DuQFC7yPashajwqCWDTb5Z9STiD2KQD41p3+feaJbPp /cavtIUhM2VD1MxPW7G9Pv9TOz0eUjj1uCFo4t/f6c0z0V4e7J1eWINFZGX4DmGZwg /V9g9bFGwUVunKivZPtwf+GOK3tvuP0OLH7ybfssKcqx9c51xRFTvCHxFn73IFxyHJ xCOGkA/NksndsMW8fZQ6Abiu+eVTqGyJJ3lttmpJQ6IDjMTDMSWp5pOczdmsfKLXsn elTPpgn1cjxoz4n6IVIyL+lyUFHLky2PUsVs/GC/3m11yuONC2thZ7mTLXMiewr1Vx WFBrpiBsD0KsA== Received: by mail-ed1-f71.google.com with SMTP id b25-20020a05640202d9b02903be7281a80cso1674146edx.3 for ; Wed, 18 Aug 2021 13:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UOE20OlnZGDBI1w8hzaIpuPN6xfmK8WguChjFrKnZuU=; b=InOUtfxyyHQjwrd6fUFLRJL5N/y4BzbEhPs5KqEP7zUnca0N4tLsITnFMxncNSz/ou AHV0FUmTJkNN5H/5hkmPGbGy99OpTGAe9MilWe3QiIplkxuPiURmwolUXEZJPcdOhvdk g/+6683Gdj/8YY6xWLpuqoZs2LjKVTDZRqyosZSMaqmh9kLuSMJtpQFX7c2VJKrQREPG fpw3ALDKDHTD2iV+SJmeGx7wFo+KAUtKnfYdiz72CE66Jtoaqj2ouIo4ToO9ViD1id+U TQ7zs0L32LLUjYUrerJQOv/jc+Dq6T+niYSB0BmLujazm0fl1evX9lA/mBQ13BvgZp1l LSHg== X-Gm-Message-State: AOAM53146KRbSIFpd06EUa9sz+9EUTp59t+f7u7qocF1D2vGXWZigXml Ooa2l7hesEUtDdgyy7wzDdY8F0bWX3qpe5divMpVlvBqT2gTsixrdvaQX4EfYISr1vOVouESY8Y o8FEohpB6qz3qpAe4wuwH55bZuNPTxMF18x97eWVt6g== X-Received: by 2002:a17:906:bc81:: with SMTP id lv1mr11590280ejb.393.1629319303109; Wed, 18 Aug 2021 13:41:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuYU3uP7y//yQFosQFGT8VE96LJF4E5eKGo52ons6ugHXq2GC+IHUQY+3g7aV0U22I95MmCg== X-Received: by 2002:a17:906:bc81:: with SMTP id lv1mr11590254ejb.393.1629319302920; Wed, 18 Aug 2021 13:41:42 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id kv4sm360228ejc.35.2021.08.18.13.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 13:41:42 -0700 (PDT) Subject: Re: [PATCH v3 00/13] MT8195 SMI support To: Yong Wu , Rob Herring , Matthias Brugger Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com, Ikjoon Jang References: <20210810080859.29511-1-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: <1a160afd-ceeb-04a3-8213-fe781ec18e30@canonical.com> Date: Wed, 18 Aug 2021 22:41:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210810080859.29511-1-yong.wu@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2021 10:08, Yong Wu wrote: > This patchset mainly adds SMI support for mt8195. > > Comparing with the previous version, add two new functions: > a) add smi sub common > b) add initial setting for smi-common and smi-larb. > > Change note: > v3:1) In the dt-binding: > a. Change mediatek,smi type from phandle-array to phandle from Rob. > b. Add a new bool property (mediatek,smi_sub_common) > to indicate if this is smi-sub-common. > 2) Change the clock using bulk parting. > keep the smi-common's has_gals flag. more strict. > 3) More comment about larb initial setting. > 4) Add a maintain patch The patchset looks good to me but I saw now comments from Rob, so I expect a resend. Therefore there is also time for additional review - maybe continued by Ikjoon Jang? If you sent a v4 with fixes rather soon and get ack from Rob, I could still try to get it into next merge window. After this weekend I won't be taking patches for this cycle and it will wait for the merge window to finish. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1438C4338F for ; Wed, 18 Aug 2021 20:42:02 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46AA8610F7 for ; Wed, 18 Aug 2021 20:42:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 46AA8610F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0C597405F7; Wed, 18 Aug 2021 20:42:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ylsZ1R4f61cv; Wed, 18 Aug 2021 20:41:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 95A99404AB; Wed, 18 Aug 2021 20:41:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5DF99C0010; Wed, 18 Aug 2021 20:41:57 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2393BC000E for ; Wed, 18 Aug 2021 20:41:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F3C9460622 for ; Wed, 18 Aug 2021 20:41:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=canonical.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gMuI4arwVJqZ for ; Wed, 18 Aug 2021 20:41:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by smtp3.osuosl.org (Postfix) with ESMTPS id EAA316060F for ; Wed, 18 Aug 2021 20:41:51 +0000 (UTC) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 56C3C3F36B for ; Wed, 18 Aug 2021 20:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629319303; bh=UOE20OlnZGDBI1w8hzaIpuPN6xfmK8WguChjFrKnZuU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=AMPMxxlzH93EbqKkvvLs1/DuQFC7yPashajwqCWDTb5Z9STiD2KQD41p3+feaJbPp /cavtIUhM2VD1MxPW7G9Pv9TOz0eUjj1uCFo4t/f6c0z0V4e7J1eWINFZGX4DmGZwg /V9g9bFGwUVunKivZPtwf+GOK3tvuP0OLH7ybfssKcqx9c51xRFTvCHxFn73IFxyHJ xCOGkA/NksndsMW8fZQ6Abiu+eVTqGyJJ3lttmpJQ6IDjMTDMSWp5pOczdmsfKLXsn elTPpgn1cjxoz4n6IVIyL+lyUFHLky2PUsVs/GC/3m11yuONC2thZ7mTLXMiewr1Vx WFBrpiBsD0KsA== Received: by mail-ed1-f70.google.com with SMTP id j15-20020aa7c40f0000b02903be5fbe68a9so1675828edq.2 for ; Wed, 18 Aug 2021 13:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UOE20OlnZGDBI1w8hzaIpuPN6xfmK8WguChjFrKnZuU=; b=H0KGIdrQYavNAywVCnxiqbpawVPFX65uf626st3HMQAnOBrksJalbmmNt4oJ5KkTEQ LcvwGGF8HkqGqT6BdB3Y/8m+PK79ih0geygWXQ1Hz+isa00F8jE2V7PTEpIGI5C1WYqk ryzrUZ7wXRILmWLLrcCFJooAyl4nmh7Am7NS229CM4It22E8GBSmz5ELAyaAAM6ycmU/ QjsNfY8xDpWmTGoCm3i0WBS9zvUf81j55O3fTDs4WgqbqtnvBkGcvVCpruZrZ1r6fMI3 OH7Ch4s3zts0Tp81zOD6B2yaSoE6KTmysfgTd+IhE0xue63eWpbdXRewfw2pmcA6Vstw CIvw== X-Gm-Message-State: AOAM533Xoi9+6O1C+3+1RaeW+pqR/YUuZNBQzaXKZRptxvpq/+zWCMNt 1RxgEOpZb91vvwDVZKt3zwWx52eMaD4sDTdrO7QVDvErOFzHqiaS+M0VA/EJRM2JOW5dHc4r45V pg8ltPl3O9bI0aQC8dG9FUIYNHD13Efh3MwN1HdZOoW+1okE= X-Received: by 2002:a17:906:bc81:: with SMTP id lv1mr11590276ejb.393.1629319303108; Wed, 18 Aug 2021 13:41:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuYU3uP7y//yQFosQFGT8VE96LJF4E5eKGo52ons6ugHXq2GC+IHUQY+3g7aV0U22I95MmCg== X-Received: by 2002:a17:906:bc81:: with SMTP id lv1mr11590254ejb.393.1629319302920; Wed, 18 Aug 2021 13:41:42 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id kv4sm360228ejc.35.2021.08.18.13.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 13:41:42 -0700 (PDT) Subject: Re: [PATCH v3 00/13] MT8195 SMI support To: Yong Wu , Rob Herring , Matthias Brugger References: <20210810080859.29511-1-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: <1a160afd-ceeb-04a3-8213-fe781ec18e30@canonical.com> Date: Wed, 18 Aug 2021 22:41:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210810080859.29511-1-yong.wu@mediatek.com> Content-Language: en-US Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, yi.kuo@mediatek.com, srv_heupstream@mediatek.com, Will Deacon , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, anthony.huang@mediatek.com, ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Robin Murphy , Ikjoon Jang , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 10/08/2021 10:08, Yong Wu wrote: > This patchset mainly adds SMI support for mt8195. > > Comparing with the previous version, add two new functions: > a) add smi sub common > b) add initial setting for smi-common and smi-larb. > > Change note: > v3:1) In the dt-binding: > a. Change mediatek,smi type from phandle-array to phandle from Rob. > b. Add a new bool property (mediatek,smi_sub_common) > to indicate if this is smi-sub-common. > 2) Change the clock using bulk parting. > keep the smi-common's has_gals flag. more strict. > 3) More comment about larb initial setting. > 4) Add a maintain patch The patchset looks good to me but I saw now comments from Rob, so I expect a resend. Therefore there is also time for additional review - maybe continued by Ikjoon Jang? If you sent a v4 with fixes rather soon and get ack from Rob, I could still try to get it into next merge window. After this weekend I won't be taking patches for this cycle and it will wait for the merge window to finish. Best regards, Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18175C4338F for ; Wed, 18 Aug 2021 20:42:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C27F961101 for ; Wed, 18 Aug 2021 20:42:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C27F961101 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=JAyAGELNf2N73jKXq8+3v5oiFvXFqHxEv2GL7I+BnAc=; b=AXK5HDFeqDqYIDwg/lksMdoT1G FKvCtFEdIiHP5ktMw1eu+Mqf5A5KPq5iTDmxYAathtZU0eFSOeX8QNj+qNsqxladWRd9dg3opUN3d CjwalXKHYmmefe7sF8TQ0Raka6cwuu8Rf2emQYzctf0DkWoesc2tLzsd6wCOX0mxEcw+NaL0NGbga pSuAY/nlNNJjASRf4a739YfYv7FQ9ACjRPBnNRSmpmZ6Rb7FzUjt75jSfDa0tABv2yFWnW8CIs7ZT 382vo6n642R6bciJPlht4DFuMLT2lm41z+kvHAqbR7QHw9f1XyvNiZmLmIkeaoNEW4Mm9KmSrT+pw zws6OLrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGSNr-006dbi-BY; Wed, 18 Aug 2021 20:41:59 +0000 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGSNl-006dau-Mw for linux-mediatek@lists.infradead.org; Wed, 18 Aug 2021 20:41:57 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 9390041EFE for ; Wed, 18 Aug 2021 20:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629319303; bh=UOE20OlnZGDBI1w8hzaIpuPN6xfmK8WguChjFrKnZuU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=AMPMxxlzH93EbqKkvvLs1/DuQFC7yPashajwqCWDTb5Z9STiD2KQD41p3+feaJbPp /cavtIUhM2VD1MxPW7G9Pv9TOz0eUjj1uCFo4t/f6c0z0V4e7J1eWINFZGX4DmGZwg /V9g9bFGwUVunKivZPtwf+GOK3tvuP0OLH7ybfssKcqx9c51xRFTvCHxFn73IFxyHJ xCOGkA/NksndsMW8fZQ6Abiu+eVTqGyJJ3lttmpJQ6IDjMTDMSWp5pOczdmsfKLXsn elTPpgn1cjxoz4n6IVIyL+lyUFHLky2PUsVs/GC/3m11yuONC2thZ7mTLXMiewr1Vx WFBrpiBsD0KsA== Received: by mail-ed1-f69.google.com with SMTP id ec47-20020a0564020d6fb02903be5e0a8cd2so1687940edb.0 for ; Wed, 18 Aug 2021 13:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UOE20OlnZGDBI1w8hzaIpuPN6xfmK8WguChjFrKnZuU=; b=IIz6PurUXCHSBmfJ2aV0K1/twJpbUOBUbzgnU1s/71rexeMtQspnBEL3NcEiy6cW1i QX51mr8R8fvuHS1RO959+Np206NjhgDVAuILo8CRXWGJxOnbQpeaNfc9ZFafrWCAzAQs halA7+J3GQJQbfIKfftoEnNetMOo2QgkptEhNFCX9cjwhkYdYp6NAY60F8ocO+yXaAtO 18f7n0q+f1Z4HDSnSqBhhaeLfTdI3mxTcpoBg1XDf+AzuUZRln5iXZb8SH94djp57L3W V9QGGmNLj5Egwh44Qs8bnzzmRb87V75LDf2BdGbbP74qblCekQ8pVZpREwnuw58J3mx3 CPig== X-Gm-Message-State: AOAM531uSP81bzYUpc5ootPk/rt9RBUmMbv7TzzS1QRaC24xKrKptL+J LEgg5Gkn9ofodzaTEJQvZokc8RvbgBDotRmNvd2RnfZLQFNLk4S10ccwBEanfD/qPyxpsEs0EsH w0zrTZfLr9AWkSzK8LxgsmaV33BqSgFlxhJ3hIscvwmMlwC6ryA== X-Received: by 2002:a17:906:bc81:: with SMTP id lv1mr11590288ejb.393.1629319303179; Wed, 18 Aug 2021 13:41:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuYU3uP7y//yQFosQFGT8VE96LJF4E5eKGo52ons6ugHXq2GC+IHUQY+3g7aV0U22I95MmCg== X-Received: by 2002:a17:906:bc81:: with SMTP id lv1mr11590254ejb.393.1629319302920; Wed, 18 Aug 2021 13:41:42 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id kv4sm360228ejc.35.2021.08.18.13.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 13:41:42 -0700 (PDT) Subject: Re: [PATCH v3 00/13] MT8195 SMI support To: Yong Wu , Rob Herring , Matthias Brugger Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com, Ikjoon Jang References: <20210810080859.29511-1-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: <1a160afd-ceeb-04a3-8213-fe781ec18e30@canonical.com> Date: Wed, 18 Aug 2021 22:41:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210810080859.29511-1-yong.wu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_134153_956912_FC75E6B7 X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 10/08/2021 10:08, Yong Wu wrote: > This patchset mainly adds SMI support for mt8195. > > Comparing with the previous version, add two new functions: > a) add smi sub common > b) add initial setting for smi-common and smi-larb. > > Change note: > v3:1) In the dt-binding: > a. Change mediatek,smi type from phandle-array to phandle from Rob. > b. Add a new bool property (mediatek,smi_sub_common) > to indicate if this is smi-sub-common. > 2) Change the clock using bulk parting. > keep the smi-common's has_gals flag. more strict. > 3) More comment about larb initial setting. > 4) Add a maintain patch The patchset looks good to me but I saw now comments from Rob, so I expect a resend. Therefore there is also time for additional review - maybe continued by Ikjoon Jang? If you sent a v4 with fixes rather soon and get ack from Rob, I could still try to get it into next merge window. After this weekend I won't be taking patches for this cycle and it will wait for the merge window to finish. Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD71C4338F for ; Wed, 18 Aug 2021 20:44:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 190BA610F7 for ; Wed, 18 Aug 2021 20:44:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 190BA610F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=iCdgkXw0PWpqi9YM02pvHMRrk2X3dOFxMeskJwLYVlM=; b=a9DR6c2kaJC5ZkPzWFO0EwN/uj qQ9fpRHkD0JkOnQZM0ZmN5QNJFYoY2OpCt4+XpHkaY3lc1uox3jT5Ir+t3kRsZdjXl7VAauyvGhG/ DNmuAhg6ixvyVqS7ISWNIaz8JKOE0iX3Tsq37ew/mMWU3kmtpTkx7EAQKBfx1MNGehDXzX6Z9Ux36 9ITgnAKhysSgvFAHvR/tQ2tlrKsSxUoqUnPrGuwNSGWipRkiNJML1pZ69UXBOs02RoCO1ts8twM2E UDtAU8LVdmVZJlvq84u5jxV/r4iK0m1QOXsADs+DkPT6JfRIywPOo+WqPlH6PnV0zd2H4bdFJlXqs fMyb2fkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGSNu-006dbq-1t; Wed, 18 Aug 2021 20:42:02 +0000 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGSNl-006dat-Mt for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 20:41:59 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 7B1C040CD4 for ; Wed, 18 Aug 2021 20:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629319303; bh=UOE20OlnZGDBI1w8hzaIpuPN6xfmK8WguChjFrKnZuU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=AMPMxxlzH93EbqKkvvLs1/DuQFC7yPashajwqCWDTb5Z9STiD2KQD41p3+feaJbPp /cavtIUhM2VD1MxPW7G9Pv9TOz0eUjj1uCFo4t/f6c0z0V4e7J1eWINFZGX4DmGZwg /V9g9bFGwUVunKivZPtwf+GOK3tvuP0OLH7ybfssKcqx9c51xRFTvCHxFn73IFxyHJ xCOGkA/NksndsMW8fZQ6Abiu+eVTqGyJJ3lttmpJQ6IDjMTDMSWp5pOczdmsfKLXsn elTPpgn1cjxoz4n6IVIyL+lyUFHLky2PUsVs/GC/3m11yuONC2thZ7mTLXMiewr1Vx WFBrpiBsD0KsA== Received: by mail-ed1-f69.google.com with SMTP id p2-20020a50c9420000b02903a12bbba1ebso1665221edh.6 for ; Wed, 18 Aug 2021 13:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UOE20OlnZGDBI1w8hzaIpuPN6xfmK8WguChjFrKnZuU=; b=Kulb4s2GlWc6ONvSiREtxz2r1OpY4xYLqzjb3mQRxT18oIMCb3boP4ZnsY0r3DO3IH f4Tf5a/XRWGtEDB6bCsPiS0gje0/jOtf7Q4slhnGKj1T/awExqhzEO2tz9JpHpRQCuaa G8gvNutP+AMnlDXSrudP7prne1jDaAJ/MPYl9ypleWWUcch0jSmTEKaRtPKZJYyLZbhy ONS+6BkuM1YuLTt7EZOjGCnAEpXzbxLsBnAKUm0YLscQV6W5xrqkuLAxjT8pVqcCBxK9 2udU+KLUCVoBfqXfErU/xIarFZNbpoXU3bT/rFjTrBUeSswWo1v9t+dIvMyXcA1Jk0r5 WRWw== X-Gm-Message-State: AOAM530wGGQ/C0OObWPzow8VQE1nRYg7GBjz+TkPWYrP9TpoEgpa9RHX igd504g6crUYizUwSV5hFVoy3EWpvpWSrm323VeOvB55uP/lcxx8Ju4HjrNh3FivqVns55KVRsI d67Um9KVJQ0oyOtOMADTunFisUjXJrDN4DYOWUYlN+CgVbYX+Z4eb X-Received: by 2002:a17:906:bc81:: with SMTP id lv1mr11590283ejb.393.1629319303125; Wed, 18 Aug 2021 13:41:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuYU3uP7y//yQFosQFGT8VE96LJF4E5eKGo52ons6ugHXq2GC+IHUQY+3g7aV0U22I95MmCg== X-Received: by 2002:a17:906:bc81:: with SMTP id lv1mr11590254ejb.393.1629319302920; Wed, 18 Aug 2021 13:41:42 -0700 (PDT) Received: from [192.168.8.102] ([86.32.42.198]) by smtp.gmail.com with ESMTPSA id kv4sm360228ejc.35.2021.08.18.13.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 13:41:42 -0700 (PDT) Subject: Re: [PATCH v3 00/13] MT8195 SMI support To: Yong Wu , Rob Herring , Matthias Brugger Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com, Ikjoon Jang References: <20210810080859.29511-1-yong.wu@mediatek.com> From: Krzysztof Kozlowski Message-ID: <1a160afd-ceeb-04a3-8213-fe781ec18e30@canonical.com> Date: Wed, 18 Aug 2021 22:41:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210810080859.29511-1-yong.wu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_134153_957799_AC6CB9EB X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/08/2021 10:08, Yong Wu wrote: > This patchset mainly adds SMI support for mt8195. > > Comparing with the previous version, add two new functions: > a) add smi sub common > b) add initial setting for smi-common and smi-larb. > > Change note: > v3:1) In the dt-binding: > a. Change mediatek,smi type from phandle-array to phandle from Rob. > b. Add a new bool property (mediatek,smi_sub_common) > to indicate if this is smi-sub-common. > 2) Change the clock using bulk parting. > keep the smi-common's has_gals flag. more strict. > 3) More comment about larb initial setting. > 4) Add a maintain patch The patchset looks good to me but I saw now comments from Rob, so I expect a resend. Therefore there is also time for additional review - maybe continued by Ikjoon Jang? If you sent a v4 with fixes rather soon and get ack from Rob, I could still try to get it into next merge window. After this weekend I won't be taking patches for this cycle and it will wait for the merge window to finish. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel