From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B876AC47094 for ; Mon, 7 Jun 2021 13:01:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8494B60C3E for ; Mon, 7 Jun 2021 13:01:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8494B60C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5E8B6E8B0; Mon, 7 Jun 2021 13:01:09 +0000 (UTC) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AC826E8B0 for ; Mon, 7 Jun 2021 13:01:08 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id h8so17509935wrz.8 for ; Mon, 07 Jun 2021 06:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=Ip7WAmn26bJSRytvPb1CU10wgClEIXRXGPWRzCPad9c=; b=jfdHT1nbM35//WdF3yBp6ufe8wmBiCIUFa07l9VQ1+DHXrS6CQURgWEg8P3b0TlRHQ OruqJmh4D0urm/MOgdvwyUhNvhdChi7RRJFERkoPiQ27b6TJ8Jr+HG7RC1Dv5HOjHxy+ jnA4E3i1RChSNn5DXimesC/lm4FN7MUc2PMGF0ZSlBZe1Aleh+rKdwx2UEHcE7GkrdsL kcY2dhBggPAO0F6HiIApMEu7vsGXGcMzWdtQTDaSfHpdRi1D/XUms80XsRTdHITsZ452 mAK4G+IxHt5IdOce5cc3kXdpD6DLY+QbiDTHxjmxzWSlyocB7FziZMCLOo83wFB/Clev avtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=Ip7WAmn26bJSRytvPb1CU10wgClEIXRXGPWRzCPad9c=; b=Ig98dZi8BXGWGXBp+Az/pZuxobFTC9pHcwR2W3+5o70J+U5p/mWwfhOmnTI7N9GA6W kv9vcMRGj7KHZNeVkdnp824mM/Ff++uFMeLnwWWA/bcaE9YzfRWpSVBnF1DB2e5H50X+ XweR0RXTMF4LWGab1jokE81kSLIbGVArDnBwC8imYiPMO42K58hREKFR3Lq1SP9lL6b8 cDdRfRl83KxfQ8ku+oBnX/47r6Lb5aTNWBgV6s4KgCgkIamK6Bv5tESneLkbzabq9Jx8 FAZS8GX0+IsJi/0zAsENb27mGMwco0wUC453PtTfEtbwI7LmftoMl4CMgNANaYYlyXE3 LIlA== X-Gm-Message-State: AOAM532uCrS2pGLu9np4F/Jp4s7sWuB4vki8+bCRMh1rrG0qHbZ25tWD h4lX3myxCKDqXPI2evGgq0H0MvtbF8U= X-Google-Smtp-Source: ABdhPJwk9dbXi4Wa9mAk3WvsMgrQM4gG/F+6zdl37nm056ZhmeqUYNF8MH1J9c9pyCdZwWxxzJRNtg== X-Received: by 2002:adf:9c93:: with SMTP id d19mr16887813wre.17.1623070866798; Mon, 07 Jun 2021 06:01:06 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:ce67:4e4d:875d:ffeb? ([2a02:908:1252:fb60:ce67:4e4d:875d:ffeb]) by smtp.gmail.com with ESMTPSA id i16sm14140603wmm.9.2021.06.07.06.01.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 06:01:06 -0700 (PDT) Subject: Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3 To: Nirmoy Das References: <20210601122528.1643-1-christian.koenig@amd.com> <0051cab9-8d65-d28f-956e-3a60718bf000@gmail.com> <0fc2844d-b954-2386-17e3-e2c4232fc247@shipmail.org> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <1a18dab0-45ee-3406-05f6-fe3ae3b2d136@gmail.com> Date: Mon, 7 Jun 2021 15:01:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------F01417D7F0A08938DAE2D150" Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yu, Lang" , "dri-devel@lists.freedesktop.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is a multi-part message in MIME format. --------------F01417D7F0A08938DAE2D150 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi Nirmoy, can you give that patch set a testing round and an review? The memory stress test with low VRAM on APUs should be sufficient and you should have that setup still around. Thanks in advance, Christian. Am 07.06.21 um 14:58 schrieb Yu, Lang: > > [AMD Official Use Only] > > > Thanks，please let Nirmoy do it. > > Regards， > Lang > > 获取 Outlook for iOS > ------------------------------------------------------------------------ > *发件人:* Christian König > *发送时间:* Monday, June 7, 2021 8:41:49 PM > *收件人:* Thomas Hellström (Intel) ; Yu, Lang > > *抄送:* dri-devel@lists.freedesktop.org > *主题:* Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3 > Thanks! > > Lang can anybody from your team give as an reviewed-by/test-by on the > amdgpu patches? I just want another pair of eyes looking over it. > > If nobody else has time I will ask Nirmoy for a quick testing round. > > Thanks, > Christian. > > Am 07.06.21 um 14:38 schrieb Thomas Hellström (Intel): > > Sure. LGTM, > > > > Reviewed-by: Thomas Hellström > > > > > > On 6/7/21 2:36 PM, Christian König wrote: > >> Thomas any comments on this? > >> > >> Is the purpose of this now clear enough? > >> > >> Thanks, > >> Christian. > >> > >> Am 01.06.21 um 14:25 schrieb Christian König: > >>> From: Lang Yu > >>> > >>> Sometimes drivers need to use bounce buffers to evict BOs. While > >>> those reside > >>> in some domain they are not necessarily suitable for CS. > >>> > >>> Add a flag so that drivers can note that a bounce buffers needs to be > >>> reallocated during validation. > >>> > >>> v2: add detailed comments > >>> v3 (chk): merge commits and rework commit message > >>> > >>> Suggested-by: Christian König > >>> Signed-off-by: Lang Yu > >>> Signed-off-by: Christian König > >>> --- > >>>   drivers/gpu/drm/ttm/ttm_bo.c    | 3 +++ > >>>   include/drm/ttm/ttm_placement.h | 7 +++++-- > >>>   2 files changed, 8 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c > >>> b/drivers/gpu/drm/ttm/ttm_bo.c > >>> index 51a94fd63bd7..6b393502198e 100644 > >>> --- a/drivers/gpu/drm/ttm/ttm_bo.c > >>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c > >>> @@ -929,6 +929,9 @@ static bool ttm_bo_places_compat(const struct > >>> ttm_place *places, > >>>   { > >>>       unsigned i; > >>>   +    if (mem->placement & TTM_PL_FLAG_TEMPORARY) > >>> +        return false; > >>> + > >>>       for (i = 0; i < num_placement; i++) { > >>>           const struct ttm_place *heap = &places[i]; > >>>   diff --git a/include/drm/ttm/ttm_placement.h > >>> b/include/drm/ttm/ttm_placement.h > >>> index aa6ba4d0cf78..8995c9e4ec1b 100644 > >>> --- a/include/drm/ttm/ttm_placement.h > >>> +++ b/include/drm/ttm/ttm_placement.h > >>> @@ -47,8 +47,11 @@ > >>>    * top of the memory area, instead of the bottom. > >>>    */ > >>>   -#define TTM_PL_FLAG_CONTIGUOUS  (1 << 19) > >>> -#define TTM_PL_FLAG_TOPDOWN     (1 << 22) > >>> +#define TTM_PL_FLAG_CONTIGUOUS  (1 << 0) > >>> +#define TTM_PL_FLAG_TOPDOWN     (1 << 1) > >>> + > >>> +/* For multihop handling */ > >>> +#define TTM_PL_FLAG_TEMPORARY   (1 << 2) > >>>     /** > >>>    * struct ttm_place > --------------F01417D7F0A08938DAE2D150 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Nirmoy,

can you give that patch set a testing round and an review?

The memory stress test with low VRAM on APUs should be sufficient and you should have that setup still around.

Thanks in advance,
Christian.

Am 07.06.21 um 14:58 schrieb Yu, Lang:

[AMD Official Use Only]


Thanks，please let Nirmoy do it.

Regards，
Lang

获取 Outlook for iOS
发件人: Christian König <ckoenig.leichtzumerken@gmail.com>
发送时间: Monday, June 7, 2021 8:41:49 PM
收件人: Thomas Hellström (Intel) <thomas_os@shipmail.org>; Yu, Lang <Lang.Yu@amd.com>
抄送: dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>
主题: Re: [PATCH 1/4] drm/ttm: add TTM_PL_FLAG_TEMPORARY flag v3
 
Thanks!

Lang can anybody from your team give as an reviewed-by/test-by on the
amdgpu patches? I just want another pair of eyes looking over it.

If nobody else has time I will ask Nirmoy for a quick testing round.

Thanks,
Christian.

Am 07.06.21 um 14:38 schrieb Thomas Hellström (Intel):
> Sure. LGTM,
>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
>
> On 6/7/21 2:36 PM, Christian König wrote:
>> Thomas any comments on this?
>>
>> Is the purpose of this now clear enough?
>>
>> Thanks,
>> Christian.
>>
>> Am 01.06.21 um 14:25 schrieb Christian König:
>>> From: Lang Yu <Lang.Yu@amd.com>
>>>
>>> Sometimes drivers need to use bounce buffers to evict BOs. While
>>> those reside
>>> in some domain they are not necessarily suitable for CS.
>>>
>>> Add a flag so that drivers can note that a bounce buffers needs to be
>>> reallocated during validation.
>>>
>>> v2: add detailed comments
>>> v3 (chk): merge commits and rework commit message
>>>
>>> Suggested-by: Christian König <christian.koenig@amd.com>
>>> Signed-off-by: Lang Yu <Lang.Yu@amd.com>
>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>> ---
>>>   drivers/gpu/drm/ttm/ttm_bo.c    | 3 +++
>>>   include/drm/ttm/ttm_placement.h | 7 +++++--
>>>   2 files changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c
>>> b/drivers/gpu/drm/ttm/ttm_bo.c
>>> index 51a94fd63bd7..6b393502198e 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>>> @@ -929,6 +929,9 @@ static bool ttm_bo_places_compat(const struct
>>> ttm_place *places,
>>>   {
>>>       unsigned i;
>>>   +    if (mem->placement & TTM_PL_FLAG_TEMPORARY)
>>> +        return false;
>>> +
>>>       for (i = 0; i < num_placement; i++) {
>>>           const struct ttm_place *heap = &places[i];
>>>   diff --git a/include/drm/ttm/ttm_placement.h
>>> b/include/drm/ttm/ttm_placement.h
>>> index aa6ba4d0cf78..8995c9e4ec1b 100644
>>> --- a/include/drm/ttm/ttm_placement.h
>>> +++ b/include/drm/ttm/ttm_placement.h
>>> @@ -47,8 +47,11 @@
>>>    * top of the memory area, instead of the bottom.
>>>    */
>>>   -#define TTM_PL_FLAG_CONTIGUOUS  (1 << 19)
>>> -#define TTM_PL_FLAG_TOPDOWN     (1 << 22)
>>> +#define TTM_PL_FLAG_CONTIGUOUS  (1 << 0)
>>> +#define TTM_PL_FLAG_TOPDOWN     (1 << 1)
>>> +
>>> +/* For multihop handling */
>>> +#define TTM_PL_FLAG_TEMPORARY   (1 << 2)
>>>     /**
>>>    * struct ttm_place


--------------F01417D7F0A08938DAE2D150--