From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B40DC2D0A8 for ; Wed, 23 Sep 2020 13:58:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D423F2220D for ; Wed, 23 Sep 2020 13:58:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbgIWN6w (ORCPT ); Wed, 23 Sep 2020 09:58:52 -0400 Received: from mga04.intel.com ([192.55.52.120]:58458 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbgIWN6w (ORCPT ); Wed, 23 Sep 2020 09:58:52 -0400 IronPort-SDR: DHXEaFJaDvkKleOy7vfHKXSU2Z4dPaLKXtMyNYPve7btdCAHW8naGWSIJQKWG8lUWc9T4q5o0C QzlS6zutmLgA== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="158271541" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="158271541" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:58:51 -0700 IronPort-SDR: DOZNQUTwNmS6CdTEWIoW9qi7Sh22K+ola1js+j+Vn7PmZQGNyFPiXcYUQXMNKslnCfCP8vR0bU ku9o4NuN7J+w== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="486449272" Received: from yymichae-mobl.ger.corp.intel.com (HELO [10.214.208.219]) ([10.214.208.219]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:58:46 -0700 Subject: Re: [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map To: Christoph Hellwig Cc: Andrew Morton , Juergen Gross , Stefano Stabellini , linux-mm@kvack.org, Peter Zijlstra , intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, Minchan Kim , dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , Nitin Gupta References: <20200918163724.2511-1-hch@lst.de> <20200918163724.2511-5-hch@lst.de> <9b5d40af-7378-9e68-ca51-73b2148287f3@linux.intel.com> <20200923134117.GB9893@lst.de> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <1a421e7f-6255-c534-5403-715c2e809bd0@linux.intel.com> Date: Wed, 23 Sep 2020 14:58:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200923134117.GB9893@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/09/2020 14:41, Christoph Hellwig wrote: > On Wed, Sep 23, 2020 at 10:52:33AM +0100, Tvrtko Ursulin wrote: >> >> On 18/09/2020 17:37, Christoph Hellwig wrote: >>> i915_gem_object_map implements fairly low-level vmap functionality in >>> a driver. Split it into two helpers, one for remapping kernel memory >>> which can use vmap, and one for I/O memory that uses vmap_pfn. >>> >>> The only practical difference is that alloc_vm_area prefeaults the >>> vmalloc area PTEs, which doesn't seem to be required here for the >>> kernel memory case (and could be added to vmap using a flag if actually >>> required). >> >> Patch looks good to me. >> >> Series did not get a CI run from our side because of a different base so I >> don't know if you would like to have a run there? If so you would need to >> rebase against git://anongit.freedesktop.org/drm-tip drm-tip and you could >> even send a series to intel-gfx-trybot@lists.freedesktop.org, suppressing >> cc, to check it out without sending a copy to the real mailing list. > > It doesn't seem like I can post to any freedesktop list, as I always > get rejection messages. But I'll happily prepare a branch if one > of you an feed it into your CI. That's fine, just ping me and I will forward it for testing, thanks! Regards, Tvrtko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309E8C4727F for ; Wed, 23 Sep 2020 13:58:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD973221EB for ; Wed, 23 Sep 2020 13:58:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD973221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 007716E4FB; Wed, 23 Sep 2020 13:58:54 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAD8D6E4FB; Wed, 23 Sep 2020 13:58:52 +0000 (UTC) IronPort-SDR: yoff5pUUQpEFfDnx5QFTuUnadPUZgl6z2nQLqcsJq/5CDqySJImnY+B4xeh5McSJva3K09NG0H JRxtwJ7fDyPA== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="160172690" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="160172690" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:58:52 -0700 IronPort-SDR: DOZNQUTwNmS6CdTEWIoW9qi7Sh22K+ola1js+j+Vn7PmZQGNyFPiXcYUQXMNKslnCfCP8vR0bU ku9o4NuN7J+w== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="486449272" Received: from yymichae-mobl.ger.corp.intel.com (HELO [10.214.208.219]) ([10.214.208.219]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:58:46 -0700 Subject: Re: [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map To: Christoph Hellwig References: <20200918163724.2511-1-hch@lst.de> <20200918163724.2511-5-hch@lst.de> <9b5d40af-7378-9e68-ca51-73b2148287f3@linux.intel.com> <20200923134117.GB9893@lst.de> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <1a421e7f-6255-c534-5403-715c2e809bd0@linux.intel.com> Date: Wed, 23 Sep 2020 14:58:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200923134117.GB9893@lst.de> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Minchan Kim , Peter Zijlstra , intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, Andrew Morton , Boris Ostrovsky , Nitin Gupta Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 23/09/2020 14:41, Christoph Hellwig wrote: > On Wed, Sep 23, 2020 at 10:52:33AM +0100, Tvrtko Ursulin wrote: >> >> On 18/09/2020 17:37, Christoph Hellwig wrote: >>> i915_gem_object_map implements fairly low-level vmap functionality in >>> a driver. Split it into two helpers, one for remapping kernel memory >>> which can use vmap, and one for I/O memory that uses vmap_pfn. >>> >>> The only practical difference is that alloc_vm_area prefeaults the >>> vmalloc area PTEs, which doesn't seem to be required here for the >>> kernel memory case (and could be added to vmap using a flag if actually >>> required). >> >> Patch looks good to me. >> >> Series did not get a CI run from our side because of a different base so I >> don't know if you would like to have a run there? If so you would need to >> rebase against git://anongit.freedesktop.org/drm-tip drm-tip and you could >> even send a series to intel-gfx-trybot@lists.freedesktop.org, suppressing >> cc, to check it out without sending a copy to the real mailing list. > > It doesn't seem like I can post to any freedesktop list, as I always > get rejection messages. But I'll happily prepare a branch if one > of you an feed it into your CI. That's fine, just ping me and I will forward it for testing, thanks! Regards, Tvrtko _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F4A8C2D0A8 for ; Wed, 23 Sep 2020 13:58:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB774221EB for ; Wed, 23 Sep 2020 13:58:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB774221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 291736E9A5; Wed, 23 Sep 2020 13:58:54 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAD8D6E4FB; Wed, 23 Sep 2020 13:58:52 +0000 (UTC) IronPort-SDR: yoff5pUUQpEFfDnx5QFTuUnadPUZgl6z2nQLqcsJq/5CDqySJImnY+B4xeh5McSJva3K09NG0H JRxtwJ7fDyPA== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="160172690" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="160172690" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:58:52 -0700 IronPort-SDR: DOZNQUTwNmS6CdTEWIoW9qi7Sh22K+ola1js+j+Vn7PmZQGNyFPiXcYUQXMNKslnCfCP8vR0bU ku9o4NuN7J+w== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="486449272" Received: from yymichae-mobl.ger.corp.intel.com (HELO [10.214.208.219]) ([10.214.208.219]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 06:58:46 -0700 To: Christoph Hellwig References: <20200918163724.2511-1-hch@lst.de> <20200918163724.2511-5-hch@lst.de> <9b5d40af-7378-9e68-ca51-73b2148287f3@linux.intel.com> <20200923134117.GB9893@lst.de> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <1a421e7f-6255-c534-5403-715c2e809bd0@linux.intel.com> Date: Wed, 23 Sep 2020 14:58:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200923134117.GB9893@lst.de> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Minchan Kim , Peter Zijlstra , intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, Andrew Morton , Boris Ostrovsky , Nitin Gupta Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 23/09/2020 14:41, Christoph Hellwig wrote: > On Wed, Sep 23, 2020 at 10:52:33AM +0100, Tvrtko Ursulin wrote: >> >> On 18/09/2020 17:37, Christoph Hellwig wrote: >>> i915_gem_object_map implements fairly low-level vmap functionality in >>> a driver. Split it into two helpers, one for remapping kernel memory >>> which can use vmap, and one for I/O memory that uses vmap_pfn. >>> >>> The only practical difference is that alloc_vm_area prefeaults the >>> vmalloc area PTEs, which doesn't seem to be required here for the >>> kernel memory case (and could be added to vmap using a flag if actually >>> required). >> >> Patch looks good to me. >> >> Series did not get a CI run from our side because of a different base so I >> don't know if you would like to have a run there? If so you would need to >> rebase against git://anongit.freedesktop.org/drm-tip drm-tip and you could >> even send a series to intel-gfx-trybot@lists.freedesktop.org, suppressing >> cc, to check it out without sending a copy to the real mailing list. > > It doesn't seem like I can post to any freedesktop list, as I always > get rejection messages. But I'll happily prepare a branch if one > of you an feed it into your CI. That's fine, just ping me and I will forward it for testing, thanks! Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx