From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AB42C07E96 for ; Thu, 8 Jul 2021 08:33:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7D8161C40 for ; Thu, 8 Jul 2021 08:33:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7D8161C40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1PSv-0002iA-Rp for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 04:33:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1PSG-000219-Q7 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 04:32:20 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:46940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1PSF-0004Qb-6S for qemu-devel@nongnu.org; Thu, 08 Jul 2021 04:32:20 -0400 Received: by mail-wm1-x334.google.com with SMTP id k16-20020a05600c1c90b02901f4ed0fcfe7so3426780wms.5 for ; Thu, 08 Jul 2021 01:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TfVKzjZOfg1kRWMydx0p+soilkjSFL5ekN7mSt1x61w=; b=cSwCCZcl2u1iRKouD5XPFiyqYRjVnS+mVeaYEDL3+6HLcQ2UZej2lLdD1U2LYbJred /4HQXZ7SZJGfXIMMg42ZF/eRHjeFJz1EL3iakWI+3fd4k7guWBaWaMoTJ7ovgC+iRkdC DOEFURpYSWiG+G0sQOR5xQlEo87ghQ/Xod4S7EwIrHvKtSlTlMOsXqNwUbzglKMoZYl1 oeGhjBlAtLKSHaOVwvWaufOpjUsma1N2NZD3xh3zLCWJI7o/h1dEMb8mqUA/dzJRgUIe kLntsQVn9qM6qhnGESu8lTfZ5R5tIhHFCIba+bK50iX9LGhwU7ql4Cm6zIFeT/i1bfPW rjRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TfVKzjZOfg1kRWMydx0p+soilkjSFL5ekN7mSt1x61w=; b=KWxVRaSYD8GJX4qSPme+6eFKlzBRsbYQH8uBSptumx0lHD2rV3S7K96+295TLt0fbq PCexo2tnCTmT5sZ3DDj/MSmQiVuGYozjmoXGOcQJyUWqnbPcL2H2kRP0hR8u5a11/XJc ZPTQsPVyfEEPH0kzYLPp+6nai3FTyuaRJBfCrIwJze75BtrA3Fpz1H7gGwZJIBGiJUH3 vXgK6kQhN3xUH9EM7qJ4UexzZ/y4cjIolOZhY4y2/A4n6GyJ2PM68x3pvykwskInpzSl Wbg0iEiYmp4mCpd3RAFpv90G+U2ZtH1c/NIFi7Cjo7v/TX1YnEEATasyB8NqLL8LvUpo nGBA== X-Gm-Message-State: AOAM5306QQHeuQNTMv5ngfcxPsfZy9u+BOnZ0VG2Engc6gxaVLWKXC7+ UOHbx0rpKgRKrwZaRhAWDP0= X-Google-Smtp-Source: ABdhPJzYdQPuPZzAwueJzkeFzCLOTwfFY4limTXKyOfybPkPHXKPGqAm/YAzM7o1CvdIsVG8C+5IGg== X-Received: by 2002:a1c:cc02:: with SMTP id h2mr31057391wmb.39.1625733137490; Thu, 08 Jul 2021 01:32:17 -0700 (PDT) Received: from [192.168.1.36] (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id n18sm7365988wms.3.2021.07.08.01.32.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jul 2021 01:32:16 -0700 (PDT) Subject: Re: [PATCH 05/12] linux-user: Extract target errno to 'target_errno_defs.h' To: Richard Henderson , qemu-devel@nongnu.org References: <20210704183755.655002-1-f4bug@amsat.org> <20210704183755.655002-6-f4bug@amsat.org> <11e451c0-dfc7-5709-9441-28da39b237e6@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <1a4beab8-aa19-ed90-3091-7717ab7d5f21@amsat.org> Date: Thu, 8 Jul 2021 10:32:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <11e451c0-dfc7-5709-9441-28da39b237e6@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taylor Simpson , Aleksandar Rikalo , Helge Deller , Aurelien Jarno , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/7/21 3:53 AM, Richard Henderson wrote: > On 7/4/21 11:37 AM, Philippe Mathieu-Daudé wrote: >> We want to access the target errno indepently of the rest >> of the linux-user code. Extract it to a new target-specific >> header: 'target_errno_defs.h'. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   linux-user/aarch64/target_errno_defs.h    | 6 ++++++ >>   linux-user/alpha/target_errno_defs.h      | 4 ++++ >>   linux-user/arm/target_errno_defs.h        | 6 ++++++ >>   linux-user/cris/target_errno_defs.h       | 6 ++++++ >>   linux-user/errno_defs.h                   | 3 +++ >>   linux-user/hexagon/target_errno_defs.h    | 6 ++++++ >>   linux-user/hppa/target_errno_defs.h       | 4 ++++ >>   linux-user/i386/target_errno_defs.h       | 6 ++++++ >>   linux-user/m68k/target_errno_defs.h       | 6 ++++++ >>   linux-user/microblaze/target_errno_defs.h | 6 ++++++ >>   linux-user/mips/target_errno_defs.h       | 4 ++++ >>   linux-user/mips64/target_errno_defs.h     | 4 ++++ >>   linux-user/nios2/target_errno_defs.h      | 6 ++++++ >>   linux-user/openrisc/target_errno_defs.h   | 6 ++++++ >>   linux-user/ppc/target_errno_defs.h        | 6 ++++++ >>   linux-user/riscv/target_errno_defs.h      | 6 ++++++ >>   linux-user/s390x/target_errno_defs.h      | 6 ++++++ >>   linux-user/sh4/target_errno_defs.h        | 6 ++++++ >>   linux-user/sparc/target_syscall.h         | 2 -- >>   linux-user/x86_64/target_errno_defs.h     | 6 ++++++ >>   linux-user/xtensa/target_errno_defs.h     | 6 ++++++ >>   21 files changed, 109 insertions(+), 2 deletions(-) >>   create mode 100644 linux-user/aarch64/target_errno_defs.h >>   create mode 100644 linux-user/alpha/target_errno_defs.h >>   create mode 100644 linux-user/arm/target_errno_defs.h >>   create mode 100644 linux-user/cris/target_errno_defs.h >>   create mode 100644 linux-user/hexagon/target_errno_defs.h >>   create mode 100644 linux-user/hppa/target_errno_defs.h >>   create mode 100644 linux-user/i386/target_errno_defs.h >>   create mode 100644 linux-user/m68k/target_errno_defs.h >>   create mode 100644 linux-user/microblaze/target_errno_defs.h >>   create mode 100644 linux-user/mips/target_errno_defs.h >>   create mode 100644 linux-user/mips64/target_errno_defs.h >>   create mode 100644 linux-user/nios2/target_errno_defs.h >>   create mode 100644 linux-user/openrisc/target_errno_defs.h >>   create mode 100644 linux-user/ppc/target_errno_defs.h >>   create mode 100644 linux-user/riscv/target_errno_defs.h >>   create mode 100644 linux-user/s390x/target_errno_defs.h >>   create mode 100644 linux-user/sh4/target_errno_defs.h >>   create mode 100644 linux-user/x86_64/target_errno_defs.h >>   create mode 100644 linux-user/xtensa/target_errno_defs.h >> >> diff --git a/linux-user/aarch64/target_errno_defs.h >> b/linux-user/aarch64/target_errno_defs.h >> new file mode 100644 >> index 00000000000..a809381165a >> --- /dev/null >> +++ b/linux-user/aarch64/target_errno_defs.h >> @@ -0,0 +1,6 @@ >> +#ifndef AARCH64_TARGET_ERRNO_H >> +#define AARCH64_TARGET_ERRNO_H >> + >> +/* Target uses generic errno */ >> + >> +#endif > > This could be better. > > Consider e.g. termbits.h as the model. Thanks for the tip! > These targets should have exactly one line: > > #include "../generic/target_errno.h" > >> diff --git a/linux-user/alpha/target_errno_defs.h >> b/linux-user/alpha/target_errno_defs.h >> new file mode 100644 >> index 00000000000..13770b14b82 >> --- /dev/null >> +++ b/linux-user/alpha/target_errno_defs.h >> @@ -0,0 +1,4 @@ >> +#ifndef ALPHA_TARGET_ERRNO_H >> +#define ALPHA_TARGET_ERRNO_H >> + >> +#endif > > This one, and ones like it, become > > #ifndef ALPHA_TARGET_ERRNO_H > #define ALPHA_TARGET_ERRNO_H > > #include "../generic/target_errno.h" > > #undef  TARGET_EBAR > #define TARGET_EBAR  xxx > ... > > #endif > > > r~ >