All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] x86/boot: Rationalise stack handling during early boot
Date: Thu, 9 Jan 2020 15:12:16 +0100	[thread overview]
Message-ID: <1a4c7ce0-d16d-7f5c-4101-e218a7918551@suse.com> (raw)
In-Reply-To: <20200109115133.24176-1-andrew.cooper3@citrix.com>

On 09.01.2020 12:51, Andrew Cooper wrote:
> The top (numerically higher addresses) of cpu0_stack[] contains the BSP's
> cpu_info block.  Logic in Xen expects this to be initialised to 0, but this
> area of stack is also used during early boot.
> 
> Update the head.S code to avoid using the cpu_info block.  Additionally,
> update the stack_start variable to match, which avoids __high_start() and
> efi_arch_post_exit_boot() needing to make the adjustment manually.
> 
> Finally, leave a big warning by the BIOS BSS initialisation, because it is by
> no means obvious that the stack doesn't survive the REP STOS.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

      reply	other threads:[~2020-01-09 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 17:00 [Xen-devel] [PATCH] x86/boot: Rationalise stack handling during early boot Andrew Cooper
2020-01-09 10:28 ` Jan Beulich
2020-01-09 10:43   ` Andrew Cooper
2020-01-09 10:52     ` Jan Beulich
2020-01-09 10:55       ` Andrew Cooper
2020-01-09 11:51 ` [Xen-devel] [PATCH v2] " Andrew Cooper
2020-01-09 14:12   ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a4c7ce0-d16d-7f5c-4101-e218a7918551@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.