All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Or Gerlitz <ogerlitz@mellanox.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: Jiri Pirko <jiri@mellanox.com>,
	netdev@vger.kernel.org, mlxsw@mellanox.com,
	Roi Dayan <roid@mellanox.com>
Subject: Re: [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver
Date: Tue, 17 Oct 2017 14:29:13 +0300	[thread overview]
Message-ID: <1a523077-3c05-ba97-8a65-1967765b8d5a@cogentembedded.com> (raw)
In-Reply-To: <1508145588-29959-1-git-send-email-ogerlitz@mellanox.com>

Hello!

On 10/16/2017 12:19 PM, Or Gerlitz wrote:

> Commit 7091d8c '(net/sched: cls_flower: Add offload support using egress

    At least 12 digits are needed.

> Hardware device') made sure (when fl_hw_replace_filter is called) to put
> the egress_dev mark on persisent structure instance. Hence, following calls

    Persistent.

> into the HW driver for stats and deletion will note it and act accordingly.
> 
> With commit de4784ca030f this property is lost and hence when called,
> the HW driver failes to operate (stats, delete) on the offloaded flow.

    Fails.

> Fix it by setting the egress_dev flag whenever the ingress device is
> different from the hw device since this is exactly the condition under
> which we're calling into the HW driver through the egress port net-device.
> 
> Fixes: de4784ca030f ('net: sched: get rid of struct tc_to_netdev')
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> Signed-off-by: Roi Dayan <roid@mellanox.com>
[...]

MBR, Sergei

  parent reply	other threads:[~2017-10-17 11:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16  9:19 [PATCH net] net/sched: cls_flower: Set egress_dev mark when calling into the HW driver Or Gerlitz
2017-10-16 12:41 ` Jiri Pirko
2017-10-16 20:20 ` David Miller
2017-10-17 11:29 ` Sergei Shtylyov [this message]
2017-10-18  7:14   ` Or Gerlitz
2017-10-18  8:09     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a523077-3c05-ba97-8a65-1967765b8d5a@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=jiri@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=roid@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.