From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04805C433EF for ; Mon, 27 Jun 2022 19:35:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240300AbiF0Tfn (ORCPT ); Mon, 27 Jun 2022 15:35:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236184AbiF0Tfm (ORCPT ); Mon, 27 Jun 2022 15:35:42 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5766A62EC; Mon, 27 Jun 2022 12:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1656358541; x=1687894541; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PZ6plud3Rf5fEMbZRuJvL10vqzgxzYsgamogPc/ulSs=; b=zi+neXZS5Tfo8fYmWYaZOlttgNGauVp6rk2ICfxqGMGlQse7BKBO7maI eN5wZGHT8LvaOr6ITx1HFWxxGYmFMckpxD0oewFFbcRNNQfEBHQ2M5Lua GqUZfBFVk/15lH2LNTw1JuzUqSUBPQVIqubt+ixvOSNDPq/3LahM1Xvqf 0=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 27 Jun 2022 12:35:41 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 12:35:40 -0700 Received: from nalasex01c.na.qualcomm.com (10.47.97.35) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 27 Jun 2022 12:35:40 -0700 Received: from [10.216.11.205] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 27 Jun 2022 12:35:35 -0700 Message-ID: <1a58e260-773e-754c-6f85-b4b2cbd19d2a@quicinc.com> Date: Tue, 28 Jun 2022 01:05:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH V2 5/8] pinctrl: qcom: Add IPQ5018 pinctrl driver Content-Language: en-US To: Bjorn Andersson CC: , , , , , , , , , , , , , , References: <20220621161126.15883-1-quic_srichara@quicinc.com> <20220621161126.15883-6-quic_srichara@quicinc.com> From: Sricharan Ramabadhran In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Thanks Bjorn for your review On 6/24/2022 9:24 AM, Bjorn Andersson wrote: > On Tue 21 Jun 11:11 CDT 2022, Sricharan R wrote: > [..] >> + >> +static const struct of_device_id ipq5018_pinctrl_of_match[] = { >> + { .compatible = "qcom,ipq5018-pinctrl", }, > Please make this qcom,ipq5018-tlmm, as requested in the binding.  Sure will do. > > With that: > > Reviewed-by: Bjorn Andersson   Thanks for that. Regards,   Sricharan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35105C433EF for ; Mon, 27 Jun 2022 19:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=omjUJmb2Fvo/necVxug+Uybk3s6OOUqdu2VlqoIvt9o=; b=T4NqZpUfByif/D 35Mbl+3VSpsmzzqMMHEj7H0N1jKGXXYhwQqLAV2W48pr872iVC8ijPMd0Ak0/FmUlDMERae4Z9nm6 z2TQmnft+aa2eGqrpDTMahx2idAAm/aE1FKmx2f7QQhlGRqLbvMGKzNoUhOHcqZGd1dPc2f7Et2mk QqbqIoMNeWzBaWtDgI+WAdj7Pfmrgw/GbvLUs6BorQOBP5iwmjqOEWuezbwentgw54szdq6iZVApN 9vbQhTWtnsO7gZZSCQ77gkZl8CYJk+QiVcHcLSGpSMIbXcmozGaO2xGmJ7YGzsMHGu04sMZBzmr8r 30tPE+NMe9z+p6Hp4KAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5uWT-002ZLn-0G; Mon, 27 Jun 2022 19:35:49 +0000 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5uWP-002ZJ6-Mb for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 19:35:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1656358545; x=1687894545; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PZ6plud3Rf5fEMbZRuJvL10vqzgxzYsgamogPc/ulSs=; b=mUV9Dd8PF7lMrES2V4Sb771SgWV+Y2UYi/Lr49mOxZFaeD04cJR4MIYq oqFagZyeZcUqIRAo/fhf4nXmFNQ74gXaGlGRiIlS+fNPDXDq3Ki7lEOPK sZbOo2TkZGwDI4oBmSr5qT7oson608W1CibSxXq/kPzJLPqpmIMPHNidD 4=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 27 Jun 2022 12:35:41 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 12:35:40 -0700 Received: from nalasex01c.na.qualcomm.com (10.47.97.35) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 27 Jun 2022 12:35:40 -0700 Received: from [10.216.11.205] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 27 Jun 2022 12:35:35 -0700 Message-ID: <1a58e260-773e-754c-6f85-b4b2cbd19d2a@quicinc.com> Date: Tue, 28 Jun 2022 01:05:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH V2 5/8] pinctrl: qcom: Add IPQ5018 pinctrl driver Content-Language: en-US To: Bjorn Andersson CC: , , , , , , , , , , , , , , References: <20220621161126.15883-1-quic_srichara@quicinc.com> <20220621161126.15883-6-quic_srichara@quicinc.com> From: Sricharan Ramabadhran In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_123545_792066_2DB9E73C X-CRM114-Status: UNSURE ( 6.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhhbmtzIEJqb3JuIGZvciB5b3VyIHJldmlldwoKT24gNi8yNC8yMDIyIDk6MjQgQU0sIEJqb3Ju IEFuZGVyc3NvbiB3cm90ZToKPiBPbiBUdWUgMjEgSnVuIDExOjExIENEVCAyMDIyLCBTcmljaGFy YW4gUiB3cm90ZToKPiBbLi5dCj4+ICsKPj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNl X2lkIGlwcTUwMThfcGluY3RybF9vZl9tYXRjaFtdID0gewo+PiArCXsgLmNvbXBhdGlibGUgPSAi cWNvbSxpcHE1MDE4LXBpbmN0cmwiLCB9LAo+IFBsZWFzZSBtYWtlIHRoaXMgcWNvbSxpcHE1MDE4 LXRsbW0sIGFzIHJlcXVlc3RlZCBpbiB0aGUgYmluZGluZy4KCgogwqBTdXJlIHdpbGwgZG8uCgo+ Cj4gV2l0aCB0aGF0Ogo+Cj4gUmV2aWV3ZWQtYnk6IEJqb3JuIEFuZGVyc3NvbiA8Ympvcm4uYW5k ZXJzc29uQGxpbmFyby5vcmc+CgoKIMKgIFRoYW5rcyBmb3IgdGhhdC4KClJlZ2FyZHMsCiDCoCBT cmljaGFyYW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==