From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F84C4338F for ; Thu, 19 Aug 2021 11:47:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71C6C6109F for ; Thu, 19 Aug 2021 11:47:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71C6C6109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8B40183202; Thu, 19 Aug 2021 13:47:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="fjEWX6o7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E5DF5831FC; Thu, 19 Aug 2021 13:47:32 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F9F383202 for ; Thu, 19 Aug 2021 13:47:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=2865fff45f=patrice.chotard@foss.st.com Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17JBcAhs017479; Thu, 19 Aug 2021 13:47:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=jiuB4sSfWu9fuMMqq+6bImjkzqstd12ENyQj12Wu2Xo=; b=fjEWX6o76mBGmX+otroAtTb420kv2pVsb8nLdiFxzu/QNHoVGRBUh9YBAbSSQXp3n08Z ob0XBN4Jpana38ltjhI9aEubLGTLCfQqPZFrnJkgupSTxZu/ZBsXuS7sbKOS60nPY5Ew 8r0CzIsmK40HLhnmbZLOiMCuQSdaX9oZ87AkggtEvm3DKZbA3B0NNNoPoyxiYWNL2vyw 2eH+Ltu07diFiKq1OzOukyEUrtoJVrAH+3hQ4XmZ8hrgVodZ9cjPBxVrtOWPv/Ucamw+ Qew3o3VkoBbCS0J3BWTW+sKR3PZDaUphFXWhjRJqZ6C+QRjBzfY9qIDF22TSx2FE1xc1 8g== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3ahjva9n2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Aug 2021 13:47:24 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A642110002A; Thu, 19 Aug 2021 13:47:23 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 9B4F9231471; Thu, 19 Aug 2021 13:47:23 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.49) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Aug 2021 13:47:23 +0200 Subject: Re: [PATCH v1 4/7] i2c: stm32f7: support DT binding i2c-analog-filter To: CC: Patrick DELAUNAY , U-Boot STM32 , Heiko Schocher References: <20210803100515.29383-1-patrice.chotard@foss.st.com> <20210803100515.29383-5-patrice.chotard@foss.st.com> From: Patrice CHOTARD Message-ID: <1a725d8b-d1e6-11d3-d4b6-bb1e36e5d00e@foss.st.com> Date: Thu, 19 Aug 2021 13:47:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210803100515.29383-5-patrice.chotard@foss.st.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-19_04:2021-08-17, 2021-08-19 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > Replace driver internally coded enabling/disabling of the > analog-filter with the DT binding "i2c-analog-filter". > > Signed-off-by: Patrick Delaunay > Signed-off-by: Patrice Chotard > --- > > drivers/i2c/stm32f7_i2c.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c > index b449084b5f..e71a0e0aa3 100644 > --- a/drivers/i2c/stm32f7_i2c.c > +++ b/drivers/i2c/stm32f7_i2c.c > @@ -108,7 +108,6 @@ struct stm32_i2c_regs { > #define STM32_I2C_DNF_DEFAULT 0 > #define STM32_I2C_DNF_MAX 16 > > -#define STM32_I2C_ANALOG_FILTER_ENABLE 1 > #define STM32_I2C_ANALOG_FILTER_DELAY_MIN 50 /* ns */ > #define STM32_I2C_ANALOG_FILTER_DELAY_MAX 260 /* ns */ > > @@ -919,7 +918,7 @@ static int stm32_of_to_plat(struct udevice *dev) > STM32_I2C_FALL_TIME_DEFAULT); > > i2c_priv->setup.dnf = STM32_I2C_DNF_DEFAULT; > - i2c_priv->setup.analog_filter = STM32_I2C_ANALOG_FILTER_ENABLE; > + i2c_priv->setup.analog_filter = dev_read_bool(dev, "i2c-analog-filter"); > > /* Optional */ > i2c_priv->regmap = syscon_regmap_lookup_by_phandle(dev, > Reviewed-by: Patrice Chotard Thanks Patrice