All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
	akpm@linux-foundation.org, arunks@codeaurora.org, brgl@bgdev.pl,
	geert+renesas@glider.be, ldufour@linux.ibm.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	mguzik@redhat.com, mhocko@kernel.org, rppt@linux.ibm.com,
	vbabka@suse.cz
Subject: Re: [PATCH 1/3] mm: get_cmdline use arg_lock instead of mmap_sem
Date: Tue, 30 Apr 2019 12:53:51 +0300	[thread overview]
Message-ID: <1a7265fa-610b-1f2a-e55f-b3a307a39bf2@virtuozzo.com> (raw)
In-Reply-To: <20190430093808.GD2673@uranus.lan>

On 30.04.2019 12:38, Cyrill Gorcunov wrote:
> On Tue, Apr 30, 2019 at 12:09:57PM +0300, Kirill Tkhai wrote:
>>
>> This looks OK for me.
>>
>> But speaking about existing code it's a secret for me, why we ignore arg_lock
>> in binfmt code, e.g. in load_elf_binary().
> 
> Well, strictly speaking we probably should but you know setup of
> the @arg_start by kernel's elf loader doesn't cause any side
> effects as far as I can tell (its been working this lockless
> way for years, mmap_sem is taken later in the loader code).
> Though for consistency sake we probably should set it up
> under the spinlock.

Ok, so elf loader doesn't change these parameters. Thanks for the explanation.

  reply	other threads:[~2019-04-30  9:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 12:03 [PATCH] mm: get_cmdline use arg_lock instead of mmap_sem Michal Koutný
2019-04-17 13:41 ` Michal Hocko
2019-04-17 14:41   ` Michal Koutný
2019-04-17 14:55     ` Michal Hocko
2019-04-18 13:50       ` [PATCH] prctl_set_mm: downgrade mmap_sem to read lock Michal Koutný
2019-04-18 14:09         ` Cyrill Gorcunov
2019-04-18 14:15         ` Michal Hocko
2019-04-18 14:27         ` Laurent Dufour
2019-04-18 18:23         ` Cyrill Gorcunov
2019-04-30  8:18           ` [PATCH 0/3] Reduce mmap_sem usage for args manipulation Michal Koutný
2019-04-30  8:18             ` [PATCH 1/3] mm: get_cmdline use arg_lock instead of mmap_sem Michal Koutný
2019-04-30  9:09               ` Kirill Tkhai
2019-04-30  9:38                 ` Cyrill Gorcunov
2019-04-30  9:53                   ` Kirill Tkhai [this message]
2019-04-30 10:45                     ` Cyrill Gorcunov
2019-04-30 10:56                       ` Michal Koutný
2019-04-30 13:24                         ` Cyrill Gorcunov
2019-04-30  8:18             ` [PATCH 2/3] prctl_set_mm: Refactor checks from validate_prctl_map Michal Koutný
2019-04-30  9:27               ` Kirill Tkhai
2019-04-30  8:18             ` [PATCH 3/3] prctl_set_mm: downgrade mmap_sem to read lock Michal Koutný
2019-04-30  8:55               ` Kirill Tkhai
2019-04-30  9:08                 ` Cyrill Gorcunov
2019-04-30  9:11                   ` Kirill Tkhai
2019-05-02 12:52                     ` [PATCH v3 0/2] Reduce mmap_sem usage for args manipulation Michal Koutný
2019-05-02 12:52                       ` [PATCH v3 1/2] prctl_set_mm: Refactor checks from validate_prctl_map Michal Koutný
2019-05-02 20:57                         ` Cyrill Gorcunov
2019-05-02 12:52                       ` [PATCH v3 2/2] prctl_set_mm: downgrade mmap_sem to read lock Michal Koutný
2019-05-02 20:57                         ` Cyrill Gorcunov
2019-05-06  9:28                         ` Kirill Tkhai
2019-05-07 17:42                         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a7265fa-610b-1f2a-e55f-b3a307a39bf2@virtuozzo.com \
    --to=ktkhai@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=arunks@codeaurora.org \
    --cc=brgl@bgdev.pl \
    --cc=geert+renesas@glider.be \
    --cc=gorcunov@gmail.com \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mguzik@redhat.com \
    --cc=mhocko@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=rppt@linux.ibm.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.