All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Lars-Peter Clausen <lars@metafoo.de>, Wolfram Sang <wsa@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>,
	Shubhrajyoti Datta <Shubhrajyoti.datta@amd.com>,
	<linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 1/5] i2c: cadence: Remove unused CDNS_I2C_DATA_INTR_DEPTH define
Date: Mon, 16 Jan 2023 15:37:19 +0100	[thread overview]
Message-ID: <1a7c5204-d1a3-9339-f361-a0504377d103@amd.com> (raw)
In-Reply-To: <20230107211814.1179438-2-lars@metafoo.de>



On 1/7/23 22:18, Lars-Peter Clausen wrote:
> 
> The CDNS_I2C_DATA_INTR_DEPTH is not used in the Cadence I2C driver. Remove
> it.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>   drivers/i2c/busses/i2c-cadence.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index f58943cb1341..71ea658f4bd3 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -115,8 +115,6 @@
>   #define CNDS_I2C_PM_TIMEOUT            1000    /* ms */
> 
>   #define CDNS_I2C_FIFO_DEPTH            16
> -/* FIFO depth at which the DATA interrupt occurs */
> -#define CDNS_I2C_DATA_INTR_DEPTH       (CDNS_I2C_FIFO_DEPTH - 2)
>   #define CDNS_I2C_MAX_TRANSFER_SIZE     255
>   /* Transfer size in multiples of data interrupt depth */
>   #define CDNS_I2C_TRANSFER_SIZE (CDNS_I2C_MAX_TRANSFER_SIZE - 3)
> --
> 2.30.2
> 

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

  reply	other threads:[~2023-01-16 14:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-07 21:18 [PATCH 0/5] i2c: cadence: Small cleanups Lars-Peter Clausen
2023-01-07 21:18 ` [PATCH 1/5] i2c: cadence: Remove unused CDNS_I2C_DATA_INTR_DEPTH define Lars-Peter Clausen
2023-01-16 14:37   ` Michal Simek [this message]
2023-01-20  8:56   ` Wolfram Sang
2023-01-07 21:18 ` [PATCH 2/5] i2c: cadence: Remove `irq` field from driver state struct Lars-Peter Clausen
2023-01-16 14:39   ` Michal Simek
2023-01-20  8:56   ` Wolfram Sang
2023-01-07 21:18 ` [PATCH 3/5] i2c: cadence: Remove redundant expression in if clause Lars-Peter Clausen
2023-01-16 14:44   ` Michal Simek
2023-01-20  8:56   ` Wolfram Sang
2023-01-07 21:18 ` [PATCH 4/5] i2c: cadence: Remove always false ternary operator Lars-Peter Clausen
2023-01-16 15:00   ` Michal Simek
2023-02-27 10:46   ` Michal Simek
2023-03-16 19:29   ` Wolfram Sang
2023-01-07 21:18 ` [PATCH 5/5] i2c: cadence: Remove unnecessary register reads Lars-Peter Clausen
2023-01-16 14:58   ` Michal Simek
2023-01-16 17:14     ` Lars-Peter Clausen
2023-02-27 10:47       ` Michal Simek
2023-03-16 19:28         ` Wolfram Sang
2023-03-16 19:29   ` Wolfram Sang
     [not found] ` <BY5PR12MB4902E8FC89477C6A1038F15281A09@BY5PR12MB4902.namprd12.prod.outlook.com>
2023-02-16  5:18   ` [PATCH 0/5] i2c: cadence: Small cleanups Guntupalli, Manikanta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a7c5204-d1a3-9339-f361-a0504377d103@amd.com \
    --to=michal.simek@amd.com \
    --cc=Shubhrajyoti.datta@amd.com \
    --cc=lars@metafoo.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.