All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralph Campbell <rcampbell@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	"Jason Gunthorpe" <jgg@mellanox.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Ben Skeggs" <bskeggs@redhat.com>
Subject: Re: [PATCH] nouveau/hmm: map pages after migration
Date: Mon, 12 Aug 2019 12:42:30 -0700	[thread overview]
Message-ID: <1a84e6b6-31e6-6955-509f-9883f4a7a322@nvidia.com> (raw)
In-Reply-To: <20190810111308.GB26349@lst.de>


On 8/10/19 4:13 AM, Christoph Hellwig wrote:
> On something vaguely related to this patch:
> 
> You use the NVIF_VMM_PFNMAP_V0_V* defines from nvif/if000c.h, which are
> a little odd as we only ever set these bits, but they also don't seem
> to appear to be in values that are directly fed to the hardware.
> 
> On the other hand mmu/vmm.h defines a set of NVIF_VMM_PFNMAP_V0_*

Yes, I see NVKM_VMM_PFN_*

> constants with similar names and identical values, and those are used
> in mmu/vmmgp100.c and what appears to finally do the low-level dma
> mapping and talking to the hardware.  Are these two sets of constants
> supposed to be the same?  Are the actual hardware values or just a
> driver internal interface?

It looks a bit odd to me too.
I don't really know the structure/history of nouveau.
Perhaps Ben Skeggs can shed more light on your question.

  reply	other threads:[~2019-08-12 19:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 15:02 [PATCH] nouveau/hmm: map pages after migration Ralph Campbell
2019-08-07 15:02 ` Ralph Campbell
2019-08-08  7:07 ` Christoph Hellwig
2019-08-08  7:07   ` Christoph Hellwig
2019-08-08 21:29   ` Ralph Campbell
2019-08-08 21:29     ` Ralph Campbell
2019-08-10 11:13     ` Christoph Hellwig
2019-08-10 11:13       ` Christoph Hellwig
2019-08-12 19:42       ` Ralph Campbell [this message]
     [not found]         ` <1a84e6b6-31e6-6955-509f-9883f4a7a322-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2019-08-16  7:11           ` Christoph Hellwig
     [not found]             ` <20190816071132.GA7513-jcswGhMUV9g@public.gmane.org>
2019-08-17  1:05               ` Ben Skeggs
     [not found]                 ` <CABDvA=n4Y0QticHZowEWFOqiEB3p99nV71GvHAySYdkcgw-Aow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-17  6:11                   ` Christoph Hellwig
2019-08-13 21:58 ` Jerome Glisse
2019-08-15 17:43   ` [Nouveau] " Jerome Glisse
2019-08-15 17:43     ` Jerome Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a84e6b6-31e6-6955-509f-9883f4a7a322@nvidia.com \
    --to=rcampbell@nvidia.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=jgg@mellanox.com \
    --cc=jglisse@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.