From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8322C433F5 for ; Wed, 8 Sep 2021 14:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC37860724 for ; Wed, 8 Sep 2021 14:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349453AbhIHO4x (ORCPT ); Wed, 8 Sep 2021 10:56:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22218 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233754AbhIHO4x (ORCPT ); Wed, 8 Sep 2021 10:56:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631112944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wPyi1CZed/VQjM9QeQlUk6NkrP84hXWMhT35+bSBr00=; b=e3Ouk8rkquFLJQkHt4emohichxcxhVYZELn1GjRUF4267a4kdSgPLcr9IGrcCSc42Nhoin lNtFf7o5eNvJz86F/dywadtZV6yqwc1m62QhBdDdF2U9zR9NarX3vZxGydrb1JmJcwb/Df Jw5MaActJ66V8e0IR8LW/G/RJSOplzk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-44-8hA50QS_P3-LseIaSi3K7A-1; Wed, 08 Sep 2021 10:55:43 -0400 X-MC-Unique: 8hA50QS_P3-LseIaSi3K7A-1 Received: by mail-wr1-f69.google.com with SMTP id s13-20020a5d69cd000000b00159d49442cbso581653wrw.13 for ; Wed, 08 Sep 2021 07:55:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=wPyi1CZed/VQjM9QeQlUk6NkrP84hXWMhT35+bSBr00=; b=rG8hLdvZTiI3d7VczDqTPYdC4KP1bIMztMxZaGfgTwMBQNLlyVXkqNOy9CBWQaQreP b/lEQnL/uZ1f7G0L4SKU5/CCP5UdtX81bI7dnl1EsJySnQ7hX8OAVGcLVhSSroZdopVW kECZLkoo1kcA/WEI3/PSQEY8bNIJVv214L6ymeUlCjoO+wmm/osVRVfpuydtVfSquYrS GzEPlYpgBAWIiNWbkHkfyf7dMgxlTbSBczZ8Xu1p1Xznl6um8RI2HkR7XF27R4I1TMvU pvsL5Hg8RbkwurDWBznuWZdTAJXV6QFca81UD4trRC1owcinZmmPvm5//cMXYROp9AiA Y2Vw== X-Gm-Message-State: AOAM53241mOZe0QhS/rHhta+HfIyG/2rD2yOrBRlPgm5w6+OxQxlwGW+ TrQwaAZC8loSIQosQNK0T9OLamRh94J/x5QV6Jo/BuK8vM1n+zqk2uG4tHfnTOIq1RvDGxk7GQD ncno/g7QPTlq3MI4mAJVOPg== X-Received: by 2002:adf:9ccc:: with SMTP id h12mr4388720wre.385.1631112942450; Wed, 08 Sep 2021 07:55:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycLTNHzn9tnMnVu/eNQGnTKOOzp4Dj5yzly7zQhspAOLUyvL9ZjtkWwfai1z2y2W7MgfLy0w== X-Received: by 2002:adf:9ccc:: with SMTP id h12mr4388689wre.385.1631112942167; Wed, 08 Sep 2021 07:55:42 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6125.dip0.t-ipconnect.de. [91.12.97.37]) by smtp.gmail.com with ESMTPSA id r27sm2423159wrr.70.2021.09.08.07.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 07:55:41 -0700 (PDT) Subject: Re: [patch 031/147] mm, slub: protect put_cpu_partial() with disabled irqs instead of cmpxchg To: Vlastimil Babka , Jesper Dangaard Brouer , Andrew Morton , bigeasy@linutronix.de, cl@linux.com, efault@gmx.de, iamjoonsoo.kim@lge.com, jannh@google.com, linux-mm@kvack.org, mgorman@techsingularity.net, mm-commits@vger.kernel.org, penberg@kernel.org, quic_qiancai@quicinc.com, rientjes@google.com, tglx@linutronix.de, torvalds@linux-foundation.org Cc: brouer@redhat.com References: <20210908025436.dvsgeCXAh%akpm@linux-foundation.org> From: David Hildenbrand Organization: Red Hat Message-ID: <1a8ecf24-dca4-54f2-cdbf-9135b856b773@redhat.com> Date: Wed, 8 Sep 2021 16:55:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org On 08.09.21 15:58, Vlastimil Babka wrote: > On 9/8/21 15:05, Jesper Dangaard Brouer wrote: >> >> >> On 08/09/2021 04.54, Andrew Morton wrote: >>> From: Vlastimil Babka >>> Subject: mm, slub: protect put_cpu_partial() with disabled irqs instead of cmpxchg >>> >>> Jann Horn reported [1] the following theoretically possible race: >>> >>> task A: put_cpu_partial() calls preempt_disable() >>> task A: oldpage = this_cpu_read(s->cpu_slab->partial) >>> interrupt: kfree() reaches unfreeze_partials() and discards the page >>> task B (on another CPU): reallocates page as page cache >>> task A: reads page->pages and page->pobjects, which are actually >>> halves of the pointer page->lru.prev >>> task B (on another CPU): frees page >>> interrupt: allocates page as SLUB page and places it on the percpu partial list >>> task A: this_cpu_cmpxchg() succeeds >>> >>> which would cause page->pages and page->pobjects to end up containing >>> halves of pointers that would then influence when put_cpu_partial() >>> happens and show up in root-only sysfs files. Maybe that's acceptable, >>> I don't know. But there should probably at least be a comment for now >>> to point out that we're reading union fields of a page that might be >>> in a completely different state. >>> >>> Additionally, the this_cpu_cmpxchg() approach in put_cpu_partial() is only >>> safe against s->cpu_slab->partial manipulation in ___slab_alloc() if the >>> latter disables irqs, otherwise a __slab_free() in an irq handler could >>> call put_cpu_partial() in the middle of ___slab_alloc() manipulating >>> ->partial and corrupt it. This becomes an issue on RT after a local_lock >>> is introduced in later patch. The fix means taking the local_lock also in >>> put_cpu_partial() on RT. >>> >>> After debugging this issue, Mike Galbraith suggested [2] that to avoid >>> different locking schemes on RT and !RT, we can just protect >>> put_cpu_partial() with disabled irqs (to be converted to >>> local_lock_irqsave() later) everywhere. This should be acceptable as it's >>> not a fast path, and moving the actual partial unfreezing outside of the >>> irq disabled section makes it short, and with the retry loop gone the code >>> can be also simplified. In addition, the race reported by Jann should no >>> longer be possible. >> >> Based on my microbench[0] measurement changing preempt_disable to >> local_irq_save will cost us 11 cycles (TSC). I'm not against the >> change, I just want people to keep this in mind. > > OK, but this is not a fast path for every allocation/free, so it gets > amortized. Also it eliminates a this_cpu_cmpxchg loop, and I'd expect > cmpxchg to be expensive too? > >> On my E5-1650 v4 @ 3.60GHz: >> - preempt_disable(+enable) cost: 11 cycles(tsc) 3.161 ns >> - local_irq_save (+restore) cost: 22 cycles(tsc) 6.331 ns >> >> Notice the non-save/restore variant is superfast: >> - local_irq_disable(+enable) cost: 6 cycles(tsc) 1.844 ns > > It actually surprises me that it's that cheap, and would have expected > changing the irq state would be the costly part, not the saving/restoring. > Incidentally, would you know what's the cost of save+restore when the > irqs are already disabled, so it's effectively a no-op? It surprises me as well. That would imply that protecting short RCU sections using local_irq_disable local_irq_enable instead of via preempt_disable preempt_enable would actually be very beneficial. Are the numbers trustworthy? :) -- Thanks, David / dhildenb