On 18/03/2019 17:20, Koenig, Christian wrote: >>>   -        if (dma_fence_is_signaled(entries[i].fence)) { >>> +        if (fence) >>> +            entries[i].fence = fence; >>> +        else >>> +            entries[i].fence = dma_fence_get_stub(); >>> + >>> +        if ((flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE) || >> Hey David, >> >> Could you remind me what DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE is used >> for? >> >> I didn't have a use for it in userspace, > The flag is used to wait for fences for a sequence number to show up. > > Christian. > Thanks Christian. I guess I missed the additive nature of WAIT_FOR_SUBMIT. It feels like WAIT_AVAILABLE almost deserves its own commit as it affects both timelines & binary syncobjs. -Lionel