From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749Ab1BDMXU (ORCPT ); Fri, 4 Feb 2011 07:23:20 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:32973 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327Ab1BDMXR (ORCPT ); Fri, 4 Feb 2011 07:23:17 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; b=wmHg4q0FTsuMLglewYrLIThhznsldfAt5C7PWL7dyggzK90lo8Dfa4Jbm9qaGdqWZK ZzM/ZJMZXXlFoCSHDgrsQKi9KIpwgtPD//zmFwxMQQcIkQzVjjOkycjaTnkY9lMSlGGn TNwtYdEF9X9LydPjWY2cjUpBTESYpq/CekBH8= From: Vasiliy Kulikov To: linux-kernel@vger.kernel.org Cc: security@kernel.org, Tony Lindgren , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/20] mach-omap2: mux: world-writable debugfs files Date: Fri, 4 Feb 2011 15:23:13 +0300 Message-Id: <1aa2fe44c18b9f24eb52a1be98d017f1f568e6bb.1296818921.git.segoon@openwall.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not create mux debugfs files as world-writable. Signed-off-by: Vasiliy Kulikov --- Cannot compile the driver, so it is not tested at all. arch/arm/mach-omap2/mux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 98148b6..6c84659 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c @@ -605,7 +605,7 @@ static void __init omap_mux_dbg_create_entry( list_for_each_entry(e, &partition->muxmodes, node) { struct omap_mux *m = &e->mux; - (void)debugfs_create_file(m->muxnames[0], S_IWUGO, mux_dbg_dir, + (void)debugfs_create_file(m->muxnames[0], S_IWUSR, mux_dbg_dir, m, &omap_mux_dbg_signal_fops); } } -- 1.7.0.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: segoon@openwall.com (Vasiliy Kulikov) Date: Fri, 4 Feb 2011 15:23:13 +0300 Subject: [PATCH 01/20] mach-omap2: mux: world-writable debugfs files In-Reply-To: References: Message-ID: <1aa2fe44c18b9f24eb52a1be98d017f1f568e6bb.1296818921.git.segoon@openwall.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Do not create mux debugfs files as world-writable. Signed-off-by: Vasiliy Kulikov --- Cannot compile the driver, so it is not tested at all. arch/arm/mach-omap2/mux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index 98148b6..6c84659 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c @@ -605,7 +605,7 @@ static void __init omap_mux_dbg_create_entry( list_for_each_entry(e, &partition->muxmodes, node) { struct omap_mux *m = &e->mux; - (void)debugfs_create_file(m->muxnames[0], S_IWUGO, mux_dbg_dir, + (void)debugfs_create_file(m->muxnames[0], S_IWUSR, mux_dbg_dir, m, &omap_mux_dbg_signal_fops); } } -- 1.7.0.4