From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC9D1C48BE8 for ; Sun, 13 Jun 2021 18:19:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9151611CE for ; Sun, 13 Jun 2021 18:19:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232017AbhFMSVr (ORCPT ); Sun, 13 Jun 2021 14:21:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232003AbhFMSVq (ORCPT ); Sun, 13 Jun 2021 14:21:46 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB3FEC061766 for ; Sun, 13 Jun 2021 11:19:35 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id c5so11869155wrq.9 for ; Sun, 13 Jun 2021 11:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=X4d/imazEagkhQ425TvhHIJ+mpNOn1pVq8jS+CKK1QM=; b=sOPRIa6agjbd6Bh2PwJOISVNR1sjEitwWIIAZ81ZrECozWeaBMeW/LA2nTc2yNq+Vz /bgEbvjNgIekifWYgvE9iu+7ijfNjakVXM9ys8KBRa2paGr2E2K9hExSPhwbA2zCzbOG mI1KNVuLKoKQut1SIkKlgXU+19qWJiM32dvkhoeM/FBCz0VA97Z3vJYJOJSM65c/V1Lm xOpMGe+EJVvEZmm4r3AHSXTrGqHMNdQncxnURBAIF8bIjcp/MeCfLOuPFn056Bu3C0xD CvBCjr06aBM/kzIzle+qQGcDSYQXhwVJ9EYwqS50gagmenLqp3KqT8t+NQ2XvYiVMxGa xUEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X4d/imazEagkhQ425TvhHIJ+mpNOn1pVq8jS+CKK1QM=; b=oeYxSo3flwQfMIMG9lfMI4eJ7lxh7MDNno87tzxbig1PP/i9x6NpLFKhoXrghpL4Zm hWUx5yjRhC+aYxmIktTcF6xLvZQWmtUpeDX3r2yunP5lRasAZV9zVDMGQWNtZRrJVXaf o7CLno21+eRKc056eqSwyqkDGv9d4gSMThAoai/TNDZWs2H811aJfuYcy8rWIiFOPgqD XLnq+2qxseSH2LlSyE+2NaLTpcrgw93MqS02jHbHVTVb+18VfrkD9/0yuJVFIXAzKsAh AfOUPove1BHGLaLNpgGmctMWeqi2UylNa2MNfyP83SnbP4AVsG18q/mpu4ZN8ZnUxJqG 6lrA== X-Gm-Message-State: AOAM530HUHVLYHCCgWeHzNrLthog8Ffw56taC5QHf5Q0kodgR3kVw+OA CcDLpQUdC84epg+t/6+LbN3yDw== X-Google-Smtp-Source: ABdhPJyZPKxlkgUaN3s1SYbc5n4JbV6v9GU9GsKYsi7K2gZVZA3B6rWdoKOAIjoaUuehL/1izWLlZg== X-Received: by 2002:a5d:59a5:: with SMTP id p5mr14353911wrr.27.1623608374047; Sun, 13 Jun 2021 11:19:34 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:28c8:8dc7:5312:94e2? ([2a01:e34:ed2f:f020:28c8:8dc7:5312:94e2]) by smtp.googlemail.com with ESMTPSA id v8sm14992443wrc.29.2021.06.13.11.19.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Jun 2021 11:19:33 -0700 (PDT) Subject: Re: [PATCH v1 03/10] ARM: tegra: acer-a500: Bump thermal trips by 10C To: Dmitry Osipenko , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Thierry Reding , Jonathan Hunter , Agneli , Paul Fertser , Svyatoslav Ryhel , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210510202600.12156-1-digetx@gmail.com> <20210510202600.12156-4-digetx@gmail.com> <20210514211601.GA1969@qmqm.qmqm.pl> From: Daniel Lezcano Message-ID: <1abadc69-1dd1-5939-c089-37a84be4781b@linaro.org> Date: Sun, 13 Jun 2021 20:19:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 13/06/2021 02:25, Dmitry Osipenko wrote: [ ... ] >> You should set the trip points close to the functioning boundary >> temperature given in the hardware specification whatever the resulting >> heating effect is on the device. >> >> The thermal zone is there to protect the silicon and the system from a >> wild reboot. >> >> If the Nexus 7 is too hot after the changes, then you may act on the >> sources of the heat. For instance, set the the highest OPP to turbo or >> remove it, or, if there is one, change the thermal daemon to reduce the >> overall power consumption. >> In case you are interested in: https://lwn.net/Articles/839318/ > > The DTPM is a very interesting approach. For now Tegra still misses some > basics in mainline kernel which have a higher priority, so I think it > should be good enough to perform the in-kernel thermal management for > the starter. We may consider a more complex solutions later on if will > be necessary. > > What I'm currently thinking to do is: > > 1. Set up the trips of SoC/CPU core thermal zones in accordance to the > silicon limits. > > 2. Set up the skin trips in accordance to the device limits. > > The breached skin trips will cause a mild throttling, while the SoC/CPU > trips will be allowed to cause the severe throttling. Does this sound > good to you? The skin temperature must be managed from userspace. The kernel is unable to do a smart thermal management given different thermal zones but if the goal is to go forward and prevent the tablet to be hot temporarily until the other hardware support is there, I think it is acceptable. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog