* [PATCH] p54: Remove obsolete comment
@ 2021-09-01 2:47 Wan Jiabing
2021-09-01 17:40 ` Christian Lamparter
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-09-01 2:47 UTC (permalink / raw)
To: Christian Lamparter, Kalle Valo, David S. Miller, Jakub Kicinski,
linux-wireless, netdev, linux-kernel
Cc: kael_w, Wan Jiabing
In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
prism54/isl_oid.h is deleted. The comment here is obsolete.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/net/wireless/intersil/p54/fwio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
index bece14e4ff0d..1fe072de3e63 100644
--- a/drivers/net/wireless/intersil/p54/fwio.c
+++ b/drivers/net/wireless/intersil/p54/fwio.c
@@ -583,7 +583,6 @@ int p54_set_edcf(struct p54_common *priv)
rtd = 3 * priv->coverage_class;
edcf->slottime += rtd;
edcf->round_trip_delay = cpu_to_le16(rtd);
- /* (see prism54/isl_oid.h for further details) */
edcf->frameburst = cpu_to_le16(0);
edcf->flags = 0;
memset(edcf->mapping, 0, sizeof(edcf->mapping));
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] p54: Remove obsolete comment
2021-09-01 2:47 [PATCH] p54: Remove obsolete comment Wan Jiabing
@ 2021-09-01 17:40 ` Christian Lamparter
0 siblings, 0 replies; 2+ messages in thread
From: Christian Lamparter @ 2021-09-01 17:40 UTC (permalink / raw)
To: Wan Jiabing, Christian Lamparter, Kalle Valo, David S. Miller,
Jakub Kicinski, linux-wireless, netdev, linux-kernel
Cc: kael_w
On 01/09/2021 04:47, Wan Jiabing wrote:
> In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
> prism54/isl_oid.h is deleted. The comment here is obsolete.
>
Instead of removing said "obsolete" comment, why not copy the
excellent comment about that "frameburst technology" from the
prism54/isl_oid.h file there?
Cheers,
Christian
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/net/wireless/intersil/p54/fwio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
> index bece14e4ff0d..1fe072de3e63 100644
> --- a/drivers/net/wireless/intersil/p54/fwio.c
> +++ b/drivers/net/wireless/intersil/p54/fwio.c
> @@ -583,7 +583,6 @@ int p54_set_edcf(struct p54_common *priv)
> rtd = 3 * priv->coverage_class;
> edcf->slottime += rtd;
> edcf->round_trip_delay = cpu_to_le16(rtd);
> - /* (see prism54/isl_oid.h for further details) */
> edcf->frameburst = cpu_to_le16(0);
> edcf->flags = 0;
> memset(edcf->mapping, 0, sizeof(edcf->mapping));
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-01 17:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 2:47 [PATCH] p54: Remove obsolete comment Wan Jiabing
2021-09-01 17:40 ` Christian Lamparter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.