All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Cc: Ondrej Zary <linux@zary.sk>, Sergey Shtylyov <s.shtylyov@omp.ru>,
	Tim Waugh <tim@cyberelk.net>,
	linux-block@vger.kernel.org, linux-parport@lists.infradead.org,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pata_parport: add driver (PARIDE replacement)
Date: Tue, 31 Jan 2023 08:18:31 +0900	[thread overview]
Message-ID: <1ad62b40-28ed-f452-ecda-6470068b4034@opensource.wdc.com> (raw)
In-Reply-To: <7a2f5b2f-3ed9-eabb-6c9b-dcb2bfe82a08@kernel.dk>

On 1/31/23 00:25, Jens Axboe wrote:
> On 1/30/23 12:10 AM, Damien Le Moal wrote:
>> On 1/30/23 15:48, Christoph Hellwig wrote:
>>> On Sun, Jan 29, 2023 at 08:44:06PM -0700, Jens Axboe wrote:
>>>> I would prefer if we just delete it after merging this one, in the same
>>>> release. I don't think there's any point in delaying, as we're not
>>>> removing any functionality.
>>>>
>>>> You could just queue that up too when adding this patch.
>>>
>>> I'd prefer to just deprecate.  But most importantly I want this patch
>>> in ASAP in some form.
>>
>> I will queue it. But I think it needs a follow up to result in something
>> consistent with KConfig. So either deprecate or delete PARPORT. I can queue the
>> deprecate patch and delete in 6.4, even though I share Jen's opinion to simply
>> delete directly. I am still fine either way.
>>
>> Jens,
>>
>> If you are OK with that, can I get your ack for the deprecate patch ? Unless you
>> prefer taking it through the block tree. Either way is fine with me.
> 
> Yeah I'd be happy to ack that, did you post it? You can add my ack to the
> new driver, fine with that now.

Will do. But I did not want to queue the new driver without killing (or
deprecating) the old code too. Ondrej has now sent 2 patches to remove the old
code. Please ack that !

-- 
Damien Le Moal
Western Digital Research


  reply	other threads:[~2023-01-30 23:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-21 22:53 [PATCH v2] pata_parport: add driver (PARIDE replacement) Ondrej Zary
2023-01-22  7:57 ` Christoph Hellwig
2023-01-22 18:14   ` [PATCH] paride: Mark PARIDE as deprecated, point to PATA_PARPORT Ondrej Zary
2023-01-22 19:11     ` Sergey Shtylyov
2023-01-22 20:10       ` [PATCH v2] " Ondrej Zary
2023-01-23  7:38     ` [PATCH] " Hannes Reinecke
2023-01-22 18:24   ` [PATCH v2] pata_parport: add driver (PARIDE replacement) Jens Axboe
2023-01-23  1:15     ` Damien Le Moal
2023-01-23  6:52     ` Christoph Hellwig
2023-01-23 14:05       ` Jens Axboe
2023-01-23  7:37     ` Hannes Reinecke
2023-01-23  1:03 ` Damien Le Moal
2023-01-23 19:09   ` [PATCH v3] " Ondrej Zary
2023-01-30  3:30     ` Damien Le Moal
2023-01-30  3:44       ` Jens Axboe
2023-01-30  6:48         ` Christoph Hellwig
2023-01-30  7:10           ` Damien Le Moal
2023-01-30 15:25             ` Jens Axboe
2023-01-30 23:18               ` Damien Le Moal [this message]
2023-01-30 15:24           ` Jens Axboe
2023-01-30 21:10       ` [PATCH 1/2] drivers/block: Remove PARIDE core and high-level protocols Ondrej Zary
2023-01-30 21:10         ` [PATCH 2/2] drivers/block: Move PARIDE protocol modules to drivers/ata/pata_parport Ondrej Zary
2023-01-30 23:24           ` Jens Axboe
2023-01-31  2:05           ` Damien Le Moal
2023-01-31 10:24             ` Ondrej Zary
2023-01-31 11:36               ` Damien Le Moal
2023-01-30 23:24         ` [PATCH 1/2] drivers/block: Remove PARIDE core and high-level protocols Jens Axboe
2023-01-23 19:13   ` [PATCH v2] pata_parport: add driver (PARIDE replacement) Ondrej Zary
2023-01-24 10:02 ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ad62b40-28ed-f452-ecda-6470068b4034@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parport@lists.infradead.org \
    --cc=linux@zary.sk \
    --cc=s.shtylyov@omp.ru \
    --cc=tim@cyberelk.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.