From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power Date: Fri, 16 Mar 2018 15:08:13 +0300 Message-ID: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-MW List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Geert Uytterhoeven Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Magnus Damm , Linux-Renesas , Simon Horman , Linux ARM , Marek Vasut List-Id: devicetree@vger.kernel.org On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails >>> need to be kept powered when backup mode is enabled. Reflect this in >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. >>> >>> The accessory power switch (SW23) is a toggle switch, hense specify >>> "rohm,rstbmode-level". >>> >>> Signed-off-by: Geert Uytterhoeven >>> --- >>> v2: >>> - Add rohm,rstbmode-level. >>> --- >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> @@ -376,6 +376,8 @@ >>> #interrupt-cells = <2>; >>> gpio-controller; >>> #gpio-cells = <2>; >>> + rohm,ddr-backup-power = <15>; >> >> Why not 0xf if those are all bit flags? > > Because it's a small number? > Does it matter? I think hex is preferable for the bit flags. Decimal makes one think it's something else -- some magnitude, etc... > Gr{oetje,eeting}s, > > Geert MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:35985 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbeCPMIQ (ORCPT ); Fri, 16 Mar 2018 08:08:16 -0400 Received: by mail-lf0-f68.google.com with SMTP id z143-v6so8753634lff.3 for ; Fri, 16 Mar 2018 05:08:16 -0700 (PDT) Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , Marek Vasut , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> From: Sergei Shtylyov Message-ID: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> Date: Fri, 16 Mar 2018 15:08:13 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails >>> need to be kept powered when backup mode is enabled. Reflect this in >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. >>> >>> The accessory power switch (SW23) is a toggle switch, hense specify >>> "rohm,rstbmode-level". >>> >>> Signed-off-by: Geert Uytterhoeven >>> --- >>> v2: >>> - Add rohm,rstbmode-level. >>> --- >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> @@ -376,6 +376,8 @@ >>> #interrupt-cells = <2>; >>> gpio-controller; >>> #gpio-cells = <2>; >>> + rohm,ddr-backup-power = <15>; >> >> Why not 0xf if those are all bit flags? > > Because it's a small number? > Does it matter? I think hex is preferable for the bit flags. Decimal makes one think it's something else -- some magnitude, etc... > Gr{oetje,eeting}s, > > Geert MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Fri, 16 Mar 2018 15:08:13 +0300 Subject: [PATCH v2 2/3] arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup Power In-Reply-To: References: <1521029386-29975-1-git-send-email-geert+renesas@glider.be> <1521029386-29975-3-git-send-email-geert+renesas@glider.be> <9c6289e4-23dd-c79b-bd1f-058d843739d2@cogentembedded.com> Message-ID: <1ae32fee-578e-1091-561a-200a8036b670@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote: >>> On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails >>> need to be kept powered when backup mode is enabled. Reflect this in >>> the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node. >>> >>> The accessory power switch (SW23) is a toggle switch, hense specify >>> "rohm,rstbmode-level". >>> >>> Signed-off-by: Geert Uytterhoeven >>> --- >>> v2: >>> - Add rohm,rstbmode-level. >>> --- >>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> index 2a7f36abd2dd85c6..80794c38c2669d75 100644 >>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi >>> @@ -376,6 +376,8 @@ >>> #interrupt-cells = <2>; >>> gpio-controller; >>> #gpio-cells = <2>; >>> + rohm,ddr-backup-power = <15>; >> >> Why not 0xf if those are all bit flags? > > Because it's a small number? > Does it matter? I think hex is preferable for the bit flags. Decimal makes one think it's something else -- some magnitude, etc... > Gr{oetje,eeting}s, > > Geert MBR, Sergei