From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C46C433DB for ; Sun, 14 Mar 2021 20:43:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1892E64E7A for ; Sun, 14 Mar 2021 20:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233389AbhCNUnP (ORCPT ); Sun, 14 Mar 2021 16:43:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233923AbhCNUnC (ORCPT ); Sun, 14 Mar 2021 16:43:02 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A9BC061574 for ; Sun, 14 Mar 2021 13:43:01 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lLXZd-00G7LW-C5; Sun, 14 Mar 2021 21:42:53 +0100 Message-ID: <1aebaecdb4c5b3e62f5a89618b9d13f237d6b3c1.camel@sipsolutions.net> Subject: Re: [RFC v8 11/20] um: lkl: basic console support From: Johannes Berg To: Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com Cc: tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com Date: Sun, 14 Mar 2021 21:42:52 +0100 In-Reply-To: <5ec3a7157f7d96943b5701f8d57e102181cd56d2.1611103406.git.thehajime@gmail.com> References: <5ec3a7157f7d96943b5701f8d57e102181cd56d2.1611103406.git.thehajime@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org > > -obj-y := stdio_console.o fd.o chan_kern.o chan_user.o line.o > +ifndef CONFIG_UMMODE_LIB > +obj-y := stdio_console.o > +else > +obj-y := > +endif > +obj-y += fd.o chan_kern.o chan_user.o line.o Might nicer to do via Kconfig, such as config STDIO_CONSOLE def_bool y depends on !UMMODE_LIB and then obj-$(CONFIG_STDIO_CONSOLE) += stdio_console.o here. Similar to CONFIG_STDDER_CONSOLE, after all. > +/** > + * lkl_print - optional operation that receives console messages How is it optional? I don't see you having a __weak definition? johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLXZg-00EWV6-Ng for linux-um@lists.infradead.org; Sun, 14 Mar 2021 20:43:06 +0000 Message-ID: <1aebaecdb4c5b3e62f5a89618b9d13f237d6b3c1.camel@sipsolutions.net> Subject: Re: [RFC v8 11/20] um: lkl: basic console support From: Johannes Berg Date: Sun, 14 Mar 2021 21:42:52 +0100 In-Reply-To: <5ec3a7157f7d96943b5701f8d57e102181cd56d2.1611103406.git.thehajime@gmail.com> References: <5ec3a7157f7d96943b5701f8d57e102181cd56d2.1611103406.git.thehajime@gmail.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com Cc: tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com > > -obj-y := stdio_console.o fd.o chan_kern.o chan_user.o line.o > +ifndef CONFIG_UMMODE_LIB > +obj-y := stdio_console.o > +else > +obj-y := > +endif > +obj-y += fd.o chan_kern.o chan_user.o line.o Might nicer to do via Kconfig, such as config STDIO_CONSOLE def_bool y depends on !UMMODE_LIB and then obj-$(CONFIG_STDIO_CONSOLE) += stdio_console.o here. Similar to CONFIG_STDDER_CONSOLE, after all. > +/** > + * lkl_print - optional operation that receives console messages How is it optional? I don't see you having a __weak definition? johannes _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um