From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC98CC433F5 for ; Sat, 23 Oct 2021 11:28:34 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 033A760F5D for ; Sat, 23 Oct 2021 11:28:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 033A760F5D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0DF0A831B2; Sat, 23 Oct 2021 13:28:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="TYYzZ7RZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0C34683303; Sat, 23 Oct 2021 13:28:30 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AFA5083196 for ; Sat, 23 Oct 2021 13:28:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1634988502; bh=J+xu++VV2rORePxXdfxABt1o12h1p3uPpUbZ+bLck6g=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=TYYzZ7RZLFwTjMR1puiPQFTAeY+7MF2JrUCvgSXy53UWmLdzuSytImoJsod9P3/bF UBd3C3bUFmoH5h1zVwF9NgL7RnpwXUBT0zPcSqX4fvInn5V5Ee8h9iSCWqInWw8+b5 VDgP26RnQJhjHWyO/BV+zeBS+3NPZVLOlfOhAaN8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N0oG5-1ms2z52trp-00wn1M; Sat, 23 Oct 2021 13:28:22 +0200 Message-ID: <1af8b0b1-8b8b-c118-7c2e-e4e0b4897119@gmx.de> Date: Sat, 23 Oct 2021 13:28:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH v2 29/39] efi: Add comments to struct efi_priv Content-Language: en-US To: Simon Glass Cc: Bin Meng , Christian Melki , Tom Rini , Ilias Apalodimas , Alexander Graf , U-Boot Mailing List References: <20210925003055.759305-1-sjg@chromium.org> <20210925003055.759305-14-sjg@chromium.org> From: Heinrich Schuchardt In-Reply-To: <20210925003055.759305-14-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:tceYxx8+LTjQof79YmANO7k/rAUv8MvfT/N+CQ4vBlb/61bL8L0 NDQlQiKZ8jL2PKSPe7mo8JI/jt/Exy5qgBp575RX8/ImOofcPb659ufBBKZQJkoUe6WBlsT awRgqfV/8X55GX/S9SbqBmQt19v6xn/svdHwqxUTGpvB4wGtRnwDffFTsyEVG2Gji8GjMJo fCPtOnSWIS69mH9u8EaSQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:siAu8/luq3M=:8ur40R8KQXHcIwZKuBxTSo 7KPghVPR+zTuX3Oy33J6OIsyvg+N4eT+vD1/Kc3BdvfUjTZTz4TlkA8wOOqBCinAz0tiincFo OtlK8DBKrIg6wxPUulRwLLI0q7QAIMg5fpkdmJdHRA2Gtpc3BbAwqGc9P24pDOi9h6zf4qhdi Kex2H/39vWfi9z4Lag4ZpNgeMjaCCPVwAPGxQMmWIaL8uifooVtkXxrnEeZ0DTs/H10AcGb2l WaWfef0tAdPxLAs4aYCN8Q7UPZLr/tDlmvze+lRHICJs5YvKMIandelqXhlF7c6yDgJQWwvBa W9Bh3CxcIKLHUy6aGDb+/HVOnQZAIfFhf8Z4dA+hlAagiJWgs/a5hYJCsJ1Qay2La3kKLr7dk /Cjz0vxg6qP45+VYpKijmdHDxAsoExLaj+ivnovsHbN4/mk/Z+hqHcEyQEZwrGoloL2//uSV1 M61fzux/y/cAiJG01DGTmgvmmDMjkW02FUt5SC4hJcLvTXSDm9VKiIKspRwppFBVOm4OVFylA 8NQTFDfwRvUEM/UCGYSFzI1o85LwK9TH3GLgClS8RpgVcf6bL/5Z9zt0ROsfr3E8NdvRMNTim sYZnCTLK90pA/pIMCoBtZoDZMmsPZDj/+gGkrTAdk4Z31rqlL20a3JCUgEB0MWePxgBj1KxT+ NxoZSDoLkfR9QXTE1MwHtshfztBo0kG9Llv31NXB6s3TKk0hEAGTZfJbr0qZ6GkXEr9NpR3E6 MD05HjAMTMexe/G3EUIEwUHnEtzVq/jmd+T+6lbnDFY3YUUhtU/jeqaKNgCFk3zlDDPj9RlUK YXATIa7LCJMbIMF1YJVbFeEAgXJ/7YDbjyjcCD9GloDohE26QiKW5f+znfHQruxZ3nxZjTnxH 8zdRqM8mjjJn71xMwLzvvTbNppNuclEQtLu2Urj1nPW5+1KvGbayXeZJwnDn2+9Loxphb16TK l9A/9gonULev9AldoIGn0UvPhaCJm6NtuTf4DdBtCfLsyjdciUgHtsxiahxPl/VX/CsM33krj OoSyg7fxV42rc2J1nbTp890fiiz4V/w0t29Dezlau46DLM7JnfRAC263Kzrb+7HVv7Ckxp+tt i4OJrQPbqgvk94= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/25/21 02:30, Simon Glass wrote: > This structure is uncommented. Fix it. The commit message is incomplete. You are deleting field device path. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > include/efi.h | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/include/efi.h b/include/efi.h > index 908c5dc6ebd..3c215618dab 100644 > --- a/include/efi.h > +++ b/include/efi.h > @@ -400,15 +400,39 @@ static inline struct efi_mem_desc *efi_get_next_me= m_desc( > return (struct efi_mem_desc *)((ulong)desc + map->desc_size); > } > > +/** > + * struct efi_priv - Information about the environment provided by EFI > + * > + * @parent_image: image passed into the EFI app or stub > + * @sys_table: Pointer to system table > + * @boot: Pointer to boot-services table > + * @run: Pointer to runtime-services table > + * > + * Used by app only: Sphinx will render this line *after* all parameters. Please, remove it. ... info_size Size of the info list, in bytes from info next_hdr Pointer to where to put the next header when adding to the list Description =2D---------- Used by app only: Used by stub only: struct efi_system_table *efi_get_sys_table(void) > + * @use_pool_for_malloc: true if all allocation should go through the E= FI 'pool' > + * methods allocate_pool() and free_pool(); false to use 'pages' method= s > + * allocate_pages() and free_pages() > + * @ram_base: Base address of RAM (size CONFIG_EFI_RAM_SIZE) > + * @image_data_type: Type of the loaded image (e.g. EFI_LOADER_CODE) > + * > + * Used by stub only: Remove this line. > + * @info: Header of the info list, holding info collected by the stub a= nd passed > + * to U-Boot > + * @info_size: Size of the info list, in bytes from @info > + * @next_hdr: Pointer to where to put the next header when adding to th= e list > + */ > struct efi_priv { > efi_handle_t parent_image; > - struct efi_device_path *device_path; This change seems to be unrelated. Best regards Heinrich > struct efi_system_table *sys_table; > struct efi_boot_services *boot; > struct efi_runtime_services *run; > + > + /* app: */ > bool use_pool_for_malloc; > unsigned long ram_base; > unsigned int image_data_type; > + > + /* stub: */ > struct efi_info_hdr *info; > unsigned int info_size; > void *next_hdr; >