From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757402AbcIHMdf (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 08:33:35 -0400
Received: from cit-hm8-mail01.bmw-carit.de ([212.118.206.84]:58408 "EHLO
        cit-hm8-gw01.bmw-carit.de" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751420AbcIHMde (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 08:33:34 -0400
X-CTCH-RefID: str=0001.0A0C0205.57D15A77.00CB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0
Subject: Re: [PATCH v4 2/4] firmware: encapsulate firmware loading status
To: Daniel Wagner <wagi@monom.org>, <linux-kernel@vger.kernel.org>
References: <1473237908-20989-1-git-send-email-wagi@monom.org>
 <1473237908-20989-3-git-send-email-wagi@monom.org>
CC: Ming Lei <ming.lei@canonical.com>,
        "Luis R . Rodriguez" <mcgrof@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Message-ID: <1afe5963-cbf2-287b-0abe-5ea352938351@bmw-carit.de>
Date: Thu, 8 Sep 2016 14:32:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1473237908-20989-3-git-send-email-wagi@monom.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.10.50.50]
X-ClientProxiedBy: CIT-HM8-EX01.bmw-carit.intra (10.40.100.13) To
 CIT-HM8-EX01.bmw-carit.intra (10.40.100.13)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/07/2016 10:45 AM, Daniel Wagner wrote:
> @@ -702,7 +760,7 @@ static ssize_t firmware_loading_store(struct device *dev,
>  		dev_err(dev, "%s: unexpected value (%d)\n", __func__, loading);
>  		/* fallthrough */
>  	case -1:
> -		fw_load_abort(fw_priv);
> +		fw_status_aborted(&fw_buf->fw_st);
>  		break;
>  	}

And that change one is wrong. Spinning a new version.