From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH 2/5] nvme: Add ANA base definitions
Date: Sat, 5 May 2018 15:17:32 +0200 [thread overview]
Message-ID: <1b122782-3b1c-0ccd-fd3c-40270337090f@suse.de> (raw)
In-Reply-To: <FED93B0B-94E0-41B2-A790-60C665287037@netapp.com>
On 05/04/2018 07:03 PM, Meneghini, John wrote:
> Agreed:
>
> 95:92 - ANAGRPID
> 103:96 - Reserved
>
> Note that this was changed at the last minute. There are some older drafts of the NVM_TP_4004 out there. You want to be sure to use the ratified version from:
>
> http://nvmexpress.org/resources/specifications/
>
> NVM Express 1.3 Ratified TPs
>
> /John
>
> ?On 5/4/18, 12:16 PM, "Keith Busch" <keith.busch@linux.intel.com> wrote:
>
> On Fri, May 04, 2018@01:28:42PM +0200, Hannes Reinecke wrote:
> > @@ -312,7 +317,8 @@ struct nvme_id_ns {
> > __le16 nabspf;
> > __le16 noiob;
> > __u8 nvmcap[16];
> > - __u8 rsvd64[40];
> > + __u8 rsvd64[36];
> > + __le32 anagrpid;
> > __u8 nguid[16];
> > __u8 eui64[8];
> > struct nvme_lbaf lbaf[16];
>
> Is this the right place for the new field? Your patch has the group ID
> at byte 100. TP4004 has the ANA Group Identifier starting at byte 92,
> followed by 8 reserved bytes, then the NGUID.
>
>
Ah. Hence. Must've looked at an older copy then.
Will be fixing it up.
Cheers,
Hannes
next prev parent reply other threads:[~2018-05-05 13:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 11:28 [RFC PATCH 0/5] nvme: ANA support Hannes Reinecke
2018-05-04 11:28 ` [PATCH 1/5] nvmet: EUI64 support Hannes Reinecke
2018-05-07 7:17 ` Johannes Thumshirn
2018-05-09 7:08 ` Christoph Hellwig
2018-05-09 7:45 ` Hannes Reinecke
2018-05-09 7:52 ` Christoph Hellwig
2018-05-09 15:43 ` Ewan D. Milne
2018-05-04 11:28 ` [PATCH 2/5] nvme: Add ANA base definitions Hannes Reinecke
2018-05-04 16:17 ` Keith Busch
2018-05-04 17:03 ` Meneghini, John
2018-05-04 17:21 ` Knight, Frederick
2018-05-05 13:17 ` Hannes Reinecke [this message]
2018-05-04 21:12 ` Schremmer, Steven
2018-05-09 7:27 ` Christoph Hellwig
2018-05-04 11:28 ` [PATCH 3/5] nvmet: Add ANA base support Hannes Reinecke
2018-05-06 2:42 ` Guan Junxiong
2018-05-04 11:28 ` [PATCH 4/5] block: BLK_STS_NEXUS is a path failure Hannes Reinecke
2018-05-09 7:31 ` Christoph Hellwig
2018-05-04 11:28 ` [PATCH 5/5] nvme: ANA base support Hannes Reinecke
2018-05-04 22:11 ` Schremmer, Steven
2018-05-05 13:23 ` Hannes Reinecke
2018-05-06 3:23 ` Guan Junxiong
2018-05-07 7:21 ` Johannes Thumshirn
2018-05-09 18:49 ` Ewan D. Milne
2018-05-09 19:03 ` Ewan D. Milne
2018-05-10 9:16 ` Sriram Popuri
[not found] ` <CAGYjvj0Mk0MFAfUEApOOyQ9Prm3CvGcZH14PJzDQT2+Qc+w81w@mail.gmail.com>
2018-05-10 13:40 ` Hannes Reinecke
2018-05-11 7:50 ` Hannes Reinecke
2018-05-11 8:22 ` Popuri, Sriram
2018-05-11 8:36 ` Popuri, Sriram
2018-05-11 16:24 ` Knight, Frederick
2018-05-12 13:31 ` Christoph Hellwig
2018-05-13 10:33 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b122782-3b1c-0ccd-fd3c-40270337090f@suse.de \
--to=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.