From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbeC2UBV (ORCPT ); Thu, 29 Mar 2018 16:01:21 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:52744 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbeC2UBU (ORCPT ); Thu, 29 Mar 2018 16:01:20 -0400 Subject: Re: [net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes To: Andrew Lunn CC: , , , , , , , , , References: <1522168309-12338-1-git-send-email-m-karicheri2@ti.com> <1522168309-12338-9-git-send-email-m-karicheri2@ti.com> <20180327173509.GQ5862@lunn.ch> From: Murali Karicheri Organization: Texas Instruments Message-ID: <1b12754d-38b5-d03a-3ba8-90135ad3ead0@ti.com> Date: Thu, 29 Mar 2018 16:03:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180327173509.GQ5862@lunn.ch> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2018 01:35 PM, Andrew Lunn wrote: >> + } else if (slave->link_interface == RGMII_LINK_MAC_PHY) { >> + has_phy = true; >> + phy_mode = of_get_phy_mode(slave->node); >> + /* if phy-mode is not present, default to >> + * PHY_INTERFACE_MODE_RGMII >> + */ >> + if (phy_mode < 0) >> + phy_mode = PHY_INTERFACE_MODE_RGMII; > > Can only do RGMII? Maybe add a call here to > phy_interface_mode_is_rgmii() and return -EINVAL if DT contains > something which is not RGMII? > Ok. Make sense. > Andrew > -- Murali Karicheri Linux Kernel, Keystone From mboxrd@z Thu Jan 1 00:00:00 1970 From: Murali Karicheri Subject: Re: [net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes Date: Thu, 29 Mar 2018 16:03:27 -0400 Message-ID: <1b12754d-38b5-d03a-3ba8-90135ad3ead0@ti.com> References: <1522168309-12338-1-git-send-email-m-karicheri2@ti.com> <1522168309-12338-9-git-send-email-m-karicheri2@ti.com> <20180327173509.GQ5862@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, malat@debian.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, w-kwok2@ti.com, robh+dt@kernel.org, ssantosh@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org To: Andrew Lunn Return-path: In-Reply-To: <20180327173509.GQ5862@lunn.ch> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On 03/27/2018 01:35 PM, Andrew Lunn wrote: >> + } else if (slave->link_interface == RGMII_LINK_MAC_PHY) { >> + has_phy = true; >> + phy_mode = of_get_phy_mode(slave->node); >> + /* if phy-mode is not present, default to >> + * PHY_INTERFACE_MODE_RGMII >> + */ >> + if (phy_mode < 0) >> + phy_mode = PHY_INTERFACE_MODE_RGMII; > > Can only do RGMII? Maybe add a call here to > phy_interface_mode_is_rgmii() and return -EINVAL if DT contains > something which is not RGMII? > Ok. Make sense. > Andrew > -- Murali Karicheri Linux Kernel, Keystone From mboxrd@z Thu Jan 1 00:00:00 1970 From: m-karicheri2@ti.com (Murali Karicheri) Date: Thu, 29 Mar 2018 16:03:27 -0400 Subject: [net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes In-Reply-To: <20180327173509.GQ5862@lunn.ch> References: <1522168309-12338-1-git-send-email-m-karicheri2@ti.com> <1522168309-12338-9-git-send-email-m-karicheri2@ti.com> <20180327173509.GQ5862@lunn.ch> Message-ID: <1b12754d-38b5-d03a-3ba8-90135ad3ead0@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/27/2018 01:35 PM, Andrew Lunn wrote: >> + } else if (slave->link_interface == RGMII_LINK_MAC_PHY) { >> + has_phy = true; >> + phy_mode = of_get_phy_mode(slave->node); >> + /* if phy-mode is not present, default to >> + * PHY_INTERFACE_MODE_RGMII >> + */ >> + if (phy_mode < 0) >> + phy_mode = PHY_INTERFACE_MODE_RGMII; > > Can only do RGMII? Maybe add a call here to > phy_interface_mode_is_rgmii() and return -EINVAL if DT contains > something which is not RGMII? > Ok. Make sense. > Andrew > -- Murali Karicheri Linux Kernel, Keystone