All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Boris Sukholitko <boris.sukholitko@broadcom.com>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Eric Dumazet <edumazet@google.com>,
	zhang kai <zhangkaiheb@126.com>,
	Yoshiki Komachi <komachi.yoshiki@gmail.com>
Cc: Ilya Lifshits <ilya.lifshits@broadcom.com>
Subject: Re: [PATCH net-next 0/5] flower: match on the number of vlan tags
Date: Mon, 11 Apr 2022 10:07:14 -0400	[thread overview]
Message-ID: <1b1b82a9-3e1b-d20a-f62c-f35fe1f155b8@mojatatu.com> (raw)
In-Reply-To: <20220411133100.18126-1-boris.sukholitko@broadcom.com>

On 2022-04-11 09:30, Boris Sukholitko wrote:
> Hi,
> 
> Our customers in the fiber telecom world have network configurations
> where they would like to control their traffic according to the number
> of tags appearing in the packet.
> 
> For example, TR247 GPON conformance test suite specification mostly
> talks about untagged, single, double tagged packets and gives lax
> guidelines on the vlan protocol vs. number of vlan tags.
> 
> This is different from the common IT networks where 802.1Q and 802.1ad
> protocols are usually describe single and double tagged packet. GPON
> configurations that we work with have arbitrary mix the above protocols
> and number of vlan tags in the packet.
> 
> The following patch series implement number of vlans flower filter. They
> add num_of_vlans flower filter as an alternative to vlan ethtype protocol
> matching. The end result is that the following command becomes possible:
> 
> tc filter add dev eth1 ingress flower \
>    num_of_vlans 1 vlan_prio 5 action drop
> 

The idea looks sane. I guess flow dissector is now not just involving
headers but metadata as well. I can see this applied to MPLS for 
example, etc.
Can you please provide more elaborate example of more than 1 vlan?

Where would the line be drawn:
Is it max of two vlans?
Is there potential of <=X, meaning matching of upto X Vlans?

cheers,
jamal

  parent reply	other threads:[~2022-04-11 14:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 13:30 [PATCH net-next 0/5] flower: match on the number of vlan tags Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 1/5] Helper function for vlan ethtype checks Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 2/5] Reduce identation after is_key_vlan refactoring Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 3/5] Add number of vlan tags dissector Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 4/5] Add number of vlan tags filter to the flower Boris Sukholitko
2022-04-11 13:31 ` [PATCH net-next 5/5] Consider the number of vlan tags for vlan filters Boris Sukholitko
2022-04-11 15:34   ` Jiri Pirko
2022-04-12 10:06     ` Boris Sukholitko
2022-04-11 14:07 ` Jamal Hadi Salim [this message]
2022-04-11 14:56   ` [PATCH net-next 0/5] flower: match on the number of vlan tags Boris Sukholitko
2022-04-12 10:54     ` Jamal Hadi Salim
2022-04-14 12:59       ` Boris Sukholitko
  -- strict thread matches above, loose matches on Subject: below --
2022-03-23 10:55 Boris Sukholitko
2022-03-23 17:44 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b1b82a9-3e1b-d20a-f62c-f35fe1f155b8@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=boris.sukholitko@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gustavoars@kernel.org \
    --cc=ilya.lifshits@broadcom.com \
    --cc=jiri@resnulli.us \
    --cc=komachi.yoshiki@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=xiyou.wangcong@gmail.com \
    --cc=zhangkaiheb@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.