From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754598AbdCWJBK (ORCPT ); Thu, 23 Mar 2017 05:01:10 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:40732 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbdCWJBG (ORCPT ); Thu, 23 Mar 2017 05:01:06 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: robh+dt@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 0/2] Fix memory leak in of_pci_get_host_bridge_resources To: Jeffy Chen References: <1490256755-889-1-git-send-email-jeffy.chen@rock-chips.com> Cc: linux-kernel@vger.kernel.org, robh@kernel.org, toshi.kani@hpe.com, briannorris@chromium.org, dianders@chromium.org, bhelgaas@google.com, dtor@chromium.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Frank Rowand , Rob Herring From: Shawn Lin Message-ID: <1b2060aa-09e9-64c8-833f-9d39bb5bc4c3@rock-chips.com> Date: Thu, 23 Mar 2017 17:00:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490256755-889-1-git-send-email-jeffy.chen@rock-chips.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jeffy, On 2017/3/23 16:12, Jeffy Chen wrote: > In of_pci_get_host_bridge_resources, we alloced some struct resource > variables, and they would cause memory leak since no where to free them. > Tested-by: Shawn Lin > Changes in v2: > Don't change the resource_list_create_entry's behavior. > > Jeffy Chen (2): > PCI: return resource_entry in pci_add_resource helpers > of/pci: Fix memory leak in of_pci_get_host_bridge_resources > > drivers/of/of_pci.c | 57 +++++++++++++++++++++++------------------------------ > drivers/pci/bus.c | 13 +++++++----- > include/linux/pci.h | 8 +++++--- > 3 files changed, 38 insertions(+), 40 deletions(-) >