All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Brugger <mbrugger@suse.com>
To: u-boot@lists.denx.de
Subject: [PATCH] config: Enable USB Keyboard support on RPi4
Date: Fri, 8 May 2020 17:55:35 +0200	[thread overview]
Message-ID: <1b2fb46f-8705-06a7-9c71-4c44cecbae67@suse.com> (raw)
In-Reply-To: <20200505145129.19238-1-nsaenzjulienne@suse.de>



On 05/05/2020 16:51, Nicolas Saenz Julienne wrote:
> Supporting USB keyboards out of the box is both handy for development
> and production. Notably if u-boot is used to boot into GRUB.
> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> 
> ---
> 
> Note that rpi_arm64_defconfig already supports USB keyboard. This is to
> be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
> 
>  configs/rpi_4_32b_defconfig | 1 +
>  configs/rpi_4_defconfig     | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig
> index dd7da1cf06..9c5ad7684e 100644
> --- a/configs/rpi_4_32b_defconfig
> +++ b/configs/rpi_4_32b_defconfig
> @@ -42,6 +42,7 @@ CONFIG_DM_USB=y
>  CONFIG_DM_USB_GADGET=y
>  CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_XHCI_PCI=y
> +CONFIG_USB_KEYBOARD=y
>  CONFIG_USB_GADGET=y
>  CONFIG_USB_GADGET_MANUFACTURER="FSL"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x0525

It seems we are missing
CONFIG_SYS_STDIO_DEREGISTER=y
at least for me without this, U-Boot does not build.

Regards,
Matthias

> diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig
> index 6eeec4592e..1a92cd637e 100644
> --- a/configs/rpi_4_defconfig
> +++ b/configs/rpi_4_defconfig
> @@ -42,6 +42,7 @@ CONFIG_DM_USB=y
>  CONFIG_DM_USB_GADGET=y
>  CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_XHCI_PCI=y
> +CONFIG_USB_KEYBOARD=y
>  CONFIG_USB_GADGET=y
>  CONFIG_USB_GADGET_MANUFACTURER="FSL"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> 

  parent reply	other threads:[~2020-05-08 15:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200505145157eucas1p2d0038db1b0129ee7dbc79a23ff211ff9@eucas1p2.samsung.com>
2020-05-05 14:51 ` [PATCH] config: Enable USB Keyboard support on RPi4 Nicolas Saenz Julienne
2020-05-05 15:21   ` Sylwester Nawrocki
2020-05-06  5:35   ` Bin Meng
2020-05-08 15:55   ` Matthias Brugger [this message]
2020-05-08 16:41     ` Sylwester Nawrocki
2020-05-08 19:07       ` Matthias Brugger
2020-07-08 15:49   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b2fb46f-8705-06a7-9c71-4c44cecbae67@suse.com \
    --to=mbrugger@suse.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.