From: Hans Verkuil <hverkuil@xs4all.nl>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>, linux-media@vger.kernel.org
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 4/6] cx88: use generic power management
Date: Fri, 17 Jul 2020 12:49:43 +0200 [thread overview]
Message-ID: <1b3303cb-31c1-f7a6-d6eb-c64cd6f40db6@xs4all.nl> (raw)
In-Reply-To: <20200717103105.GA452501@gmail.com>
On 17/07/2020 12:31, Vaibhav Gupta wrote:
> On Fri, Jul 17, 2020 at 12:54:40PM +0530, Vaibhav Gupta wrote:
>> On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote:
>>> Hi Vaibhav,
>>>
>>> Thank you for the patch! Yet something to improve:
>>>
>>> [auto build test ERROR on linuxtv-media/master]
>>> [also build test ERROR on pci/next v5.8-rc5 next-20200716]
>>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>>> And when submitting patch, we suggest to use '--base' as documented in
>>> https://git-scm.com/docs/git-format-patch]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/pci-use-generic-power-management/20200717-120145
>>> base: git://linuxtv.org/media_tree.git master
>>> config: s390-allmodconfig (attached as .config)
>>> compiler: s390-linux-gcc (GCC) 9.3.0
>>> reproduce (this is a W=1 build):
>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> # save the attached .config to linux build tree
>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers/media/pci/cx88/cx88-video.c: In function 'cx8800_suspend':
>>>>> drivers/media/pci/cx88/cx88-video.c:1564:3: error: implicit declaration of function 'stop_video_dma'; did you mean 'start_video_dma'? [-Werror=implicit-function-declaration]
>>> 1564 | stop_video_dma(dev);
>>> | ^~~~~~~~~~~~~~
>>> | start_video_dma
>>> drivers/media/pci/cx88/cx88-video.c: In function 'cx8800_resume':
>>>>> drivers/media/pci/cx88/cx88-video.c:1600:3: error: implicit declaration of function 'restart_video_queue'; did you mean 'start_video_dma'? [-Werror=implicit-function-declaration]
>>> 1600 | restart_video_queue(dev, &dev->vidq);
>>> | ^~~~~~~~~~~~~~~~~~~
>>> | start_video_dma
>>> cc1: some warnings being treated as errors
>>>
>>> vim +1564 drivers/media/pci/cx88/cx88-video.c
>>>
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1553
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1554 static int __maybe_unused cx8800_suspend(struct device *dev_d)
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1555 {
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1556 struct cx8800_dev *dev = dev_get_drvdata(dev_d);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1557 struct cx88_core *core = dev->core;
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1558 unsigned long flags;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1559
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1560 /* stop video+vbi capture */
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1561 spin_lock_irqsave(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1562 if (!list_empty(&dev->vidq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1563 pr_info("suspend video\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 @1564 stop_video_dma(dev);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1565 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1566 if (!list_empty(&dev->vbiq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1567 pr_info("suspend vbi\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1568 cx8800_stop_vbi_dma(dev);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1569 }
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1570 spin_unlock_irqrestore(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1571
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1572 if (core->ir)
>>> 92f4fc10d7ba01 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2010-03-31 1573 cx88_ir_stop(core);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1574 /* FIXME -- shutdown device */
>>> e52e98a7eccfb0 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1575 cx88_shutdown(core);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1576
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1577 dev->state.disabled = 1;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1578 return 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1579 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1580
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1581 static int __maybe_unused cx8800_resume(struct device *dev_d)
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1582 {
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1583 struct cx8800_dev *dev = dev_get_drvdata(dev_d);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1584 struct cx88_core *core = dev->core;
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1585 unsigned long flags;
>>> 08adb9e20be83b drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1586
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1587 dev->state.disabled = 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1588
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1589 /* FIXME: re-initialize hardware */
>>> e52e98a7eccfb0 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1590 cx88_reset(core);
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1591 if (core->ir)
>>> 92f4fc10d7ba01 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2010-03-31 1592 cx88_ir_start(core);
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1593
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1594 cx_set(MO_PCI_INTMSK, core->pci_irqmask);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1595
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1596 /* restart video+vbi capture */
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1597 spin_lock_irqsave(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1598 if (!list_empty(&dev->vidq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1599 pr_info("resume video\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 @1600 restart_video_queue(dev, &dev->vidq);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1601 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1602 if (!list_empty(&dev->vbiq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1603 pr_info("resume vbi\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1604 cx8800_restart_vbi_queue(dev, &dev->vbiq);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1605 }
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1606 spin_unlock_irqrestore(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1607
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1608 return 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1609 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1610
>>>
>>> ---
>>> 0-DAY CI Kernel Test Service, Intel Corporation
>>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>>
>> Got it. Thanks!
>> Fixed in v3.
>>
>> --Vaibhav Gupta
>
> I fixed the error reported, in this v2 patch-series, by Kbuild and floated v3
> in the mailing list.
> But then I got notification from "[linux-media] Patchwork". It has applied my
> v2 patch series. Please use v3.
The message you got should say that is was superseded, not accepted.
I only marked v2 as Superseded, it wasn't applied.
Regards,
Hans
>
> --Vaibhav Gupta
>
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>, linux-media@vger.kernel.org
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <helgaas@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2 4/6] cx88: use generic power management
Date: Fri, 17 Jul 2020 12:49:43 +0200 [thread overview]
Message-ID: <1b3303cb-31c1-f7a6-d6eb-c64cd6f40db6@xs4all.nl> (raw)
In-Reply-To: <20200717103105.GA452501@gmail.com>
On 17/07/2020 12:31, Vaibhav Gupta wrote:
> On Fri, Jul 17, 2020 at 12:54:40PM +0530, Vaibhav Gupta wrote:
>> On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote:
>>> Hi Vaibhav,
>>>
>>> Thank you for the patch! Yet something to improve:
>>>
>>> [auto build test ERROR on linuxtv-media/master]
>>> [also build test ERROR on pci/next v5.8-rc5 next-20200716]
>>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>>> And when submitting patch, we suggest to use '--base' as documented in
>>> https://git-scm.com/docs/git-format-patch]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/pci-use-generic-power-management/20200717-120145
>>> base: git://linuxtv.org/media_tree.git master
>>> config: s390-allmodconfig (attached as .config)
>>> compiler: s390-linux-gcc (GCC) 9.3.0
>>> reproduce (this is a W=1 build):
>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> # save the attached .config to linux build tree
>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers/media/pci/cx88/cx88-video.c: In function 'cx8800_suspend':
>>>>> drivers/media/pci/cx88/cx88-video.c:1564:3: error: implicit declaration of function 'stop_video_dma'; did you mean 'start_video_dma'? [-Werror=implicit-function-declaration]
>>> 1564 | stop_video_dma(dev);
>>> | ^~~~~~~~~~~~~~
>>> | start_video_dma
>>> drivers/media/pci/cx88/cx88-video.c: In function 'cx8800_resume':
>>>>> drivers/media/pci/cx88/cx88-video.c:1600:3: error: implicit declaration of function 'restart_video_queue'; did you mean 'start_video_dma'? [-Werror=implicit-function-declaration]
>>> 1600 | restart_video_queue(dev, &dev->vidq);
>>> | ^~~~~~~~~~~~~~~~~~~
>>> | start_video_dma
>>> cc1: some warnings being treated as errors
>>>
>>> vim +1564 drivers/media/pci/cx88/cx88-video.c
>>>
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1553
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1554 static int __maybe_unused cx8800_suspend(struct device *dev_d)
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1555 {
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1556 struct cx8800_dev *dev = dev_get_drvdata(dev_d);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1557 struct cx88_core *core = dev->core;
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1558 unsigned long flags;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1559
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1560 /* stop video+vbi capture */
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1561 spin_lock_irqsave(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1562 if (!list_empty(&dev->vidq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1563 pr_info("suspend video\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 @1564 stop_video_dma(dev);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1565 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1566 if (!list_empty(&dev->vbiq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1567 pr_info("suspend vbi\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1568 cx8800_stop_vbi_dma(dev);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1569 }
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1570 spin_unlock_irqrestore(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1571
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1572 if (core->ir)
>>> 92f4fc10d7ba01 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2010-03-31 1573 cx88_ir_stop(core);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1574 /* FIXME -- shutdown device */
>>> e52e98a7eccfb0 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1575 cx88_shutdown(core);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1576
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1577 dev->state.disabled = 1;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1578 return 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1579 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1580
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1581 static int __maybe_unused cx8800_resume(struct device *dev_d)
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1582 {
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1583 struct cx8800_dev *dev = dev_get_drvdata(dev_d);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1584 struct cx88_core *core = dev->core;
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1585 unsigned long flags;
>>> 08adb9e20be83b drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1586
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1587 dev->state.disabled = 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1588
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1589 /* FIXME: re-initialize hardware */
>>> e52e98a7eccfb0 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1590 cx88_reset(core);
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1591 if (core->ir)
>>> 92f4fc10d7ba01 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2010-03-31 1592 cx88_ir_start(core);
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1593
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1594 cx_set(MO_PCI_INTMSK, core->pci_irqmask);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1595
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1596 /* restart video+vbi capture */
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1597 spin_lock_irqsave(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1598 if (!list_empty(&dev->vidq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1599 pr_info("resume video\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 @1600 restart_video_queue(dev, &dev->vidq);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1601 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1602 if (!list_empty(&dev->vbiq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1603 pr_info("resume vbi\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1604 cx8800_restart_vbi_queue(dev, &dev->vbiq);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1605 }
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1606 spin_unlock_irqrestore(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1607
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1608 return 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1609 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1610
>>>
>>> ---
>>> 0-DAY CI Kernel Test Service, Intel Corporation
>>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>>
>> Got it. Thanks!
>> Fixed in v3.
>>
>> --Vaibhav Gupta
>
> I fixed the error reported, in this v2 patch-series, by Kbuild and floated v3
> in the mailing list.
> But then I got notification from "[linux-media] Patchwork". It has applied my
> v2 patch series. Please use v3.
The message you got should say that is was superseded, not accepted.
I only marked v2 as Superseded, it wasn't applied.
Regards,
Hans
>
> --Vaibhav Gupta
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 4/6] cx88: use generic power management
Date: Fri, 17 Jul 2020 12:49:43 +0200 [thread overview]
Message-ID: <1b3303cb-31c1-f7a6-d6eb-c64cd6f40db6@xs4all.nl> (raw)
In-Reply-To: <20200717103105.GA452501@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 9826 bytes --]
On 17/07/2020 12:31, Vaibhav Gupta wrote:
> On Fri, Jul 17, 2020 at 12:54:40PM +0530, Vaibhav Gupta wrote:
>> On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote:
>>> Hi Vaibhav,
>>>
>>> Thank you for the patch! Yet something to improve:
>>>
>>> [auto build test ERROR on linuxtv-media/master]
>>> [also build test ERROR on pci/next v5.8-rc5 next-20200716]
>>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>>> And when submitting patch, we suggest to use '--base' as documented in
>>> https://git-scm.com/docs/git-format-patch]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/pci-use-generic-power-management/20200717-120145
>>> base: git://linuxtv.org/media_tree.git master
>>> config: s390-allmodconfig (attached as .config)
>>> compiler: s390-linux-gcc (GCC) 9.3.0
>>> reproduce (this is a W=1 build):
>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> # save the attached .config to linux build tree
>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers/media/pci/cx88/cx88-video.c: In function 'cx8800_suspend':
>>>>> drivers/media/pci/cx88/cx88-video.c:1564:3: error: implicit declaration of function 'stop_video_dma'; did you mean 'start_video_dma'? [-Werror=implicit-function-declaration]
>>> 1564 | stop_video_dma(dev);
>>> | ^~~~~~~~~~~~~~
>>> | start_video_dma
>>> drivers/media/pci/cx88/cx88-video.c: In function 'cx8800_resume':
>>>>> drivers/media/pci/cx88/cx88-video.c:1600:3: error: implicit declaration of function 'restart_video_queue'; did you mean 'start_video_dma'? [-Werror=implicit-function-declaration]
>>> 1600 | restart_video_queue(dev, &dev->vidq);
>>> | ^~~~~~~~~~~~~~~~~~~
>>> | start_video_dma
>>> cc1: some warnings being treated as errors
>>>
>>> vim +1564 drivers/media/pci/cx88/cx88-video.c
>>>
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1553
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1554 static int __maybe_unused cx8800_suspend(struct device *dev_d)
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1555 {
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1556 struct cx8800_dev *dev = dev_get_drvdata(dev_d);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1557 struct cx88_core *core = dev->core;
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1558 unsigned long flags;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1559
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1560 /* stop video+vbi capture */
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1561 spin_lock_irqsave(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1562 if (!list_empty(&dev->vidq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1563 pr_info("suspend video\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 @1564 stop_video_dma(dev);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1565 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1566 if (!list_empty(&dev->vbiq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1567 pr_info("suspend vbi\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1568 cx8800_stop_vbi_dma(dev);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1569 }
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1570 spin_unlock_irqrestore(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1571
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1572 if (core->ir)
>>> 92f4fc10d7ba01 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2010-03-31 1573 cx88_ir_stop(core);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1574 /* FIXME -- shutdown device */
>>> e52e98a7eccfb0 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1575 cx88_shutdown(core);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1576
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1577 dev->state.disabled = 1;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1578 return 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1579 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1580
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1581 static int __maybe_unused cx8800_resume(struct device *dev_d)
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1582 {
>>> 3bdbfebc5677cf drivers/media/pci/cx88/cx88-video.c Vaibhav Gupta 2020-07-17 1583 struct cx8800_dev *dev = dev_get_drvdata(dev_d);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1584 struct cx88_core *core = dev->core;
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1585 unsigned long flags;
>>> 08adb9e20be83b drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1586
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1587 dev->state.disabled = 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1588
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1589 /* FIXME: re-initialize hardware */
>>> e52e98a7eccfb0 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2005-09-09 1590 cx88_reset(core);
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1591 if (core->ir)
>>> 92f4fc10d7ba01 drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2010-03-31 1592 cx88_ir_start(core);
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1593
>>> 13595a51c0da8e drivers/media/video/cx88/cx88-video.c Mauro Carvalho Chehab 2007-10-01 1594 cx_set(MO_PCI_INTMSK, core->pci_irqmask);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1595
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1596 /* restart video+vbi capture */
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1597 spin_lock_irqsave(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1598 if (!list_empty(&dev->vidq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1599 pr_info("resume video\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 @1600 restart_video_queue(dev, &dev->vidq);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1601 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1602 if (!list_empty(&dev->vbiq.active)) {
>>> 65bc2fe86e6670 drivers/media/pci/cx88/cx88-video.c Mauro Carvalho Chehab 2016-11-13 1603 pr_info("resume vbi\n");
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1604 cx8800_restart_vbi_queue(dev, &dev->vbiq);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1605 }
>>> 5ddfbbb9ca2e74 drivers/media/pci/cx88/cx88-video.c Alexey Khoroshilov 2013-04-13 1606 spin_unlock_irqrestore(&dev->slock, flags);
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1607
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1608 return 0;
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1609 }
>>> ^1da177e4c3f41 drivers/media/video/cx88/cx88-video.c Linus Torvalds 2005-04-16 1610
>>>
>>> ---
>>> 0-DAY CI Kernel Test Service, Intel Corporation
>>> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>>
>> Got it. Thanks!
>> Fixed in v3.
>>
>> --Vaibhav Gupta
>
> I fixed the error reported, in this v2 patch-series, by Kbuild and floated v3
> in the mailing list.
> But then I got notification from "[linux-media] Patchwork". It has applied my
> v2 patch series. Please use v3.
The message you got should say that is was superseded, not accepted.
I only marked v2 as Superseded, it wasn't applied.
Regards,
Hans
>
> --Vaibhav Gupta
>
next prev parent reply other threads:[~2020-07-17 10:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 3:56 [PATCH v2 0/6] [media] pci: use generic power management Vaibhav Gupta
2020-07-17 3:56 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 3:56 ` [PATCH v2 1/6] sta2x11: " Vaibhav Gupta
2020-07-17 3:56 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 3:56 ` [PATCH v2 2/6] cx23885: " Vaibhav Gupta
2020-07-17 3:56 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 3:56 ` [PATCH v2 3/6] cx25821: " Vaibhav Gupta
2020-07-17 3:56 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 3:56 ` [PATCH v2 4/6] cx88: " Vaibhav Gupta
2020-07-17 3:56 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 7:14 ` kernel test robot
2020-07-17 7:14 ` kernel test robot
2020-07-17 7:14 ` [Linux-kernel-mentees] " kernel test robot
2020-07-17 7:24 ` Vaibhav Gupta
2020-07-17 7:24 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 10:31 ` Vaibhav Gupta
2020-07-17 10:31 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 10:49 ` Hans Verkuil [this message]
2020-07-17 10:49 ` Hans Verkuil
2020-07-17 10:49 ` [Linux-kernel-mentees] " Hans Verkuil
2020-07-17 10:51 ` Vaibhav Gupta
2020-07-17 10:51 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 3:56 ` [PATCH v2 5/6] meye: " Vaibhav Gupta
2020-07-17 3:56 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 3:56 ` [PATCH v2 6/6] tw68: " Vaibhav Gupta
2020-07-17 3:56 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-17 4:56 ` [PATCH v2 0/6] [media] pci: " Vaibhav Gupta
2020-07-17 4:56 ` [Linux-kernel-mentees] " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b3303cb-31c1-f7a6-d6eb-c64cd6f40db6@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=helgaas@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.